]> git.karo-electronics.de Git - karo-tx-redboot.git/blobdiff - packages/redboot/v2_0/src/xyzModem.c
TX51 pre-release
[karo-tx-redboot.git] / packages / redboot / v2_0 / src / xyzModem.c
index cb0e197c451e8245a3c154da810b34fa2958861a..c99d5a81091414acdedbce9453e7a55cd469a0bb 100644 (file)
@@ -44,9 +44,9 @@
 // Author(s):    gthomas
 // Contributors: gthomas, tsmith, Yoshinori Sato
 // Date:         2000-07-14
-// Purpose:      
-// Description:  
-//              
+// Purpose:
+// Description:
+//
 // This code is part of RedBoot (tm).
 //
 //####DESCRIPTIONEND####
 
 // Data & state local to the protocol
 static struct {
-    hal_virtual_comm_table_t* __chan;
-    unsigned char pkt[1024], *bufp;
-    unsigned char blk,cblk,crc1,crc2;
-    unsigned char next_blk;  // Expected block
-    int len, mode, total_retries;
-    int total_SOH, total_STX, total_CAN;
-    bool crc_mode, at_eof, tx_ack;
+       hal_virtual_comm_table_t* __chan;
+       unsigned char pkt[1024], *bufp;
+       unsigned char blk,cblk,crc1,crc2;
+       unsigned char next_blk;  // Expected block
+       int len, mode, total_retries;
+       int total_SOH, total_STX, total_CAN;
+       bool crc_mode, at_eof, tx_ack;
 #ifdef USE_YMODEM_LENGTH
-    unsigned long file_length, read_length;
+       unsigned long file_length, read_length;
 #endif
 } xyz;
 
-#define xyzModem_CHAR_TIMEOUT            2000  // 2 seconds
-#define xyzModem_MAX_RETRIES             20
-#define xyzModem_MAX_RETRIES_WITH_CRC    10
-#define xyzModem_CAN_COUNT                3    // Wait for 3 CAN before quitting
+#define xyzModem_CHAR_TIMEOUT                   2000  // 2 seconds
+#define xyzModem_MAX_RETRIES                    20
+#define xyzModem_MAX_RETRIES_WITH_CRC   10
+#define xyzModem_CAN_COUNT                               3        // Wait for 3 CAN before quitting
 
 #ifdef DEBUG
 #ifndef USE_SPRINTF
@@ -99,14 +99,14 @@ static struct {
 static int
 zm_dprintf(char *fmt, ...)
 {
-    int cur_console;
-    va_list args;
-
-    va_start(args, fmt);
-    cur_console = CYGACC_CALL_IF_SET_CONSOLE_COMM(CYGNUM_CALL_IF_SET_COMM_ID_QUERY_CURRENT);
-    CYGACC_CALL_IF_SET_CONSOLE_COMM(1);
-    diag_vprintf(fmt, args);
-    CYGACC_CALL_IF_SET_CONSOLE_COMM(cur_console);
+       int cur_console;
+       va_list args;
+
+       va_start(args, fmt);
+       cur_console = CYGACC_CALL_IF_SET_CONSOLE_COMM(CYGNUM_CALL_IF_SET_COMM_ID_QUERY_CURRENT);
+       CYGACC_CALL_IF_SET_CONSOLE_COMM(1);
+       diag_vprintf(fmt, args);
+       CYGACC_CALL_IF_SET_CONSOLE_COMM(cur_console);
 }
 
 static void
@@ -124,28 +124,28 @@ static char *zm_out_start = (char *)0x00380000;
 static int
 zm_dprintf(char *fmt, ...)
 {
-    int len;
-    va_list args;
+       int len;
+       va_list args;
 
-    va_start(args, fmt);
-    len = diag_vsprintf(zm_out, fmt, args);
-    zm_out += len;
-    return len;
+       va_start(args, fmt);
+       len = diag_vsprintf(zm_out, fmt, args);
+       zm_out += len;
+       return len;
 }
 
 static void
 zm_flush(void)
 {
-    char *p = zm_out_start;
-    while (*p) mon_write_char(*p++);
-    zm_out = zm_out_start;
+       char *p = zm_out_start;
+       while (*p) mon_write_char(*p++);
+       zm_out = zm_out_start;
 }
 #endif
 
 static void
 zm_dump_buf(void *buf, int len)
 {
-    diag_vdump_buf_with_offset(zm_dprintf, buf, len, 0);
+       diag_vdump_buf_with_offset(zm_dprintf, buf, len, 0);
 }
 
 static unsigned char zm_buf[2048];
@@ -154,20 +154,20 @@ static unsigned char *zm_bp;
 static void
 zm_new(void)
 {
-    zm_bp = zm_buf;
+       zm_bp = zm_buf;
 }
 
 static void
 zm_save(unsigned char c)
 {
-    *zm_bp++ = c;
+       *zm_bp++ = c;
 }
 
 static void
 zm_dump(int line)
 {
-    zm_dprintf("Packet at line: %d\n", line);
-    zm_dump_buf(zm_buf, zm_bp-zm_buf);
+       zm_dprintf("Packet at line: %d\n", line);
+       zm_dump_buf(zm_buf, zm_bp-zm_buf);
 }
 
 #define ZM_DEBUG(x) x
@@ -179,330 +179,330 @@ zm_dump(int line)
 static void
 xyzModem_flush(void)
 {
-    int res;
-    char c;
-    while (true) {
-        res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
-        if (!res) return;
-    }
+       int res;
+       char c;
+       while (true) {
+               res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
+               if (!res) return;
+       }
 }
 
 static int
 xyzModem_get_hdr(void)
 {
-    char c;
-    int res;
-    bool hdr_found = false;
-    int i, can_total, hdr_chars;
-    unsigned short cksum;
-
-    ZM_DEBUG(zm_new());
-    // Find the start of a header
-    can_total = 0;
-    hdr_chars = 0;
-
-    if (xyz.tx_ack) {
-        CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
-        xyz.tx_ack = false;
-    }
-    while (!hdr_found) {
-        res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
-        ZM_DEBUG(zm_save(c));
-        if (res) {
-            hdr_chars++;
-            switch (c) {
-            case SOH:
-                xyz.total_SOH++;
-            case STX:
-                if (c == STX) xyz.total_STX++;
-                hdr_found = true;
-                break;
-            case CAN:
-                xyz.total_CAN++;
-                ZM_DEBUG(zm_dump(__LINE__));
-                if (++can_total == xyzModem_CAN_COUNT) {
-                    return xyzModem_cancel;
-                } else {
-                    // Wait for multiple CAN to avoid early quits
-                    break;
-                }
-            case EOT:
-                // EOT only supported if no noise
-                if (hdr_chars == 1) {
-                    CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
-                    ZM_DEBUG(zm_dprintf("ACK on EOT #%d\n", __LINE__));
-                    ZM_DEBUG(zm_dump(__LINE__));
-                    return xyzModem_eof;
-                }
-            default:
-                // Ignore, waiting for start of header
-                ;
-            }
-        } else {
-            // Data stream timed out
-            xyzModem_flush();  // Toss any current input
-            ZM_DEBUG(zm_dump(__LINE__));
-            CYGACC_CALL_IF_DELAY_US((cyg_int32)250000);
-            return xyzModem_timeout;
-        }
-    }
-
-    // Header found, now read the data
-    res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.blk);
-    ZM_DEBUG(zm_save(xyz.blk));
-    if (!res) {
-        ZM_DEBUG(zm_dump(__LINE__));
-        return xyzModem_timeout;
-    }
-    res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.cblk);
-    ZM_DEBUG(zm_save(xyz.cblk));
-    if (!res) {
-        ZM_DEBUG(zm_dump(__LINE__));
-        return xyzModem_timeout;
-    }
-    xyz.len = (c == SOH) ? 128 : 1024;
-    xyz.bufp = xyz.pkt;
-    for (i = 0;  i < xyz.len;  i++) {
-        res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
-        ZM_DEBUG(zm_save(c));
-        if (res) {
-            xyz.pkt[i] = c;
-        } else {
-            ZM_DEBUG(zm_dump(__LINE__));
-            return xyzModem_timeout;
-        }
-    }
-    res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.crc1);
-    ZM_DEBUG(zm_save(xyz.crc1));
-    if (!res) {
-        ZM_DEBUG(zm_dump(__LINE__));
-        return xyzModem_timeout;
-    }
-    if (xyz.crc_mode) {
-        res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.crc2);
-        ZM_DEBUG(zm_save(xyz.crc2));
-        if (!res) {
-            ZM_DEBUG(zm_dump(__LINE__));
-            return xyzModem_timeout;
-        }
-    }
-    ZM_DEBUG(zm_dump(__LINE__));
-    // Validate the message
-    if ((xyz.blk ^ xyz.cblk) != (unsigned char)0xFF) {
-        ZM_DEBUG(zm_dprintf("Framing error - blk: %x/%x/%x\n", xyz.blk, xyz.cblk, (xyz.blk ^ xyz.cblk)));
-        ZM_DEBUG(zm_dump_buf(xyz.pkt, xyz.len));
-        xyzModem_flush();
-        return xyzModem_frame;
-    }
-    // Verify checksum/CRC
-    if (xyz.crc_mode) {
-        cksum = cyg_crc16(xyz.pkt, xyz.len);
-        if (cksum != ((xyz.crc1 << 8) | xyz.crc2)) {
-            ZM_DEBUG(zm_dprintf("CRC error - recvd: %02x%02x, computed: %x\n", 
-                                xyz.crc1, xyz.crc2, cksum & 0xFFFF));
-            return xyzModem_cksum;
-        }
-    } else {
-        cksum = 0;
-        for (i = 0;  i < xyz.len;  i++) {
-            cksum += xyz.pkt[i];
-        }
-        if (xyz.crc1 != (cksum & 0xFF)) {
-            ZM_DEBUG(zm_dprintf("Checksum error - recvd: %x, computed: %x\n", xyz.crc1, cksum & 0xFF));
-            return xyzModem_cksum;
-        }
-    }
-    // If we get here, the message passes [structural] muster
-    return 0;
+       char c;
+       int res;
+       bool hdr_found = false;
+       int i, can_total, hdr_chars;
+       unsigned short cksum;
+
+       ZM_DEBUG(zm_new());
+       // Find the start of a header
+       can_total = 0;
+       hdr_chars = 0;
+
+       if (xyz.tx_ack) {
+               CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
+               xyz.tx_ack = false;
+       }
+       while (!hdr_found) {
+               res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
+               ZM_DEBUG(zm_save(c));
+               if (res) {
+                       hdr_chars++;
+                       switch (c) {
+                       case SOH:
+                               xyz.total_SOH++;
+                       case STX:
+                               if (c == STX) xyz.total_STX++;
+                               hdr_found = true;
+                               break;
+                       case CAN:
+                               xyz.total_CAN++;
+                               ZM_DEBUG(zm_dump(__LINE__));
+                               if (++can_total == xyzModem_CAN_COUNT) {
+                                       return xyzModem_cancel;
+                               }
+                               // Wait for multiple CAN to avoid early quits
+                               break;
+                       case EOT:
+                               // EOT only supported if no noise
+                               if (hdr_chars == 1) {
+                                       CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
+                                       ZM_DEBUG(zm_dprintf("ACK on EOT #%d\n", __LINE__));
+                                       ZM_DEBUG(zm_dump(__LINE__));
+                                       return xyzModem_eof;
+                               }
+                               break;
+                       default:
+                               // Ignore, waiting for start of header
+                               ;
+                       }
+               } else {
+                       // Data stream timed out
+                       xyzModem_flush();  // Toss any current input
+                       ZM_DEBUG(zm_dump(__LINE__));
+                       CYGACC_CALL_IF_DELAY_US((cyg_int32)250000);
+                       return xyzModem_timeout;
+               }
+       }
+
+       // Header found, now read the data
+       res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.blk);
+       ZM_DEBUG(zm_save(xyz.blk));
+       if (!res) {
+               ZM_DEBUG(zm_dump(__LINE__));
+               return xyzModem_timeout;
+       }
+       res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.cblk);
+       ZM_DEBUG(zm_save(xyz.cblk));
+       if (!res) {
+               ZM_DEBUG(zm_dump(__LINE__));
+               return xyzModem_timeout;
+       }
+       xyz.len = (c == SOH) ? 128 : 1024;
+       xyz.bufp = xyz.pkt;
+       for (i = 0;  i < xyz.len;  i++) {
+               res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &c);
+               ZM_DEBUG(zm_save(c));
+               if (res) {
+                       xyz.pkt[i] = c;
+               } else {
+                       ZM_DEBUG(zm_dump(__LINE__));
+                       return xyzModem_timeout;
+               }
+       }
+       res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.crc1);
+       ZM_DEBUG(zm_save(xyz.crc1));
+       if (!res) {
+               ZM_DEBUG(zm_dump(__LINE__));
+               return xyzModem_timeout;
+       }
+       if (xyz.crc_mode) {
+               res = CYGACC_COMM_IF_GETC_TIMEOUT(*xyz.__chan, &xyz.crc2);
+               ZM_DEBUG(zm_save(xyz.crc2));
+               if (!res) {
+                       ZM_DEBUG(zm_dump(__LINE__));
+                       return xyzModem_timeout;
+               }
+       }
+       ZM_DEBUG(zm_dump(__LINE__));
+       // Validate the message
+       if ((xyz.blk ^ xyz.cblk) != (unsigned char)0xFF) {
+               ZM_DEBUG(zm_dprintf("Framing error - blk: %x/%x/%x\n", xyz.blk, xyz.cblk, (xyz.blk ^ xyz.cblk)));
+               ZM_DEBUG(zm_dump_buf(xyz.pkt, xyz.len));
+               xyzModem_flush();
+               return xyzModem_frame;
+       }
+       // Verify checksum/CRC
+       if (xyz.crc_mode) {
+               cksum = cyg_crc16(xyz.pkt, xyz.len);
+               if (cksum != ((xyz.crc1 << 8) | xyz.crc2)) {
+                       ZM_DEBUG(zm_dprintf("CRC error - recvd: %02x%02x, computed: %x\n",
+                                                                               xyz.crc1, xyz.crc2, cksum & 0xFFFF));
+                       return xyzModem_cksum;
+               }
+       } else {
+               cksum = 0;
+               for (i = 0;  i < xyz.len;  i++) {
+                       cksum += xyz.pkt[i];
+               }
+               if (xyz.crc1 != (cksum & 0xFF)) {
+                       ZM_DEBUG(zm_dprintf("Checksum error - recvd: %x, computed: %x\n", xyz.crc1, cksum & 0xFF));
+                       return xyzModem_cksum;
+               }
+       }
+       // If we get here, the message passes [structural] muster
+       return 0;
 }
 
-int 
+int
 xyzModem_stream_open(connection_info_t *info, int *err)
 {
-    int console_chan, stat=0;
-    int retries = xyzModem_MAX_RETRIES;
-    int crc_retries = xyzModem_MAX_RETRIES_WITH_CRC;
+       int console_chan, stat=0;
+       int retries = xyzModem_MAX_RETRIES;
+       int crc_retries = xyzModem_MAX_RETRIES_WITH_CRC;
 
 //    ZM_DEBUG(zm_out = zm_out_start);
 #ifdef xyzModem_zmodem
-    if (info->mode == xyzModem_zmodem) {
-        *err = xyzModem_noZmodem;
-        return -1;
-    }
+       if (info->mode == xyzModem_zmodem) {
+               *err = xyzModem_noZmodem;
+               return -1;
+       }
 #endif
 
-    // Set up the I/O channel.  Note: this allows for using a different port in the future
-    console_chan = CYGACC_CALL_IF_SET_CONSOLE_COMM(CYGNUM_CALL_IF_SET_COMM_ID_QUERY_CURRENT);
-    if (info->chan >= 0) {
-        CYGACC_CALL_IF_SET_CONSOLE_COMM(info->chan);
-    } else {
-        CYGACC_CALL_IF_SET_CONSOLE_COMM(console_chan);
-    }
-    xyz.__chan = CYGACC_CALL_IF_CONSOLE_PROCS();
-    CYGACC_CALL_IF_SET_CONSOLE_COMM(console_chan);
-    CYGACC_COMM_IF_CONTROL(*xyz.__chan, __COMMCTL_SET_TIMEOUT, xyzModem_CHAR_TIMEOUT);
-    xyz.len = 0;
-    xyz.crc_mode = true;
-    xyz.at_eof = false;
-    xyz.tx_ack = false;
-    xyz.mode = info->mode;
-    xyz.total_retries = 0;
-    xyz.total_SOH = 0;
-    xyz.total_STX = 0;
-    xyz.total_CAN = 0;
+       // Set up the I/O channel.  Note: this allows for using a different port in the future
+       console_chan = CYGACC_CALL_IF_SET_CONSOLE_COMM(CYGNUM_CALL_IF_SET_COMM_ID_QUERY_CURRENT);
+       if (info->chan >= 0) {
+               CYGACC_CALL_IF_SET_CONSOLE_COMM(info->chan);
+       } else {
+               CYGACC_CALL_IF_SET_CONSOLE_COMM(console_chan);
+       }
+       xyz.__chan = CYGACC_CALL_IF_CONSOLE_PROCS();
+       CYGACC_CALL_IF_SET_CONSOLE_COMM(console_chan);
+       CYGACC_COMM_IF_CONTROL(*xyz.__chan, __COMMCTL_SET_TIMEOUT, xyzModem_CHAR_TIMEOUT);
+       xyz.len = 0;
+       xyz.crc_mode = true;
+       xyz.at_eof = false;
+       xyz.tx_ack = false;
+       xyz.mode = info->mode;
+       xyz.total_retries = 0;
+       xyz.total_SOH = 0;
+       xyz.total_STX = 0;
+       xyz.total_CAN = 0;
 #ifdef USE_YMODEM_LENGTH
-    xyz.read_length = 0;
-    xyz.file_length = 0;
+       xyz.read_length = 0;
+       xyz.file_length = 0;
 #endif
-    
-    CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
-
-    if (xyz.mode == xyzModem_xmodem) {
-           // X-modem doesn't have an information header - exit here
-            xyz.next_blk = 1;
-            return 0;
-    }
-
-    while (retries-- > 0) {
-        stat = xyzModem_get_hdr();
-        if (stat == 0) {
-            // Y-modem file information header
-            if (xyz.blk == 0) {
+
+       CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
+
+       if (xyz.mode == xyzModem_xmodem) {
+               // X-modem doesn't have an information header - exit here
+               xyz.next_blk = 1;
+               return 0;
+       }
+
+       while (retries-- > 0) {
+               stat = xyzModem_get_hdr();
+               if (stat == 0) {
+                       // Y-modem file information header
+                       if (xyz.blk == 0) {
 #ifdef USE_YMODEM_LENGTH
-                // skip filename
-                while (*xyz.bufp++);
-                // get the length
-                parse_num((char *)xyz.bufp, &xyz.file_length, NULL, " ");
+                               // skip filename
+                               while (*xyz.bufp++);
+                               // get the length
+                               parse_num((char *)xyz.bufp, &xyz.file_length, NULL, " ");
 #endif
-                // The rest of the file name data block quietly discarded
-                xyz.tx_ack = true;
-            }
-            xyz.next_blk = 1;
-            xyz.len = 0;
-            return 0;
-        } else 
-        if (stat == xyzModem_timeout) {
-            if (--crc_retries <= 0) xyz.crc_mode = false;
-            CYGACC_CALL_IF_DELAY_US(5*100000);   // Extra delay for startup
-            CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
-            xyz.total_retries++;
-            ZM_DEBUG(zm_dprintf("NAK (%d)\n", __LINE__));
-        }
-        if (stat == xyzModem_cancel) {
-            break;
-        }
-    }
-    *err = stat;
-    ZM_DEBUG(zm_flush());
-    return -1;
+                               // The rest of the file name data block quietly discarded
+                               xyz.tx_ack = true;
+                       }
+                       xyz.next_blk = 1;
+                       xyz.len = 0;
+                       return 0;
+               } else
+                       if (stat == xyzModem_timeout) {
+                               if (--crc_retries <= 0) xyz.crc_mode = false;
+                               CYGACC_CALL_IF_DELAY_US(5*100000);   // Extra delay for startup
+                               CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
+                               xyz.total_retries++;
+                               ZM_DEBUG(zm_dprintf("NAK (%d)\n", __LINE__));
+                       }
+               if (stat == xyzModem_cancel) {
+                       break;
+               }
+       }
+       *err = stat;
+       ZM_DEBUG(zm_flush());
+       return -1;
 }
 
-int 
+int
 xyzModem_stream_read(void *buf, int size, int *err)
 {
-    int stat, total, len;
-    int retries;
-
-    total = 0;
-    stat = xyzModem_cancel;
-    // Try and get 'size' bytes into the buffer
-    while (!xyz.at_eof && (size > 0)) {
-        if (xyz.len == 0) {
-            retries = xyzModem_MAX_RETRIES;
-            while (retries-- > 0) {
-                stat = xyzModem_get_hdr();
-                if (stat == 0) {
-                    if (xyz.blk == xyz.next_blk) {
-                        xyz.tx_ack = true;
-                        ZM_DEBUG(zm_dprintf("ACK block %d (%d)\n", xyz.blk, __LINE__));
-                        xyz.next_blk = (xyz.next_blk + 1) & 0xFF;
+       int stat, total, len;
+       int retries;
+
+       total = 0;
+       stat = xyzModem_cancel;
+       // Try and get 'size' bytes into the buffer
+       while (!xyz.at_eof && (size > 0)) {
+               if (xyz.len == 0) {
+                       retries = xyzModem_MAX_RETRIES;
+                       while (retries-- > 0) {
+                               stat = xyzModem_get_hdr();
+                               if (stat == 0) {
+                                       if (xyz.blk == xyz.next_blk) {
+                                               xyz.tx_ack = true;
+                                               ZM_DEBUG(zm_dprintf("ACK block %d (%d)\n", xyz.blk, __LINE__));
+                                               xyz.next_blk = (xyz.next_blk + 1) & 0xFF;
 
 #if defined(xyzModem_zmodem) || defined(USE_YMODEM_LENGTH)
-                        if (xyz.mode == xyzModem_xmodem || xyz.file_length == 0) {
+                                               if (xyz.mode == xyzModem_xmodem || xyz.file_length == 0) {
 #else
-                        if (1) {
+                                               if (1) {
 #endif
-                            // Data blocks can be padded with ^Z (EOF) characters
-                            // This code tries to detect and remove them
-                            if ((xyz.bufp[xyz.len-1] == EOF) &&
-                                (xyz.bufp[xyz.len-2] == EOF) &&
-                                (xyz.bufp[xyz.len-3] == EOF)) {
-                                while (xyz.len && (xyz.bufp[xyz.len-1] == EOF)) {
-                                    xyz.len--;
-                                }
-                            }
-                        }
+                                                       // Data blocks can be padded with ^Z (EOF) characters
+                                                       // This code tries to detect and remove them
+                                                       if ((xyz.bufp[xyz.len-1] == EOF) &&
+                                                               (xyz.bufp[xyz.len-2] == EOF) &&
+                                                               (xyz.bufp[xyz.len-3] == EOF)) {
+                                                               while (xyz.len && (xyz.bufp[xyz.len-1] == EOF)) {
+                                                                       xyz.len--;
+                                                               }
+                                                       }
+                                               }
 
 #ifdef USE_YMODEM_LENGTH
-                        // See if accumulated length exceeds that of the file.
-                        // If so, reduce size (i.e., cut out pad bytes)
-                        // Only do this for Y-modem (and Z-modem should it ever
-                        // be supported since it can fall back to Y-modem mode).
-                        if (xyz.mode != xyzModem_xmodem && 0 != xyz.file_length) {
-                            xyz.read_length += xyz.len;
-                            if (xyz.read_length > xyz.file_length) {
-                                xyz.len -= (xyz.read_length - xyz.file_length);
-                            }
-                        }
+                                               // See if accumulated length exceeds that of the file.
+                                               // If so, reduce size (i.e., cut out pad bytes)
+                                               // Only do this for Y-modem (and Z-modem should it ever
+                                               // be supported since it can fall back to Y-modem mode).
+                                               if (xyz.mode != xyzModem_xmodem && 0 != xyz.file_length) {
+                                                       xyz.read_length += xyz.len;
+                                                       if (xyz.read_length > xyz.file_length) {
+                                                               xyz.len -= (xyz.read_length - xyz.file_length);
+                                                       }
+                                               }
 #endif
-                        break;
-                    } else if (xyz.blk == ((xyz.next_blk - 1) & 0xFF)) {
-                        // Just re-ACK this so sender will get on with it
-                        CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
-                        continue;  // Need new header
-                    } else {
-                        stat = xyzModem_sequence;
-                    }
-                }
-                if (stat == xyzModem_cancel) {
-                    break;
-                }
-                if (stat == xyzModem_eof) {
-                    CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
-                    ZM_DEBUG(zm_dprintf("ACK (%d)\n", __LINE__));
-                    if (xyz.mode == xyzModem_ymodem) {
-                        CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
-                        xyz.total_retries++;
-                        ZM_DEBUG(zm_dprintf("Reading Final Header\n"));
-                        stat = xyzModem_get_hdr();                        
-                        CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
-                        ZM_DEBUG(zm_dprintf("FINAL ACK (%d)\n", __LINE__));
-                    }
-                    xyz.at_eof = true;
-                    break;
-                }
-                CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
-                xyz.total_retries++;
-                ZM_DEBUG(zm_dprintf("NAK (%d)\n", __LINE__));
-            }
-            if (stat < 0) {
-                *err = stat;
-                xyz.len = -1;
-                return total;
-            }
-        }
-        // Don't "read" data from the EOF protocol package
-        if (!xyz.at_eof) {
-            len = xyz.len;
-            if (size < len) len = size;
-            memcpy(buf, xyz.bufp, len);
-            size -= len;
-            buf = (char *)buf + len;
-            total += len;
-            xyz.len -= len;
-            xyz.bufp += len;
-        }
-    }
-    return total;
+                                               break;
+                                       } else if (xyz.blk == ((xyz.next_blk - 1) & 0xFF)) {
+                                               // Just re-ACK this so sender will get on with it
+                                               CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
+                                               continue;  // Need new header
+                                       } else {
+                                               stat = xyzModem_sequence;
+                                       }
+                               }
+                               if (stat == xyzModem_cancel) {
+                                       break;
+                               }
+                               if (stat == xyzModem_eof) {
+                                       CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
+                                       ZM_DEBUG(zm_dprintf("ACK (%d)\n", __LINE__));
+                                       if (xyz.mode == xyzModem_ymodem) {
+                                               CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
+                                               xyz.total_retries++;
+                                               ZM_DEBUG(zm_dprintf("Reading Final Header\n"));
+                                               stat = xyzModem_get_hdr();
+                                               CYGACC_COMM_IF_PUTC(*xyz.__chan, ACK);
+                                               ZM_DEBUG(zm_dprintf("FINAL ACK (%d)\n", __LINE__));
+                                       }
+                                       xyz.at_eof = true;
+                                       break;
+                               }
+                               CYGACC_COMM_IF_PUTC(*xyz.__chan, (xyz.crc_mode ? 'C' : NAK));
+                               xyz.total_retries++;
+                               ZM_DEBUG(zm_dprintf("NAK (%d)\n", __LINE__));
+                       }
+                       if (stat < 0) {
+                               *err = stat;
+                               xyz.len = -1;
+                               return total;
+                       }
+               }
+               // Don't "read" data from the EOF protocol package
+               if (!xyz.at_eof) {
+                       len = xyz.len;
+                       if (size < len) len = size;
+                       memcpy(buf, xyz.bufp, len);
+                       size -= len;
+                       buf = (char *)buf + len;
+                       total += len;
+                       xyz.len -= len;
+                       xyz.bufp += len;
+               }
+       }
+       return total;
 }
 
 void
 xyzModem_stream_close(int *err)
 {
-    diag_printf("xyzModem - %s mode, %d(SOH)/%d(STX)/%d(CAN) packets, %d retries\n", 
-                xyz.crc_mode ? "CRC" : "Cksum",
-                xyz.total_SOH, xyz.total_STX, xyz.total_CAN,
-                xyz.total_retries);
+       diag_printf("xyzModem - %s mode, %d(SOH)/%d(STX)/%d(CAN) packets, %d retries\n",
+                               xyz.crc_mode ? "CRC" : "Cksum",
+                               xyz.total_SOH, xyz.total_STX, xyz.total_CAN,
+                               xyz.total_retries);
 //    ZM_DEBUG(zm_flush());
 }
 
@@ -510,88 +510,79 @@ xyzModem_stream_close(int *err)
 // getc
 void xyzModem_stream_terminate(bool abort, int (*getc)(void))
 {
-  int c;
-
-  if (abort) {
-      ZM_DEBUG(zm_dprintf("!!!! TRANSFER ABORT !!!!\n"));
-      switch (xyz.mode) {
-       case xyzModem_xmodem:
-       case xyzModem_ymodem:
-         // The X/YMODEM Spec seems to suggest that multiple CAN followed by an equal
-         // number of Backspaces is a friendly way to get the other end to abort.
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
-         CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
-         // Now consume the rest of what's waiting on the line.
-         ZM_DEBUG(zm_dprintf("Flushing serial line.\n"));
-         xyzModem_flush();
-          xyz.at_eof = true;
-       break;
+       int c;
+
+       if (abort) {
+               ZM_DEBUG(zm_dprintf("!!!! TRANSFER ABORT !!!!\n"));
+               switch (xyz.mode) {
+               case xyzModem_xmodem:
+               case xyzModem_ymodem:
+                       // The X/YMODEM Spec seems to suggest that multiple CAN followed by an equal
+                       // number of Backspaces is a friendly way to get the other end to abort.
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,CAN);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
+                       CYGACC_COMM_IF_PUTC(*xyz.__chan,BSP);
+                       // Now consume the rest of what's waiting on the line.
+                       ZM_DEBUG(zm_dprintf("Flushing serial line.\n"));
+                       xyzModem_flush();
+                       xyz.at_eof = true;
+                       break;
 #ifdef xyzModem_zmodem
-       case xyzModem_zmodem:
-         // Might support it some day I suppose.
+               case xyzModem_zmodem:
+                       // Might support it some day I suppose.
+                       break;
 #endif
-       break;
-      }
-  } else {
-      ZM_DEBUG(zm_dprintf("Engaging cleanup mode...\n"));
-      // Consume any trailing crap left in the inbuffer from
-      // previous recieved blocks. Since very few files are an exact multiple
-      // of the transfer block size, there will almost always be some gunk here.
-      // If we don't eat it now, RedBoot will think the user typed it.
-      ZM_DEBUG(zm_dprintf("Trailing gunk:\n"));
-      while ((c = (*getc)()) > -1) ;
-      ZM_DEBUG(zm_dprintf("\n"));
-      // Make a small delay to give terminal programs like minicom
-      // time to get control again after their file transfer program
-      // exits.
-      CYGACC_CALL_IF_DELAY_US((cyg_int32)250000);
-  }
+               }
+       } else {
+               ZM_DEBUG(zm_dprintf("Engaging cleanup mode...\n"));
+               // Consume any trailing crap left in the inbuffer from
+               // previous recieved blocks. Since very few files are an exact multiple
+               // of the transfer block size, there will almost always be some gunk here.
+               // If we don't eat it now, RedBoot will think the user typed it.
+               ZM_DEBUG(zm_dprintf("Trailing gunk:\n"));
+               while ((c = (*getc)()) > -1) ;
+               ZM_DEBUG(zm_dprintf("\n"));
+               // Make a small delay to give terminal programs like minicom
+               // time to get control again after their file transfer program
+               // exits.
+               CYGACC_CALL_IF_DELAY_US((cyg_int32)250000);
+       }
 }
 
 char *
 xyzModem_error(int err)
 {
-    switch (err) {
-    case xyzModem_access:
-        return "Can't access file";
-        break;
-    case xyzModem_noZmodem:
-        return "Sorry, zModem not available yet";
-        break;
-    case xyzModem_timeout:
-        return "Timed out";
-        break;
-    case xyzModem_eof:
-        return "End of file";
-        break;
-    case xyzModem_cancel:
-        return "Cancelled";
-        break;
-    case xyzModem_frame:
-        return "Invalid framing";
-        break;
-    case xyzModem_cksum:
-        return "CRC/checksum error";
-        break;
-    case xyzModem_sequence:
-        return "Block sequence error";
-        break;
-    default:
-        return "Unknown error";
-        break;
-    }
+       switch (err) {
+       case xyzModem_access:
+               return "Can't access file";
+       case xyzModem_noZmodem:
+               return "Sorry, zModem not available yet";
+       case xyzModem_timeout:
+               return "Timed out";
+       case xyzModem_eof:
+               return "End of file";
+       case xyzModem_cancel:
+               return "Cancelled";
+       case xyzModem_frame:
+               return "Invalid framing";
+       case xyzModem_cksum:
+               return "CRC/checksum error";
+       case xyzModem_sequence:
+               return "Block sequence error";
+       default:
+               return "Unknown error";
+       }
 }
 
 //
 // RedBoot interface
 //
 GETC_IO_FUNCS(xyzModem_io, xyzModem_stream_open, xyzModem_stream_close,
-              xyzModem_stream_terminate, xyzModem_stream_read, xyzModem_error);
+                       xyzModem_stream_terminate, xyzModem_stream_read, xyzModem_error);
 RedBoot_load(xmodem, xyzModem_io, false, false, xyzModem_xmodem);
 RedBoot_load(ymodem, xyzModem_io, false, false, xyzModem_ymodem);