]> git.karo-electronics.de Git - linux-beck.git/commit
lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled
authorDavid Ahern <dsa@cumulusnetworks.com>
Wed, 8 Feb 2017 17:29:00 +0000 (09:29 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2017 14:11:42 +0000 (15:11 +0100)
commit2b7f50d67f5dd7b4f97e413dd8d4ecbf83d723ce
tree4e855b68c5864d31b69afdeed9c9be80d0ae0c17
parent00eff2ebbd229758e90659907724c14dd5a18339
lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled

[ Upstream commit 2bd137de531367fb573d90150d1872cb2a2095f7 ]

An error was reported upgrading to 4.9.8:
    root@Typhoon:~# ip route add default table 210 nexthop dev eth0 via 10.68.64.1
    weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
    RTNETLINK answers: Operation not supported

The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
route is submitted.

The point of lwtunnel_valid_encap_type_attr is catch modules that
need to be loaded before any references are taken with rntl held. With
CONFIG_LWTUNNEL disabled, there will be no modules to load so the
lwtunnel_valid_encap_type_attr stub should just return 0.

Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
Reported-by: pupilla@libero.it
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/lwtunnel.h