]> git.karo-electronics.de Git - linux-beck.git/commit
mfd: 88pm80x: Double shifting bug in suspend/resume
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2016 05:26:56 +0000 (08:26 +0300)
committerLee Jones <lee.jones@linaro.org>
Tue, 4 Oct 2016 14:48:02 +0000 (15:48 +0100)
commit9a6dc644512fd083400a96ac4a035ac154fe6b8d
treefeb9622f78b3d026710e4caf8c089602932acb65
parent7f70495a51889e86930fb3807fa984b8b370eaf3
mfd: 88pm80x: Double shifting bug in suspend/resume

set_bit() and clear_bit() take the bit number so this code is really
doing "1 << (1 << irq)" which is a double shift bug.  It's done
consistently so it won't cause a problem unless "irq" is more than 4.

Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
include/linux/mfd/88pm80x.h