]> git.karo-electronics.de Git - linux-beck.git/commit
Revert "usbtmc: convert to devm_kzalloc"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2016 09:48:44 +0000 (11:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2016 09:51:30 +0000 (11:51 +0200)
commitab21b63e8aedfc73565dd9cdd51eb338341177cb
tree917a36b41513989feabea08e27f1f5f54d46266e
parentdecc5360f23e9efe0252094f47f57f254dcbb3a9
Revert "usbtmc: convert to devm_kzalloc"

This reverts commit e6c7efdcb76f11b04e3d3f71c8d764ab75c9423b.

Turns out it was totally wrong.  The memory is supposed to be bound to
the kref, as the original code was doing correctly, not the
device/driver binding as the devm_kzalloc() would cause.

This fixes an oops when read would be called after the device was
unbound from the driver.

Reported-by: Ladislav Michl <ladis@linux-mips.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable <stable@vger.kernel.org> # 3.12+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/usbtmc.c