]> git.karo-electronics.de Git - linux-beck.git/commit
macvtap: read vnet_hdr_size once
authorWillem de Bruijn <willemb@google.com>
Fri, 3 Feb 2017 23:20:49 +0000 (18:20 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2017 14:11:42 +0000 (15:11 +0100)
commitb90cb484c068b3fd30aee322506d38bcc2f43838
tree4b3ae45d4266d6c2653a57d81f105da9a66bd2ce
parent26989c9d9904e3626443336bcefab0b6e7077d99
macvtap: read vnet_hdr_size once

[ Upstream commit 837585a5375c38d40361cfe64e6fd11e1addb936 ]

When IFF_VNET_HDR is enabled, a virtio_net header must precede data.
Data length is verified to be greater than or equal to expected header
length tun->vnet_hdr_sz before copying.

Macvtap functions read the value once, but unless READ_ONCE is used,
the compiler may ignore this and read multiple times. Enforce a single
read and locally cached value to avoid updates between test and use.

Signed-off-by: Willem de Bruijn <willemb@google.com>
Suggested-by: Eric Dumazet <edumazet@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/macvtap.c