]> git.karo-electronics.de Git - linux-beck.git/commit
net: dsa: bcm_sf2: Unwind errors in correct order
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 29 Jul 2016 19:35:57 +0000 (12:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 31 Jul 2016 06:14:52 +0000 (23:14 -0700)
commitbb9c0fa3aa2932eb3825557e452cac248e709bef
tree7c3f187452ad65bd4244b56dcc3755e27cf72233
parent33c77efbbef92cffd0d1f351fad816eeefbbdeb9
net: dsa: bcm_sf2: Unwind errors in correct order

In case we cannot complete bcm_sf2_sw_setup() for any reason, and we
go to the out_unmap label, but the MDIO bus has not been registered yet,
we will hit the BUG condition in drivers/net/phy/mdio_bus.c about the
bus not being registered. Fix this by dedicating a specific lable for
when we fail after the MDIO bus has been successfully registered.

Fixes: 461cd1b03e32 ("net: dsa: bcm_sf2: Register our slave MDIO bus")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2.c