]> git.karo-electronics.de Git - linux-beck.git/commit
USB: serial: console: fix uninitialised spinlock
authorJohan Hovold <johan@kernel.org>
Wed, 8 Feb 2017 17:53:08 +0000 (18:53 +0100)
committerJohan Hovold <johan@kernel.org>
Wed, 8 Feb 2017 20:20:25 +0000 (21:20 +0100)
commit14816b16fa0adac24f82492f18fa62c55acabbbe
tree5709e76e755d7bfbca4b69340c258b63dc4fa243
parentacfe27633b4c380a67956bd2f73fc9a2c932cc39
USB: serial: console: fix uninitialised spinlock

Since commit 4a510969374a ("tty: Make tty_files_lock per-tty") a new
tty_struct spin lock is taken in the tty release path, but the
USB-serial-console hack was never updated hence leaving the lock of its
"fake" tty uninitialised. This was eventually detected by lockdep.

Make sure to initialise the new lock also for the fake tty to address
this regression.

Yes, this code is a mess, but cleaning it up is left for another day.

Fixes: 4a510969374a ("tty: Make tty_files_lock per-tty")
Cc: stable <stable@vger.kernel.org> # 4.6
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/console.c