]> git.karo-electronics.de Git - linux-beck.git/commit
sctp: avoid BUG_ON on sctp_wait_for_sndbuf
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Mon, 6 Feb 2017 20:10:31 +0000 (18:10 -0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 17:54:59 +0000 (12:54 -0500)
commit2dcab598484185dea7ec22219c76dcdd59e3cb90
treec7d830142ced1ddf6de8fed14222836211b88805
parentbd4ce941c8d5b862b2f83364be5dbe8fc8ab48f8
sctp: avoid BUG_ON on sctp_wait_for_sndbuf

Alexander Popov reported that an application may trigger a BUG_ON in
sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is
waiting on it to queue more data and meanwhile another thread peels off
the association being used by the first thread.

This patch replaces the BUG_ON call with a proper error handling. It
will return -EPIPE to the original sendmsg call, similarly to what would
have been done if the association wasn't found in the first place.

Acked-by: Alexander Popov <alex.popov@linux.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c