]> git.karo-electronics.de Git - linux-beck.git/commit
USB: serial: spcp8x5: fix modem-status handling
authorJohan Hovold <johan@kernel.org>
Thu, 12 Jan 2017 13:56:21 +0000 (14:56 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 16 Jan 2017 15:38:56 +0000 (16:38 +0100)
commit5ed8d41023751bdd3546f2fe4118304357efe8d2
treecc59f9d4e1b211c7a3e893371c76ae9701f5b90a
parent8c34cb8ddfe808d557b51da983ff10c02793beb2
USB: serial: spcp8x5: fix modem-status handling

Make sure to detect short control transfers and return zero on success
when retrieving the modem status.

This fixes the TIOCMGET implementation which since e1ed212d8593 ("USB:
spcp8x5: add proper modem-status support") has returned TIOCM_LE on
successful retrieval, and avoids leaking bits from the stack on short
transfers.

This also fixes the carrier-detect implementation which since the above
mentioned commit unconditionally has returned true.

Fixes: e1ed212d8593 ("USB: spcp8x5: add proper modem-status support")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/spcp8x5.c