]> git.karo-electronics.de Git - linux-beck.git/commit
USB: serial: ftdi_sio: fix line-status over-reporting
authorJohan Hovold <johan@kernel.org>
Thu, 2 Feb 2017 16:38:35 +0000 (17:38 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 6 Feb 2017 17:29:06 +0000 (18:29 +0100)
commita6bb1e17a39818b01b55d8e6238b4b5f06d55038
treee475d176db3be19bf1cbc6756b1b56b0cf754196
parent9a593656def0dc2f6c227851e8e602077267a5f1
USB: serial: ftdi_sio: fix line-status over-reporting

FTDI devices use a receive latency timer to periodically empty the
receive buffer and report modem and line status (also when the buffer is
empty).

When a break or error condition is detected the corresponding status
flags will be set on a packet with nonzero data payload and the flags
are not updated until the break is over or further characters are
received.

In order to avoid over-reporting break and error conditions, these flags
must therefore only be processed for packets with payload.

This specifically fixes the case where after an overrun, the error
condition is continuously reported and NULL-characters inserted until
further data is received.

Reported-by: Michael Walle <michael@walle.cc>
Fixes: 72fda3ca6fc1 ("USB: serial: ftd_sio: implement sysrq handling on
break")
Fixes: 166ceb690750 ("USB: ftdi_sio: clean up line-status handling")
Cc: stable <stable@vger.kernel.org> # v2.6.35
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ftdi_sio.c