]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/gpu/drm/nouveau/nv50_display.c
Merge tag 'v2.6.38' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6
[mv-sheeva.git] / drivers / gpu / drm / nouveau / nv50_display.c
index f624c611ddeaf39cb1c46010d7da30e4461c35ad..7cc94ed9ed9570906a114ac6fb852006dba3a7a3 100644 (file)
@@ -33,6 +33,8 @@
 #include "nouveau_ramht.h"
 #include "drm_crtc_helper.h"
 
+static void nv50_display_isr(struct drm_device *);
+
 static inline int
 nv50_sor_nr(struct drm_device *dev)
 {
@@ -46,159 +48,6 @@ nv50_sor_nr(struct drm_device *dev)
        return 4;
 }
 
-static void
-nv50_evo_channel_del(struct nouveau_channel **pchan)
-{
-       struct nouveau_channel *chan = *pchan;
-
-       if (!chan)
-               return;
-       *pchan = NULL;
-
-       nouveau_gpuobj_channel_takedown(chan);
-       nouveau_bo_unmap(chan->pushbuf_bo);
-       nouveau_bo_ref(NULL, &chan->pushbuf_bo);
-
-       if (chan->user)
-               iounmap(chan->user);
-
-       kfree(chan);
-}
-
-static int
-nv50_evo_dmaobj_new(struct nouveau_channel *evo, uint32_t class, uint32_t name,
-                   uint32_t tile_flags, uint32_t magic_flags,
-                   uint32_t offset, uint32_t limit)
-{
-       struct drm_nouveau_private *dev_priv = evo->dev->dev_private;
-       struct drm_device *dev = evo->dev;
-       struct nouveau_gpuobj *obj = NULL;
-       int ret;
-
-       ret = nouveau_gpuobj_new(dev, evo, 6*4, 32, 0, &obj);
-       if (ret)
-               return ret;
-       obj->engine = NVOBJ_ENGINE_DISPLAY;
-
-       nv_wo32(obj,  0, (tile_flags << 22) | (magic_flags << 16) | class);
-       nv_wo32(obj,  4, limit);
-       nv_wo32(obj,  8, offset);
-       nv_wo32(obj, 12, 0x00000000);
-       nv_wo32(obj, 16, 0x00000000);
-       if (dev_priv->card_type < NV_C0)
-               nv_wo32(obj, 20, 0x00010000);
-       else
-               nv_wo32(obj, 20, 0x00020000);
-       dev_priv->engine.instmem.flush(dev);
-
-       ret = nouveau_ramht_insert(evo, name, obj);
-       nouveau_gpuobj_ref(NULL, &obj);
-       if (ret) {
-               return ret;
-       }
-
-       return 0;
-}
-
-static int
-nv50_evo_channel_new(struct drm_device *dev, struct nouveau_channel **pchan)
-{
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_gpuobj *ramht = NULL;
-       struct nouveau_channel *chan;
-       int ret;
-
-       chan = kzalloc(sizeof(struct nouveau_channel), GFP_KERNEL);
-       if (!chan)
-               return -ENOMEM;
-       *pchan = chan;
-
-       chan->id = -1;
-       chan->dev = dev;
-       chan->user_get = 4;
-       chan->user_put = 0;
-
-       ret = nouveau_gpuobj_new(dev, NULL, 32768, 0x1000,
-                                NVOBJ_FLAG_ZERO_ALLOC, &chan->ramin);
-       if (ret) {
-               NV_ERROR(dev, "Error allocating EVO channel memory: %d\n", ret);
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       ret = drm_mm_init(&chan->ramin_heap, 0, 32768);
-       if (ret) {
-               NV_ERROR(dev, "Error initialising EVO PRAMIN heap: %d\n", ret);
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       ret = nouveau_gpuobj_new(dev, chan, 4096, 16, 0, &ramht);
-       if (ret) {
-               NV_ERROR(dev, "Unable to allocate EVO RAMHT: %d\n", ret);
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       ret = nouveau_ramht_new(dev, ramht, &chan->ramht);
-       nouveau_gpuobj_ref(NULL, &ramht);
-       if (ret) {
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       if (dev_priv->chipset != 0x50) {
-               ret = nv50_evo_dmaobj_new(chan, 0x3d, NvEvoFB16, 0x70, 0x19,
-                                         0, 0xffffffff);
-               if (ret) {
-                       nv50_evo_channel_del(pchan);
-                       return ret;
-               }
-
-
-               ret = nv50_evo_dmaobj_new(chan, 0x3d, NvEvoFB32, 0x7a, 0x19,
-                                         0, 0xffffffff);
-               if (ret) {
-                       nv50_evo_channel_del(pchan);
-                       return ret;
-               }
-       }
-
-       ret = nv50_evo_dmaobj_new(chan, 0x3d, NvEvoVRAM, 0, 0x19,
-                                 0, dev_priv->vram_size);
-       if (ret) {
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       ret = nouveau_bo_new(dev, NULL, 4096, 0, TTM_PL_FLAG_VRAM, 0, 0,
-                            false, true, &chan->pushbuf_bo);
-       if (ret == 0)
-               ret = nouveau_bo_pin(chan->pushbuf_bo, TTM_PL_FLAG_VRAM);
-       if (ret) {
-               NV_ERROR(dev, "Error creating EVO DMA push buffer: %d\n", ret);
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       ret = nouveau_bo_map(chan->pushbuf_bo);
-       if (ret) {
-               NV_ERROR(dev, "Error mapping EVO DMA push buffer: %d\n", ret);
-               nv50_evo_channel_del(pchan);
-               return ret;
-       }
-
-       chan->user = ioremap(pci_resource_start(dev->pdev, 0) +
-                                       NV50_PDISPLAY_USER(0), PAGE_SIZE);
-       if (!chan->user) {
-               NV_ERROR(dev, "Error mapping EVO control regs.\n");
-               nv50_evo_channel_del(pchan);
-               return -ENOMEM;
-       }
-
-       return 0;
-}
-
 int
 nv50_display_early_init(struct drm_device *dev)
 {
@@ -214,17 +63,16 @@ int
 nv50_display_init(struct drm_device *dev)
 {
        struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_timer_engine *ptimer = &dev_priv->engine.timer;
        struct nouveau_gpio_engine *pgpio = &dev_priv->engine.gpio;
-       struct nouveau_channel *evo = dev_priv->evo;
        struct drm_connector *connector;
-       uint32_t val, ram_amount;
-       uint64_t start;
+       struct nouveau_channel *evo;
        int ret, i;
+       u32 val;
 
        NV_DEBUG_KMS(dev, "\n");
 
        nv_wr32(dev, 0x00610184, nv_rd32(dev, 0x00614004));
+
        /*
         * I think the 0x006101XX range is some kind of main control area
         * that enables things.
@@ -240,16 +88,19 @@ nv50_display_init(struct drm_device *dev)
                val = nv_rd32(dev, 0x0061610c + (i * 0x800));
                nv_wr32(dev, 0x0061019c + (i * 0x10), val);
        }
+
        /* DAC */
        for (i = 0; i < 3; i++) {
                val = nv_rd32(dev, 0x0061a000 + (i * 0x800));
                nv_wr32(dev, 0x006101d0 + (i * 0x04), val);
        }
+
        /* SOR */
        for (i = 0; i < nv50_sor_nr(dev); i++) {
                val = nv_rd32(dev, 0x0061c000 + (i * 0x800));
                nv_wr32(dev, 0x006101e0 + (i * 0x04), val);
        }
+
        /* EXT */
        for (i = 0; i < 3; i++) {
                val = nv_rd32(dev, 0x0061e000 + (i * 0x800));
@@ -262,17 +113,6 @@ nv50_display_init(struct drm_device *dev)
                nv_wr32(dev, NV50_PDISPLAY_DAC_CLK_CTRL1(i), 0x00000001);
        }
 
-       /* This used to be in crtc unblank, but seems out of place there. */
-       nv_wr32(dev, NV50_PDISPLAY_UNK_380, 0);
-       /* RAM is clamped to 256 MiB. */
-       ram_amount = dev_priv->vram_size;
-       NV_DEBUG_KMS(dev, "ram_amount %d\n", ram_amount);
-       if (ram_amount > 256*1024*1024)
-               ram_amount = 256*1024*1024;
-       nv_wr32(dev, NV50_PDISPLAY_RAM_AMOUNT, ram_amount - 1);
-       nv_wr32(dev, NV50_PDISPLAY_UNK_388, 0x150000);
-       nv_wr32(dev, NV50_PDISPLAY_UNK_38C, 0);
-
        /* The precise purpose is unknown, i suspect it has something to do
         * with text mode.
         */
@@ -287,37 +127,6 @@ nv50_display_init(struct drm_device *dev)
                }
        }
 
-       /* taken from nv bug #12637, attempts to un-wedge the hw if it's
-        * stuck in some unspecified state
-        */
-       start = ptimer->read(dev);
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0), 0x2b00);
-       while ((val = nv_rd32(dev, NV50_PDISPLAY_CHANNEL_STAT(0))) & 0x1e0000) {
-               if ((val & 0x9f0000) == 0x20000)
-                       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0),
-                                                       val | 0x800000);
-
-               if ((val & 0x3f0000) == 0x30000)
-                       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0),
-                                                       val | 0x200000);
-
-               if (ptimer->read(dev) - start > 1000000000ULL) {
-                       NV_ERROR(dev, "timeout: (0x610200 & 0x1e0000) != 0\n");
-                       NV_ERROR(dev, "0x610200 = 0x%08x\n", val);
-                       return -EBUSY;
-               }
-       }
-
-       nv_wr32(dev, NV50_PDISPLAY_CTRL_STATE, NV50_PDISPLAY_CTRL_STATE_ENABLE);
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0), 0x1000b03);
-       if (!nv_wait(dev, NV50_PDISPLAY_CHANNEL_STAT(0),
-                    0x40000000, 0x40000000)) {
-               NV_ERROR(dev, "timeout: (0x610200 & 0x40000000) == 0x40000000\n");
-               NV_ERROR(dev, "0x610200 = 0x%08x\n",
-                         nv_rd32(dev, NV50_PDISPLAY_CHANNEL_STAT(0)));
-               return -EBUSY;
-       }
-
        for (i = 0; i < 2; i++) {
                nv_wr32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i), 0x2000);
                if (!nv_wait(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
@@ -341,39 +150,31 @@ nv50_display_init(struct drm_device *dev)
                }
        }
 
-       nv_wr32(dev, NV50_PDISPLAY_OBJECTS, (evo->ramin->vinst >> 8) | 9);
+       nv_wr32(dev, NV50_PDISPLAY_PIO_CTRL, 0x00000000);
+       nv_mask(dev, NV50_PDISPLAY_INTR_0, 0x00000000, 0x00000000);
+       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_0, 0x00000000);
+       nv_mask(dev, NV50_PDISPLAY_INTR_1, 0x00000000, 0x00000000);
+       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_1,
+                    NV50_PDISPLAY_INTR_EN_1_CLK_UNK10 |
+                    NV50_PDISPLAY_INTR_EN_1_CLK_UNK20 |
+                    NV50_PDISPLAY_INTR_EN_1_CLK_UNK40);
+
+       /* enable hotplug interrupts */
+       list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
+               struct nouveau_connector *conn = nouveau_connector(connector);
 
-       /* initialise fifo */
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_DMA_CB(0),
-               ((evo->pushbuf_bo->bo.mem.start << PAGE_SHIFT) >> 8) |
-               NV50_PDISPLAY_CHANNEL_DMA_CB_LOCATION_VRAM |
-               NV50_PDISPLAY_CHANNEL_DMA_CB_VALID);
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_UNK2(0), 0x00010000);
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_UNK3(0), 0x00000002);
-       if (!nv_wait(dev, 0x610200, 0x80000000, 0x00000000)) {
-               NV_ERROR(dev, "timeout: (0x610200 & 0x80000000) == 0\n");
-               NV_ERROR(dev, "0x610200 = 0x%08x\n", nv_rd32(dev, 0x610200));
-               return -EBUSY;
+               if (conn->dcb->gpio_tag == 0xff)
+                       continue;
+
+               pgpio->irq_enable(dev, conn->dcb->gpio_tag, true);
        }
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0),
-               (nv_rd32(dev, NV50_PDISPLAY_CHANNEL_STAT(0)) & ~0x00000003) |
-                NV50_PDISPLAY_CHANNEL_STAT_DMA_ENABLED);
-       nv_wr32(dev, NV50_PDISPLAY_USER_PUT(0), 0);
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0), 0x01000003 |
-               NV50_PDISPLAY_CHANNEL_STAT_DMA_ENABLED);
-       nv_wr32(dev, 0x610300, nv_rd32(dev, 0x610300) & ~1);
-
-       evo->dma.max = (4096/4) - 2;
-       evo->dma.put = 0;
-       evo->dma.cur = evo->dma.put;
-       evo->dma.free = evo->dma.max - evo->dma.cur;
-
-       ret = RING_SPACE(evo, NOUVEAU_DMA_SKIPS);
+
+       ret = nv50_evo_init(dev);
        if (ret)
                return ret;
+       evo = dev_priv->evo;
 
-       for (i = 0; i < NOUVEAU_DMA_SKIPS; i++)
-               OUT_RING(evo, 0);
+       nv_wr32(dev, NV50_PDISPLAY_OBJECTS, (evo->ramin->vinst >> 8) | 9);
 
        ret = RING_SPACE(evo, 11);
        if (ret)
@@ -393,21 +194,6 @@ nv50_display_init(struct drm_device *dev)
        if (!nv_wait(dev, 0x640004, 0xffffffff, evo->dma.put << 2))
                NV_ERROR(dev, "evo pushbuf stalled\n");
 
-       /* enable clock change interrupts. */
-       nv_wr32(dev, 0x610028, 0x00010001);
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN, (NV50_PDISPLAY_INTR_EN_CLK_UNK10 |
-                                            NV50_PDISPLAY_INTR_EN_CLK_UNK20 |
-                                            NV50_PDISPLAY_INTR_EN_CLK_UNK40));
-
-       /* enable hotplug interrupts */
-       list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
-               struct nouveau_connector *conn = nouveau_connector(connector);
-
-               if (conn->dcb->gpio_tag == 0xff)
-                       continue;
-
-               pgpio->irq_enable(dev, conn->dcb->gpio_tag, true);
-       }
 
        return 0;
 }
@@ -452,13 +238,7 @@ static int nv50_display_disable(struct drm_device *dev)
                }
        }
 
-       nv_wr32(dev, NV50_PDISPLAY_CHANNEL_STAT(0), 0);
-       nv_wr32(dev, NV50_PDISPLAY_CTRL_STATE, 0);
-       if (!nv_wait(dev, NV50_PDISPLAY_CHANNEL_STAT(0), 0x1e0000, 0)) {
-               NV_ERROR(dev, "timeout: (0x610200 & 0x1e0000) == 0\n");
-               NV_ERROR(dev, "0x610200 = 0x%08x\n",
-                         nv_rd32(dev, NV50_PDISPLAY_CHANNEL_STAT(0)));
-       }
+       nv50_evo_fini(dev);
 
        for (i = 0; i < 3; i++) {
                if (!nv_wait(dev, NV50_PDISPLAY_SOR_DPMS_STATE(i),
@@ -470,7 +250,7 @@ static int nv50_display_disable(struct drm_device *dev)
        }
 
        /* disable interrupts. */
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN, 0x00000000);
+       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_1, 0x00000000);
 
        /* disable hotplug interrupts */
        nv_wr32(dev, 0xe054, 0xffffffff);
@@ -508,13 +288,6 @@ int nv50_display_create(struct drm_device *dev)
 
        dev->mode_config.fb_base = dev_priv->fb_phys;
 
-       /* Create EVO channel */
-       ret = nv50_evo_channel_new(dev, &dev_priv->evo);
-       if (ret) {
-               NV_ERROR(dev, "Error creating EVO channel: %d\n", ret);
-               return ret;
-       }
-
        /* Create CRTC objects */
        for (i = 0; i < 2; i++)
                nv50_crtc_create(dev, i);
@@ -557,6 +330,9 @@ int nv50_display_create(struct drm_device *dev)
                }
        }
 
+       INIT_WORK(&dev_priv->irq_work, nv50_display_irq_handler_bh);
+       nouveau_irq_register(dev, 26, nv50_display_isr);
+
        ret = nv50_display_init(dev);
        if (ret) {
                nv50_display_destroy(dev);
@@ -569,14 +345,12 @@ int nv50_display_create(struct drm_device *dev)
 void
 nv50_display_destroy(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-
        NV_DEBUG_KMS(dev, "\n");
 
        drm_mode_config_cleanup(dev);
 
        nv50_display_disable(dev);
-       nv50_evo_channel_del(&dev_priv->evo);
+       nouveau_irq_unregister(dev, 26);
 }
 
 static u16
@@ -660,32 +434,32 @@ static void
 nv50_display_vblank_crtc_handler(struct drm_device *dev, int crtc)
 {
        struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_channel *chan;
-       struct list_head *entry, *tmp;
+       struct nouveau_channel *chan, *tmp;
 
-       list_for_each_safe(entry, tmp, &dev_priv->vbl_waiting) {
-               chan = list_entry(entry, struct nouveau_channel, nvsw.vbl_wait);
+       list_for_each_entry_safe(chan, tmp, &dev_priv->vbl_waiting,
+                                nvsw.vbl_wait) {
+               if (chan->nvsw.vblsem_head != crtc)
+                       continue;
 
                nouveau_bo_wr32(chan->notifier_bo, chan->nvsw.vblsem_offset,
                                                chan->nvsw.vblsem_rval);
                list_del(&chan->nvsw.vbl_wait);
+               drm_vblank_put(dev, crtc);
        }
+
+       drm_handle_vblank(dev, crtc);
 }
 
 static void
 nv50_display_vblank_handler(struct drm_device *dev, uint32_t intr)
 {
-       intr &= NV50_PDISPLAY_INTR_1_VBLANK_CRTC;
-
        if (intr & NV50_PDISPLAY_INTR_1_VBLANK_CRTC_0)
                nv50_display_vblank_crtc_handler(dev, 0);
 
        if (intr & NV50_PDISPLAY_INTR_1_VBLANK_CRTC_1)
                nv50_display_vblank_crtc_handler(dev, 1);
 
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN, nv_rd32(dev,
-                    NV50_PDISPLAY_INTR_EN) & ~intr);
-       nv_wr32(dev, NV50_PDISPLAY_INTR_1, intr);
+       nv_wr32(dev, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_VBLANK_CRTC);
 }
 
 static void
@@ -1011,108 +785,31 @@ nv50_display_irq_handler_bh(struct work_struct *work)
 static void
 nv50_display_error_handler(struct drm_device *dev)
 {
-       uint32_t addr, data;
-
-       nv_wr32(dev, NV50_PDISPLAY_INTR_0, 0x00010000);
-       addr = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_ADDR);
-       data = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_DATA);
-
-       NV_ERROR(dev, "EvoCh %d Mthd 0x%04x Data 0x%08x (0x%04x 0x%02x)\n",
-                0, addr & 0xffc, data, addr >> 16, (addr >> 12) & 0xf);
-
-       nv_wr32(dev, NV50_PDISPLAY_TRAPPED_ADDR, 0x90000000);
-}
-
-void
-nv50_display_irq_hotplug_bh(struct work_struct *work)
-{
-       struct drm_nouveau_private *dev_priv =
-               container_of(work, struct drm_nouveau_private, hpd_work);
-       struct drm_device *dev = dev_priv->dev;
-       struct drm_connector *connector;
-       const uint32_t gpio_reg[4] = { 0xe104, 0xe108, 0xe280, 0xe284 };
-       uint32_t unplug_mask, plug_mask, change_mask;
-       uint32_t hpd0, hpd1;
-
-       spin_lock_irq(&dev_priv->hpd_state.lock);
-       hpd0 = dev_priv->hpd_state.hpd0_bits;
-       dev_priv->hpd_state.hpd0_bits = 0;
-       hpd1 = dev_priv->hpd_state.hpd1_bits;
-       dev_priv->hpd_state.hpd1_bits = 0;
-       spin_unlock_irq(&dev_priv->hpd_state.lock);
-
-       hpd0 &= nv_rd32(dev, 0xe050);
-       if (dev_priv->chipset >= 0x90)
-               hpd1 &= nv_rd32(dev, 0xe070);
-
-       plug_mask   = (hpd0 & 0x0000ffff) | (hpd1 << 16);
-       unplug_mask = (hpd0 >> 16) | (hpd1 & 0xffff0000);
-       change_mask = plug_mask | unplug_mask;
-
-       list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
-               struct drm_encoder_helper_funcs *helper;
-               struct nouveau_connector *nv_connector =
-                       nouveau_connector(connector);
-               struct nouveau_encoder *nv_encoder;
-               struct dcb_gpio_entry *gpio;
-               uint32_t reg;
-               bool plugged;
-
-               if (!nv_connector->dcb)
-                       continue;
+       u32 channels = (nv_rd32(dev, NV50_PDISPLAY_INTR_0) & 0x001f0000) >> 16;
+       u32 addr, data;
+       int chid;
 
-               gpio = nouveau_bios_gpio_entry(dev, nv_connector->dcb->gpio_tag);
-               if (!gpio || !(change_mask & (1 << gpio->line)))
+       for (chid = 0; chid < 5; chid++) {
+               if (!(channels & (1 << chid)))
                        continue;
 
-               reg = nv_rd32(dev, gpio_reg[gpio->line >> 3]);
-               plugged = !!(reg & (4 << ((gpio->line & 7) << 2)));
-               NV_INFO(dev, "%splugged %s\n", plugged ? "" : "un",
-                       drm_get_connector_name(connector)) ;
-
-               if (!connector->encoder || !connector->encoder->crtc ||
-                   !connector->encoder->crtc->enabled)
-                       continue;
-               nv_encoder = nouveau_encoder(connector->encoder);
-               helper = connector->encoder->helper_private;
-
-               if (nv_encoder->dcb->type != OUTPUT_DP)
-                       continue;
+               nv_wr32(dev, NV50_PDISPLAY_INTR_0, 0x00010000 << chid);
+               addr = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_ADDR(chid));
+               data = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_DATA(chid));
+               NV_ERROR(dev, "EvoCh %d Mthd 0x%04x Data 0x%08x "
+                             "(0x%04x 0x%02x)\n", chid,
+                        addr & 0xffc, data, addr >> 16, (addr >> 12) & 0xf);
 
-               if (plugged)
-                       helper->dpms(connector->encoder, DRM_MODE_DPMS_ON);
-               else
-                       helper->dpms(connector->encoder, DRM_MODE_DPMS_OFF);
+               nv_wr32(dev, NV50_PDISPLAY_TRAPPED_ADDR(chid), 0x90000000);
        }
-
-       drm_helper_hpd_irq_event(dev);
 }
 
-void
-nv50_display_irq_handler(struct drm_device *dev)
+static void
+nv50_display_isr(struct drm_device *dev)
 {
        struct drm_nouveau_private *dev_priv = dev->dev_private;
        uint32_t delayed = 0;
 
-       if (nv_rd32(dev, NV50_PMC_INTR_0) & NV50_PMC_INTR_0_HOTPLUG) {
-               uint32_t hpd0_bits, hpd1_bits = 0;
-
-               hpd0_bits = nv_rd32(dev, 0xe054);
-               nv_wr32(dev, 0xe054, hpd0_bits);
-
-               if (dev_priv->chipset >= 0x90) {
-                       hpd1_bits = nv_rd32(dev, 0xe074);
-                       nv_wr32(dev, 0xe074, hpd1_bits);
-               }
-
-               spin_lock(&dev_priv->hpd_state.lock);
-               dev_priv->hpd_state.hpd0_bits |= hpd0_bits;
-               dev_priv->hpd_state.hpd1_bits |= hpd1_bits;
-               spin_unlock(&dev_priv->hpd_state.lock);
-
-               queue_work(dev_priv->wq, &dev_priv->hpd_work);
-       }
-
        while (nv_rd32(dev, NV50_PMC_INTR_0) & NV50_PMC_INTR_0_DISPLAY) {
                uint32_t intr0 = nv_rd32(dev, NV50_PDISPLAY_INTR_0);
                uint32_t intr1 = nv_rd32(dev, NV50_PDISPLAY_INTR_1);
@@ -1123,9 +820,9 @@ nv50_display_irq_handler(struct drm_device *dev)
                if (!intr0 && !(intr1 & ~delayed))
                        break;
 
-               if (intr0 & 0x00010000) {
+               if (intr0 & 0x001f0000) {
                        nv50_display_error_handler(dev);
-                       intr0 &= ~0x00010000;
+                       intr0 &= ~0x001f0000;
                }
 
                if (intr1 & NV50_PDISPLAY_INTR_1_VBLANK_CRTC) {
@@ -1156,4 +853,3 @@ nv50_display_irq_handler(struct drm_device *dev)
                }
        }
 }
-