]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/media/video/usbvision/usbvision-core.c
Merge tag 'v2.6.38' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6
[mv-sheeva.git] / drivers / media / video / usbvision / usbvision-core.c
index b9dd74fde212cc6d040fabe44f324da64863557b..c8feb0d6fccf5148770d71b52d120017e43ea7eb 100644 (file)
@@ -33,7 +33,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/spinlock.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/videodev2.h>
 #include <linux/i2c.h>
 
 #include "usbvision.h"
 
 static unsigned int core_debug;
-module_param(core_debug,int,0644);
-MODULE_PARM_DESC(core_debug,"enable debug messages [core]");
+module_param(core_debug, int, 0644);
+MODULE_PARM_DESC(core_debug, "enable debug messages [core]");
 
 static unsigned int force_testpattern;
-module_param(force_testpattern,int,0644);
-MODULE_PARM_DESC(force_testpattern,"enable test pattern display [core]");
+module_param(force_testpattern, int, 0644);
+MODULE_PARM_DESC(force_testpattern, "enable test pattern display [core]");
 
-static int adjustCompression = 1;      /* Set the compression to be adaptive */
-module_param(adjustCompression, int, 0444);
-MODULE_PARM_DESC(adjustCompression, " Set the ADPCM compression for the device.  Default: 1 (On)");
+static int adjust_compression = 1;     /* Set the compression to be adaptive */
+module_param(adjust_compression, int, 0444);
+MODULE_PARM_DESC(adjust_compression, " Set the ADPCM compression for the device.  Default: 1 (On)");
 
 /* To help people with Black and White output with using s-video input.
  * Some cables and input device are wired differently. */
-static int SwitchSVideoInput;
-module_param(SwitchSVideoInput, int, 0444);
-MODULE_PARM_DESC(SwitchSVideoInput, " Set the S-Video input.  Some cables and input device are wired differently. Default: 0 (Off)");
+static int switch_svideo_input;
+module_param(switch_svideo_input, int, 0444);
+MODULE_PARM_DESC(switch_svideo_input, " Set the S-Video input.  Some cables and input device are wired differently. Default: 0 (Off)");
 
-static unsigned int adjust_X_Offset = -1;
-module_param(adjust_X_Offset, int, 0644);
-MODULE_PARM_DESC(adjust_X_Offset, "adjust X offset display [core]");
+static unsigned int adjust_x_offset = -1;
+module_param(adjust_x_offset, int, 0644);
+MODULE_PARM_DESC(adjust_x_offset, "adjust X offset display [core]");
 
-static unsigned int adjust_Y_Offset = -1;
-module_param(adjust_Y_Offset, int, 0644);
-MODULE_PARM_DESC(adjust_Y_Offset, "adjust Y offset display [core]");
+static unsigned int adjust_y_offset = -1;
+module_param(adjust_y_offset, int, 0644);
+MODULE_PARM_DESC(adjust_y_offset, "adjust Y offset display [core]");
 
 
 #define        ENABLE_HEXDUMP  0       /* Enable if you need it */
@@ -82,15 +82,15 @@ MODULE_PARM_DESC(adjust_Y_Offset, "adjust Y offset display [core]");
                                __func__, __LINE__ , ## args); \
        }
 #else
-       #define PDEBUG(level, fmt, args...) do {} while(0)
+       #define PDEBUG(level, fmt, args...) do {} while (0)
 #endif
 
-#define DBG_HEADER     1<<0
-#define DBG_IRQ                1<<1
-#define DBG_ISOC       1<<2
-#define DBG_PARSE      1<<3
-#define DBG_SCRATCH    1<<4
-#define DBG_FUNC       1<<5
+#define DBG_HEADER     (1 << 0)
+#define DBG_IRQ                (1 << 1)
+#define DBG_ISOC       (1 << 2)
+#define DBG_PARSE      (1 << 3)
+#define DBG_SCRATCH    (1 << 4)
+#define DBG_FUNC       (1 << 5)
 
 static const int max_imgwidth = MAX_FRAME_WIDTH;
 static const int max_imgheight = MAX_FRAME_HEIGHT;
@@ -103,14 +103,14 @@ static const int min_imgheight = MIN_FRAME_HEIGHT;
  * to work with. This setting can be adjusted, but the default value
  * should be OK for most desktop users.
  */
-#define DEFAULT_SCRATCH_BUF_SIZE       (0x20000)               // 128kB memory scratch buffer
+#define DEFAULT_SCRATCH_BUF_SIZE       (0x20000)               /* 128kB memory scratch buffer */
 static const int scratch_buf_size = DEFAULT_SCRATCH_BUF_SIZE;
 
-// Function prototypes
-static int usbvision_request_intra (struct usb_usbvision *usbvision);
-static int usbvision_unrequest_intra (struct usb_usbvision *usbvision);
-static int usbvision_adjust_compression (struct usb_usbvision *usbvision);
-static int usbvision_measure_bandwidth (struct usb_usbvision *usbvision);
+/* Function prototypes */
+static int usbvision_request_intra(struct usb_usbvision *usbvision);
+static int usbvision_unrequest_intra(struct usb_usbvision *usbvision);
+static int usbvision_adjust_compression(struct usb_usbvision *usbvision);
+static int usbvision_measure_bandwidth(struct usb_usbvision *usbvision);
 
 /*******************************/
 /* Memory management functions */
@@ -176,19 +176,19 @@ static void usbvision_hexdump(const unsigned char *data, int len)
                k += sprintf(&tmp[k], "%02x ", data[i]);
        }
        if (k > 0)
-               printk("%s\n", tmp);
+               printk(KERN_CONT "%s\n", tmp);
 }
 #endif
 
 /********************************
  * scratch ring buffer handling
  ********************************/
-static int scratch_len(struct usb_usbvision *usbvision)    /*This returns the amount of data actually in the buffer */
+static int scratch_len(struct usb_usbvision *usbvision)    /* This returns the amount of data actually in the buffer */
 {
        int len = usbvision->scratch_write_ptr - usbvision->scratch_read_ptr;
-       if (len < 0) {
+
+       if (len < 0)
                len += scratch_buf_size;
-       }
        PDEBUG(DBG_SCRATCH, "scratch_len() = %d\n", len);
 
        return len;
@@ -199,9 +199,8 @@ static int scratch_len(struct usb_usbvision *usbvision)    /*This returns the am
 static int scratch_free(struct usb_usbvision *usbvision)
 {
        int free = usbvision->scratch_read_ptr - usbvision->scratch_write_ptr;
-       if (free <= 0) {
+       if (free <= 0)
                free += scratch_buf_size;
-       }
        if (free) {
                free -= 1;                                                      /* at least one byte in the buffer must */
                                                                                /* left blank, otherwise there is no chance to differ between full and empty */
@@ -221,14 +220,12 @@ static int scratch_put(struct usb_usbvision *usbvision, unsigned char *data,
        if (usbvision->scratch_write_ptr + len < scratch_buf_size) {
                memcpy(usbvision->scratch + usbvision->scratch_write_ptr, data, len);
                usbvision->scratch_write_ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - usbvision->scratch_write_ptr;
                memcpy(usbvision->scratch + usbvision->scratch_write_ptr, data, len_part);
                if (len == len_part) {
                        usbvision->scratch_write_ptr = 0;                       /* just set write_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(usbvision->scratch, data + len_part, len - len_part);
                        usbvision->scratch_write_ptr = len - len_part;
                }
@@ -255,17 +252,16 @@ static int scratch_get_extra(struct usb_usbvision *usbvision,
                             unsigned char *data, int *ptr, int len)
 {
        int len_part;
+
        if (*ptr + len < scratch_buf_size) {
                memcpy(data, usbvision->scratch + *ptr, len);
                *ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - *ptr;
                memcpy(data, usbvision->scratch + *ptr, len_part);
                if (len == len_part) {
                        *ptr = 0;                                                       /* just set the y_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(data + len_part, usbvision->scratch, len - len_part);
                        *ptr = len - len_part;
                }
@@ -281,13 +277,13 @@ static int scratch_get_extra(struct usb_usbvision *usbvision,
 static void scratch_set_extra_ptr(struct usb_usbvision *usbvision, int *ptr,
                                  int len)
 {
-       *ptr = (usbvision->scratch_read_ptr + len)%scratch_buf_size;
+       *ptr = (usbvision->scratch_read_ptr + len) % scratch_buf_size;
 
        PDEBUG(DBG_SCRATCH, "ptr=%d\n", *ptr);
 }
 
 
-/*This increments the scratch extra read pointer */
+/* This increments the scratch extra read pointer */
 static void scratch_inc_extra_ptr(int *ptr, int len)
 {
        *ptr = (*ptr + len) % scratch_buf_size;
@@ -301,17 +297,16 @@ static int scratch_get(struct usb_usbvision *usbvision, unsigned char *data,
                       int len)
 {
        int len_part;
+
        if (usbvision->scratch_read_ptr + len < scratch_buf_size) {
                memcpy(data, usbvision->scratch + usbvision->scratch_read_ptr, len);
                usbvision->scratch_read_ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - usbvision->scratch_read_ptr;
                memcpy(data, usbvision->scratch + usbvision->scratch_read_ptr, len_part);
                if (len == len_part) {
                        usbvision->scratch_read_ptr = 0;                                /* just set the read_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(data + len_part, usbvision->scratch, len - len_part);
                        usbvision->scratch_read_ptr = len - len_part;
                }
@@ -327,7 +322,7 @@ static int scratch_get(struct usb_usbvision *usbvision, unsigned char *data,
 static int scratch_get_header(struct usb_usbvision *usbvision,
                              struct usbvision_frame_header *header)
 {
-       int errCode = 0;
+       int err_code = 0;
 
        PDEBUG(DBG_SCRATCH, "from read_ptr=%d", usbvision->scratch_headermarker_read_ptr);
 
@@ -340,29 +335,28 @@ static int scratch_get_header(struct usb_usbvision *usbvision,
                scratch_get(usbvision, (unsigned char *)header, USBVISION_HEADER_LENGTH);
                if ((header->magic_1 == USBVISION_MAGIC_1)
                         && (header->magic_2 == USBVISION_MAGIC_2)
-                        && (header->headerLength == USBVISION_HEADER_LENGTH)) {
-                       errCode = USBVISION_HEADER_LENGTH;
-                       header->frameWidth  = header->frameWidthLo  + (header->frameWidthHi << 8);
-                       header->frameHeight = header->frameHeightLo + (header->frameHeightHi << 8);
+                        && (header->header_length == USBVISION_HEADER_LENGTH)) {
+                       err_code = USBVISION_HEADER_LENGTH;
+                       header->frame_width  = header->frame_width_lo  + (header->frame_width_hi << 8);
+                       header->frame_height = header->frame_height_lo + (header->frame_height_hi << 8);
                        break;
                }
        }
 
-       return errCode;
+       return err_code;
 }
 
 
-/*This removes len bytes of old data from the buffer */
+/* This removes len bytes of old data from the buffer */
 static void scratch_rm_old(struct usb_usbvision *usbvision, int len)
 {
-
        usbvision->scratch_read_ptr += len;
        usbvision->scratch_read_ptr %= scratch_buf_size;
        PDEBUG(DBG_SCRATCH, "read_ptr is now %d\n", usbvision->scratch_read_ptr);
 }
 
 
-/*This resets the buffer - kills all data in it too */
+/* This resets the buffer - kills all data in it too */
 static void scratch_reset(struct usb_usbvision *usbvision)
 {
        PDEBUG(DBG_SCRATCH, "\n");
@@ -371,14 +365,14 @@ static void scratch_reset(struct usb_usbvision *usbvision)
        usbvision->scratch_write_ptr = 0;
        usbvision->scratch_headermarker_read_ptr = 0;
        usbvision->scratch_headermarker_write_ptr = 0;
-       usbvision->isocstate = IsocState_NoFrame;
+       usbvision->isocstate = isoc_state_no_frame;
 }
 
 int usbvision_scratch_alloc(struct usb_usbvision *usbvision)
 {
        usbvision->scratch = vmalloc_32(scratch_buf_size);
        scratch_reset(usbvision);
-       if(usbvision->scratch == NULL) {
+       if (usbvision->scratch == NULL) {
                dev_err(&usbvision->dev->dev,
                        "%s: unable to allocate %d bytes for scratch\n",
                                __func__, scratch_buf_size);
@@ -391,7 +385,6 @@ void usbvision_scratch_free(struct usb_usbvision *usbvision)
 {
        vfree(usbvision->scratch);
        usbvision->scratch = NULL;
-
 }
 
 /*
@@ -420,13 +413,13 @@ static void usbvision_testpattern(struct usb_usbvision *usbvision,
                printk(KERN_ERR "%s: usbvision == NULL\n", proc);
                return;
        }
-       if (usbvision->curFrame == NULL) {
-               printk(KERN_ERR "%s: usbvision->curFrame is NULL.\n", proc);
+       if (usbvision->cur_frame == NULL) {
+               printk(KERN_ERR "%s: usbvision->cur_frame is NULL.\n", proc);
                return;
        }
 
        /* Grab the current frame */
-       frame = usbvision->curFrame;
+       frame = usbvision->cur_frame;
 
        /* Optionally start at the beginning */
        if (fullframe) {
@@ -473,10 +466,9 @@ static void usbvision_testpattern(struct usb_usbvision *usbvision,
                }
        }
 
-       frame->grabstate = FrameState_Done;
+       frame->grabstate = frame_state_done;
        frame->scanlength += scan_length;
        ++num_pass;
-
 }
 
 /*
@@ -487,8 +479,9 @@ static void usbvision_testpattern(struct usb_usbvision *usbvision,
 int usbvision_decompress_alloc(struct usb_usbvision *usbvision)
 {
        int IFB_size = MAX_FRAME_WIDTH * MAX_FRAME_HEIGHT * 3 / 2;
-       usbvision->IntraFrameBuffer = vmalloc_32(IFB_size);
-       if (usbvision->IntraFrameBuffer == NULL) {
+
+       usbvision->intra_frame_buffer = vmalloc_32(IFB_size);
+       if (usbvision->intra_frame_buffer == NULL) {
                dev_err(&usbvision->dev->dev,
                        "%s: unable to allocate %d for compr. frame buffer\n",
                                __func__, IFB_size);
@@ -504,8 +497,8 @@ int usbvision_decompress_alloc(struct usb_usbvision *usbvision)
  */
 void usbvision_decompress_free(struct usb_usbvision *usbvision)
 {
-       vfree(usbvision->IntraFrameBuffer);
-       usbvision->IntraFrameBuffer = NULL;
+       vfree(usbvision->intra_frame_buffer);
+       usbvision->intra_frame_buffer = NULL;
 
 }
 
@@ -517,117 +510,111 @@ void usbvision_decompress_free(struct usb_usbvision *usbvision)
  *
  * Locate one of supported header markers in the scratch buffer.
  */
-static enum ParseState usbvision_find_header(struct usb_usbvision *usbvision)
+static enum parse_state usbvision_find_header(struct usb_usbvision *usbvision)
 {
        struct usbvision_frame *frame;
-       int foundHeader = 0;
+       int found_header = 0;
 
-       frame = usbvision->curFrame;
+       frame = usbvision->cur_frame;
 
-       while (scratch_get_header(usbvision, &frame->isocHeader) == USBVISION_HEADER_LENGTH) {
-               // found header in scratch
+       while (scratch_get_header(usbvision, &frame->isoc_header) == USBVISION_HEADER_LENGTH) {
+               /* found header in scratch */
                PDEBUG(DBG_HEADER, "found header: 0x%02x%02x %d %d %d %d %#x 0x%02x %u %u",
-                               frame->isocHeader.magic_2,
-                               frame->isocHeader.magic_1,
-                               frame->isocHeader.headerLength,
-                               frame->isocHeader.frameNum,
-                               frame->isocHeader.framePhase,
-                               frame->isocHeader.frameLatency,
-                               frame->isocHeader.dataFormat,
-                               frame->isocHeader.formatParam,
-                               frame->isocHeader.frameWidth,
-                               frame->isocHeader.frameHeight);
-
-               if (usbvision->requestIntra) {
-                       if (frame->isocHeader.formatParam & 0x80) {
-                               foundHeader = 1;
-                               usbvision->lastIsocFrameNum = -1; // do not check for lost frames this time
+                               frame->isoc_header.magic_2,
+                               frame->isoc_header.magic_1,
+                               frame->isoc_header.header_length,
+                               frame->isoc_header.frame_num,
+                               frame->isoc_header.frame_phase,
+                               frame->isoc_header.frame_latency,
+                               frame->isoc_header.data_format,
+                               frame->isoc_header.format_param,
+                               frame->isoc_header.frame_width,
+                               frame->isoc_header.frame_height);
+
+               if (usbvision->request_intra) {
+                       if (frame->isoc_header.format_param & 0x80) {
+                               found_header = 1;
+                               usbvision->last_isoc_frame_num = -1; /* do not check for lost frames this time */
                                usbvision_unrequest_intra(usbvision);
                                break;
                        }
-               }
-               else {
-                       foundHeader = 1;
+               } else {
+                       found_header = 1;
                        break;
                }
        }
 
-       if (foundHeader) {
-               frame->frmwidth = frame->isocHeader.frameWidth * usbvision->stretch_width;
-               frame->frmheight = frame->isocHeader.frameHeight * usbvision->stretch_height;
-               frame->v4l2_linesize = (frame->frmwidth * frame->v4l2_format.depth)>> 3;
-       }
-       else { // no header found
+       if (found_header) {
+               frame->frmwidth = frame->isoc_header.frame_width * usbvision->stretch_width;
+               frame->frmheight = frame->isoc_header.frame_height * usbvision->stretch_height;
+               frame->v4l2_linesize = (frame->frmwidth * frame->v4l2_format.depth) >> 3;
+       } else { /* no header found */
                PDEBUG(DBG_HEADER, "skipping scratch data, no header");
                scratch_reset(usbvision);
-               return ParseState_EndParse;
+               return parse_state_end_parse;
        }
 
-       // found header
-       if (frame->isocHeader.dataFormat==ISOC_MODE_COMPRESS) {
-               //check isocHeader.frameNum for lost frames
-               if (usbvision->lastIsocFrameNum >= 0) {
-                       if (((usbvision->lastIsocFrameNum + 1) % 32) != frame->isocHeader.frameNum) {
-                               // unexpected frame drop: need to request new intra frame
-                               PDEBUG(DBG_HEADER, "Lost frame before %d on USB", frame->isocHeader.frameNum);
+       /* found header */
+       if (frame->isoc_header.data_format == ISOC_MODE_COMPRESS) {
+               /* check isoc_header.frame_num for lost frames */
+               if (usbvision->last_isoc_frame_num >= 0) {
+                       if (((usbvision->last_isoc_frame_num + 1) % 32) != frame->isoc_header.frame_num) {
+                               /* unexpected frame drop: need to request new intra frame */
+                               PDEBUG(DBG_HEADER, "Lost frame before %d on USB", frame->isoc_header.frame_num);
                                usbvision_request_intra(usbvision);
-                               return ParseState_NextFrame;
+                               return parse_state_next_frame;
                        }
                }
-               usbvision->lastIsocFrameNum = frame->isocHeader.frameNum;
+               usbvision->last_isoc_frame_num = frame->isoc_header.frame_num;
        }
        usbvision->header_count++;
-       frame->scanstate = ScanState_Lines;
+       frame->scanstate = scan_state_lines;
        frame->curline = 0;
 
        if (force_testpattern) {
                usbvision_testpattern(usbvision, 1, 1);
-               return ParseState_NextFrame;
+               return parse_state_next_frame;
        }
-       return ParseState_Continue;
+       return parse_state_continue;
 }
 
-static enum ParseState usbvision_parse_lines_422(struct usb_usbvision *usbvision,
+static enum parse_state usbvision_parse_lines_422(struct usb_usbvision *usbvision,
                                           long *pcopylen)
 {
        volatile struct usbvision_frame *frame;
        unsigned char *f;
        int len;
        int i;
-       unsigned char yuyv[4]={180, 128, 10, 128}; // YUV components
-       unsigned char rv, gv, bv;       // RGB components
+       unsigned char yuyv[4] = { 180, 128, 10, 128 }; /* YUV components */
+       unsigned char rv, gv, bv;       /* RGB components */
        int clipmask_index, bytes_per_pixel;
        int stretch_bytes, clipmask_add;
 
-       frame  = usbvision->curFrame;
+       frame  = usbvision->cur_frame;
        f = frame->data + (frame->v4l2_linesize * frame->curline);
 
        /* Make sure there's enough data for the entire line */
-       len = (frame->isocHeader.frameWidth * 2)+5;
+       len = (frame->isoc_header.frame_width * 2) + 5;
        if (scratch_len(usbvision) < len) {
                PDEBUG(DBG_PARSE, "out of data in line %d, need %u.\n", frame->curline, len);
-               return ParseState_Out;
+               return parse_state_out;
        }
 
-       if ((frame->curline + 1) >= frame->frmheight) {
-               return ParseState_NextFrame;
-       }
+       if ((frame->curline + 1) >= frame->frmheight)
+               return parse_state_next_frame;
 
        bytes_per_pixel = frame->v4l2_format.bytes_per_pixel;
        stretch_bytes = (usbvision->stretch_width - 1) * bytes_per_pixel;
        clipmask_index = frame->curline * MAX_FRAME_WIDTH;
        clipmask_add = usbvision->stretch_width;
 
-       for (i = 0; i < frame->frmwidth; i+=(2 * usbvision->stretch_width)) {
-
+       for (i = 0; i < frame->frmwidth; i += (2 * usbvision->stretch_width)) {
                scratch_get(usbvision, &yuyv[0], 4);
 
                if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
-                       *f++ = yuyv[0]; // Y
-                       *f++ = yuyv[3]; // U
-               }
-               else {
-
+                       *f++ = yuyv[0]; /* Y */
+                       *f++ = yuyv[3]; /* U */
+               } else {
                        YUV_TO_RGB_BY_THE_BOOK(yuyv[0], yuyv[1], yuyv[3], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
                        case V4L2_PIX_FMT_RGB565:
@@ -659,11 +646,9 @@ static enum ParseState usbvision_parse_lines_422(struct usb_usbvision *usbvision
                f += stretch_bytes;
 
                if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
-                       *f++ = yuyv[2]; // Y
-                       *f++ = yuyv[1]; // V
-               }
-               else {
-
+                       *f++ = yuyv[2]; /* Y */
+                       *f++ = yuyv[1]; /* V */
+               } else {
                        YUV_TO_RGB_BY_THE_BOOK(yuyv[2], yuyv[1], yuyv[3], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
                        case V4L2_PIX_FMT_RGB565:
@@ -698,100 +683,94 @@ static enum ParseState usbvision_parse_lines_422(struct usb_usbvision *usbvision
        frame->curline += usbvision->stretch_height;
        *pcopylen += frame->v4l2_linesize * usbvision->stretch_height;
 
-       if (frame->curline >= frame->frmheight) {
-               return ParseState_NextFrame;
-       }
-       else {
-               return ParseState_Continue;
-       }
+       if (frame->curline >= frame->frmheight)
+               return parse_state_next_frame;
+       return parse_state_continue;
 }
 
 /* The decompression routine  */
-static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *Compressed,
-                                                               unsigned char *Decompressed, int *StartPos,
-                                                               int *BlockTypeStartPos, int Len)
+static int usbvision_decompress(struct usb_usbvision *usbvision, unsigned char *compressed,
+                                                               unsigned char *decompressed, int *start_pos,
+                                                               int *block_typestart_pos, int len)
 {
-       int RestPixel, Idx, MaxPos, Pos, ExtraPos, BlockLen, BlockTypePos, BlockTypeLen;
-       unsigned char BlockByte, BlockCode, BlockType, BlockTypeByte, Integrator;
-
-       Integrator = 0;
-       Pos = *StartPos;
-       BlockTypePos = *BlockTypeStartPos;
-       MaxPos = 396; //Pos + Len;
-       ExtraPos = Pos;
-       BlockLen = 0;
-       BlockByte = 0;
-       BlockCode = 0;
-       BlockType = 0;
-       BlockTypeByte = 0;
-       BlockTypeLen = 0;
-       RestPixel = Len;
-
-       for (Idx = 0; Idx < Len; Idx++) {
-
-               if (BlockLen == 0) {
-                       if (BlockTypeLen==0) {
-                               BlockTypeByte = Compressed[BlockTypePos];
-                               BlockTypePos++;
-                               BlockTypeLen = 4;
+       int rest_pixel, idx, max_pos, pos, extra_pos, block_len, block_type_pos, block_type_len;
+       unsigned char block_byte, block_code, block_type, block_type_byte, integrator;
+
+       integrator = 0;
+       pos = *start_pos;
+       block_type_pos = *block_typestart_pos;
+       max_pos = 396; /* pos + len; */
+       extra_pos = pos;
+       block_len = 0;
+       block_byte = 0;
+       block_code = 0;
+       block_type = 0;
+       block_type_byte = 0;
+       block_type_len = 0;
+       rest_pixel = len;
+
+       for (idx = 0; idx < len; idx++) {
+               if (block_len == 0) {
+                       if (block_type_len == 0) {
+                               block_type_byte = compressed[block_type_pos];
+                               block_type_pos++;
+                               block_type_len = 4;
                        }
-                       BlockType = (BlockTypeByte & 0xC0) >> 6;
+                       block_type = (block_type_byte & 0xC0) >> 6;
 
-                       //statistic:
-                       usbvision->ComprBlockTypes[BlockType]++;
+                       /* statistic: */
+                       usbvision->compr_block_types[block_type]++;
 
-                       Pos = ExtraPos;
-                       if (BlockType == 0) {
-                               if(RestPixel >= 24) {
-                                       Idx += 23;
-                                       RestPixel -= 24;
-                                       Integrator = Decompressed[Idx];
+                       pos = extra_pos;
+                       if (block_type == 0) {
+                               if (rest_pixel >= 24) {
+                                       idx += 23;
+                                       rest_pixel -= 24;
+                                       integrator = decompressed[idx];
                                } else {
-                                       Idx += RestPixel - 1;
-                                       RestPixel = 0;
+                                       idx += rest_pixel - 1;
+                                       rest_pixel = 0;
                                }
                        } else {
-                               BlockCode = Compressed[Pos];
-                               Pos++;
-                               if (RestPixel >= 24) {
-                                       BlockLen  = 24;
-                               } else {
-                                       BlockLen = RestPixel;
-                               }
-                               RestPixel -= BlockLen;
-                               ExtraPos = Pos + (BlockLen / 4);
+                               block_code = compressed[pos];
+                               pos++;
+                               if (rest_pixel >= 24)
+                                       block_len  = 24;
+                               else
+                                       block_len = rest_pixel;
+                               rest_pixel -= block_len;
+                               extra_pos = pos + (block_len / 4);
                        }
-                       BlockTypeByte <<= 2;
-                       BlockTypeLen -= 1;
+                       block_type_byte <<= 2;
+                       block_type_len -= 1;
                }
-               if (BlockLen > 0) {
-                       if ((BlockLen%4) == 0) {
-                               BlockByte = Compressed[Pos];
-                               Pos++;
+               if (block_len > 0) {
+                       if ((block_len % 4) == 0) {
+                               block_byte = compressed[pos];
+                               pos++;
                        }
-                       if (BlockType == 1) { //inter Block
-                               Integrator = Decompressed[Idx];
-                       }
-                       switch (BlockByte & 0xC0) {
-                               case 0x03<<6:
-                                       Integrator += Compressed[ExtraPos];
-                                       ExtraPos++;
-                                       break;
-                               case 0x02<<6:
-                                       Integrator += BlockCode;
-                                       break;
-                               case 0x00:
-                                       Integrator -= BlockCode;
-                                       break;
+                       if (block_type == 1) /* inter Block */
+                               integrator = decompressed[idx];
+                       switch (block_byte & 0xC0) {
+                       case 0x03 << 6:
+                               integrator += compressed[extra_pos];
+                               extra_pos++;
+                               break;
+                       case 0x02 << 6:
+                               integrator += block_code;
+                               break;
+                       case 0x00:
+                               integrator -= block_code;
+                               break;
                        }
-                       Decompressed[Idx] = Integrator;
-                       BlockByte <<= 2;
-                       BlockLen -= 1;
+                       decompressed[idx] = integrator;
+                       block_byte <<= 2;
+                       block_len -= 1;
                }
        }
-       *StartPos = ExtraPos;
-       *BlockTypeStartPos = BlockTypePos;
-       return Idx;
+       *start_pos = extra_pos;
+       *block_typestart_pos = block_type_pos;
+       return idx;
 }
 
 
@@ -803,7 +782,7 @@ static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *C
  * number of bytes (RGB) to the *pcopylen.
  *
  */
-static enum ParseState usbvision_parse_compress(struct usb_usbvision *usbvision,
+static enum parse_state usbvision_parse_compress(struct usb_usbvision *usbvision,
                                           long *pcopylen)
 {
 #define USBVISION_STRIP_MAGIC          0x5A
@@ -811,191 +790,165 @@ static enum ParseState usbvision_parse_compress(struct usb_usbvision *usbvision,
 #define USBVISION_STRIP_HEADER_LEN     3
 
        struct usbvision_frame *frame;
-       unsigned char *f,*u = NULL ,*v = NULL;
-       unsigned char StripData[USBVISION_STRIP_LEN_MAX];
-       unsigned char StripHeader[USBVISION_STRIP_HEADER_LEN];
-       int Idx, IdxEnd, StripLen, StripPtr, StartBlockPos, BlockPos, BlockTypePos;
+       unsigned char *f, *u = NULL, *v = NULL;
+       unsigned char strip_data[USBVISION_STRIP_LEN_MAX];
+       unsigned char strip_header[USBVISION_STRIP_HEADER_LEN];
+       int idx, idx_end, strip_len, strip_ptr, startblock_pos, block_pos, block_type_pos;
        int clipmask_index, bytes_per_pixel, rc;
-       int imageSize;
+       int image_size;
        unsigned char rv, gv, bv;
        static unsigned char *Y, *U, *V;
 
-       frame  = usbvision->curFrame;
-       imageSize = frame->frmwidth * frame->frmheight;
-       if ( (frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) ||
-            (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) ) {       // this is a planar format
-               //... v4l2_linesize not used here.
+       frame = usbvision->cur_frame;
+       image_size = frame->frmwidth * frame->frmheight;
+       if ((frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) ||
+           (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420)) {       /* this is a planar format */
+               /* ... v4l2_linesize not used here. */
                f = frame->data + (frame->width * frame->curline);
        } else
                f = frame->data + (frame->v4l2_linesize * frame->curline);
 
-       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV){ //initialise u and v pointers
-               // get base of u and b planes add halfoffset
-
+       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) { /* initialise u and v pointers */
+               /* get base of u and b planes add halfoffset */
                u = frame->data
-                       + imageSize
-                       + (frame->frmwidth >>1) * frame->curline ;
-               v = u + (imageSize >>1 );
-
-       } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420){
-
-               v = frame->data + imageSize + ((frame->curline* (frame->width))>>2) ;
-               u = v + (imageSize >>2) ;
+                       + image_size
+                       + (frame->frmwidth >> 1) * frame->curline;
+               v = u + (image_size >> 1);
+       } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
+               v = frame->data + image_size + ((frame->curline * (frame->width)) >> 2);
+               u = v + (image_size >> 2);
        }
 
-       if (frame->curline == 0) {
+       if (frame->curline == 0)
                usbvision_adjust_compression(usbvision);
-       }
 
-       if (scratch_len(usbvision) < USBVISION_STRIP_HEADER_LEN) {
-               return ParseState_Out;
-       }
+       if (scratch_len(usbvision) < USBVISION_STRIP_HEADER_LEN)
+               return parse_state_out;
 
-       //get strip header without changing the scratch_read_ptr
-       scratch_set_extra_ptr(usbvision, &StripPtr, 0);
-       scratch_get_extra(usbvision, &StripHeader[0], &StripPtr,
+       /* get strip header without changing the scratch_read_ptr */
+       scratch_set_extra_ptr(usbvision, &strip_ptr, 0);
+       scratch_get_extra(usbvision, &strip_header[0], &strip_ptr,
                                USBVISION_STRIP_HEADER_LEN);
 
-       if (StripHeader[0] != USBVISION_STRIP_MAGIC) {
-               // wrong strip magic
-               usbvision->stripMagicErrors++;
-               return ParseState_NextFrame;
+       if (strip_header[0] != USBVISION_STRIP_MAGIC) {
+               /* wrong strip magic */
+               usbvision->strip_magic_errors++;
+               return parse_state_next_frame;
        }
 
-       if (frame->curline != (int)StripHeader[2]) {
-               //line number missmatch error
-               usbvision->stripLineNumberErrors++;
+       if (frame->curline != (int)strip_header[2]) {
+               /* line number mismatch error */
+               usbvision->strip_line_number_errors++;
        }
 
-       StripLen = 2 * (unsigned int)StripHeader[1];
-       if (StripLen > USBVISION_STRIP_LEN_MAX) {
-               // strip overrun
-               // I think this never happens
+       strip_len = 2 * (unsigned int)strip_header[1];
+       if (strip_len > USBVISION_STRIP_LEN_MAX) {
+               /* strip overrun */
+               /* I think this never happens */
                usbvision_request_intra(usbvision);
        }
 
-       if (scratch_len(usbvision) < StripLen) {
-               //there is not enough data for the strip
-               return ParseState_Out;
+       if (scratch_len(usbvision) < strip_len) {
+               /* there is not enough data for the strip */
+               return parse_state_out;
        }
 
-       if (usbvision->IntraFrameBuffer) {
-               Y = usbvision->IntraFrameBuffer + frame->frmwidth * frame->curline;
-               U = usbvision->IntraFrameBuffer + imageSize + (frame->frmwidth / 2) * (frame->curline / 2);
-               V = usbvision->IntraFrameBuffer + imageSize / 4 * 5 + (frame->frmwidth / 2) * (frame->curline / 2);
-       }
-       else {
-               return ParseState_NextFrame;
+       if (usbvision->intra_frame_buffer) {
+               Y = usbvision->intra_frame_buffer + frame->frmwidth * frame->curline;
+               U = usbvision->intra_frame_buffer + image_size + (frame->frmwidth / 2) * (frame->curline / 2);
+               V = usbvision->intra_frame_buffer + image_size / 4 * 5 + (frame->frmwidth / 2) * (frame->curline / 2);
+       } else {
+               return parse_state_next_frame;
        }
 
        bytes_per_pixel = frame->v4l2_format.bytes_per_pixel;
        clipmask_index = frame->curline * MAX_FRAME_WIDTH;
 
-       scratch_get(usbvision, StripData, StripLen);
+       scratch_get(usbvision, strip_data, strip_len);
 
-       IdxEnd = frame->frmwidth;
-       BlockTypePos = USBVISION_STRIP_HEADER_LEN;
-       StartBlockPos = BlockTypePos + (IdxEnd - 1) / 96 + (IdxEnd / 2 - 1) / 96 + 2;
-       BlockPos = StartBlockPos;
+       idx_end = frame->frmwidth;
+       block_type_pos = USBVISION_STRIP_HEADER_LEN;
+       startblock_pos = block_type_pos + (idx_end - 1) / 96 + (idx_end / 2 - 1) / 96 + 2;
+       block_pos = startblock_pos;
 
-       usbvision->BlockPos = BlockPos;
+       usbvision->block_pos = block_pos;
 
-       if ((rc = usbvision_decompress(usbvision, StripData, Y, &BlockPos, &BlockTypePos, IdxEnd)) != IdxEnd) {
-               //return ParseState_Continue;
-       }
-       if (StripLen > usbvision->maxStripLen) {
-               usbvision->maxStripLen = StripLen;
-       }
+       rc = usbvision_decompress(usbvision, strip_data, Y, &block_pos, &block_type_pos, idx_end);
+       if (strip_len > usbvision->max_strip_len)
+               usbvision->max_strip_len = strip_len;
 
-       if (frame->curline%2) {
-               if ((rc = usbvision_decompress(usbvision, StripData, V, &BlockPos, &BlockTypePos, IdxEnd/2)) != IdxEnd/2) {
-               //return ParseState_Continue;
-               }
-       }
-       else {
-               if ((rc = usbvision_decompress(usbvision, StripData, U, &BlockPos, &BlockTypePos, IdxEnd/2)) != IdxEnd/2) {
-                       //return ParseState_Continue;
-               }
-       }
+       if (frame->curline % 2)
+               rc = usbvision_decompress(usbvision, strip_data, V, &block_pos, &block_type_pos, idx_end / 2);
+       else
+               rc = usbvision_decompress(usbvision, strip_data, U, &block_pos, &block_type_pos, idx_end / 2);
 
-       if (BlockPos > usbvision->comprBlockPos) {
-               usbvision->comprBlockPos = BlockPos;
-       }
-       if (BlockPos > StripLen) {
-               usbvision->stripLenErrors++;
-       }
+       if (block_pos > usbvision->comprblock_pos)
+               usbvision->comprblock_pos = block_pos;
+       if (block_pos > strip_len)
+               usbvision->strip_len_errors++;
 
-       for (Idx = 0; Idx < IdxEnd; Idx++) {
-               if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
-                       *f++ = Y[Idx];
-                       *f++ = Idx & 0x01 ? U[Idx/2] : V[Idx/2];
-               }
-               else if(frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) {
-                       *f++ = Y[Idx];
-                       if ( Idx & 0x01)
-                               *u++ = U[Idx>>1] ;
+       for (idx = 0; idx < idx_end; idx++) {
+               if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       *f++ = Y[idx];
+                       *f++ = idx & 0x01 ? U[idx / 2] : V[idx / 2];
+               } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) {
+                       *f++ = Y[idx];
+                       if (idx & 0x01)
+                               *u++ = U[idx >> 1];
                        else
-                               *v++ = V[Idx>>1];
-               }
-               else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
-                       *f++ = Y [Idx];
-                       if ( !((  Idx & 0x01  ) | (  frame->curline & 0x01  )) ){
-
-/*                              only need do this for 1 in 4 pixels */
-/*                              intraframe buffer is YUV420 format */
-
-                               *u++ = U[Idx >>1];
-                               *v++ = V[Idx >>1];
+                               *v++ = V[idx >> 1];
+               } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
+                       *f++ = Y[idx];
+                       if (!((idx & 0x01) | (frame->curline & 0x01))) {
+                               /* only need do this for 1 in 4 pixels */
+                               /* intraframe buffer is YUV420 format */
+                               *u++ = U[idx >> 1];
+                               *v++ = V[idx >> 1];
                        }
-
-               }
-               else {
-                       YUV_TO_RGB_BY_THE_BOOK(Y[Idx], U[Idx/2], V[Idx/2], rv, gv, bv);
+               } else {
+                       YUV_TO_RGB_BY_THE_BOOK(Y[idx], U[idx / 2], V[idx / 2], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
-                               case V4L2_PIX_FMT_GREY:
-                                       *f++ = Y[Idx];
-                                       break;
-                               case V4L2_PIX_FMT_RGB555:
-                                       *f++ = (0x1F & rv) |
-                                               (0xE0 & (gv << 5));
-                                       *f++ = (0x03 & (gv >> 3)) |
-                                               (0x7C & (bv << 2));
-                                       break;
-                               case V4L2_PIX_FMT_RGB565:
-                                       *f++ = (0x1F & rv) |
-                                               (0xE0 & (gv << 5));
-                                       *f++ = (0x07 & (gv >> 3)) |
-                                               (0xF8 &  bv);
-                                       break;
-                               case V4L2_PIX_FMT_RGB24:
-                                       *f++ = rv;
-                                       *f++ = gv;
-                                       *f++ = bv;
-                                       break;
-                               case V4L2_PIX_FMT_RGB32:
-                                       *f++ = rv;
-                                       *f++ = gv;
-                                       *f++ = bv;
-                                       f++;
-                                       break;
+                       case V4L2_PIX_FMT_GREY:
+                               *f++ = Y[idx];
+                               break;
+                       case V4L2_PIX_FMT_RGB555:
+                               *f++ = (0x1F & rv) |
+                                       (0xE0 & (gv << 5));
+                               *f++ = (0x03 & (gv >> 3)) |
+                                       (0x7C & (bv << 2));
+                               break;
+                       case V4L2_PIX_FMT_RGB565:
+                               *f++ = (0x1F & rv) |
+                                       (0xE0 & (gv << 5));
+                               *f++ = (0x07 & (gv >> 3)) |
+                                       (0xF8 & bv);
+                               break;
+                       case V4L2_PIX_FMT_RGB24:
+                               *f++ = rv;
+                               *f++ = gv;
+                               *f++ = bv;
+                               break;
+                       case V4L2_PIX_FMT_RGB32:
+                               *f++ = rv;
+                               *f++ = gv;
+                               *f++ = bv;
+                               f++;
+                               break;
                        }
                }
                clipmask_index++;
        }
        /* Deal with non-integer no. of bytes for YUV420P */
-       if (frame->v4l2_format.format != V4L2_PIX_FMT_YVU420 )
+       if (frame->v4l2_format.format != V4L2_PIX_FMT_YVU420)
                *pcopylen += frame->v4l2_linesize;
        else
                *pcopylen += frame->curline & 0x01 ? frame->v4l2_linesize : frame->v4l2_linesize << 1;
 
        frame->curline += 1;
 
-       if (frame->curline >= frame->frmheight) {
-               return ParseState_NextFrame;
-       }
-       else {
-               return ParseState_Continue;
-       }
+       if (frame->curline >= frame->frmheight)
+               return parse_state_next_frame;
+       return parse_state_continue;
 
 }
 
@@ -1008,7 +961,7 @@ static enum ParseState usbvision_parse_compress(struct usb_usbvision *usbvision,
  * number of bytes (RGB) to the *pcopylen.
  *
  */
-static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision,
+static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvision,
                                           long *pcopylen)
 {
        struct usbvision_frame *frame;
@@ -1016,11 +969,11 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
        unsigned int pixel_per_line, block;
        int pixel, block_split;
        int y_ptr, u_ptr, v_ptr, y_odd_offset;
-       const int   y_block_size = 128;
-       const int  uv_block_size = 64;
+       const int y_block_size = 128;
+       const int uv_block_size = 64;
        const int sub_block_size = 32;
-       const int y_step[] = { 0, 0, 0, 2 },  y_step_size = 4;
-       const int uv_step[]= { 0, 0, 0, 4 }, uv_step_size = 4;
+       const int y_step[] = { 0, 0, 0, 2 }, y_step_size = 4;
+       const int uv_step[] = { 0, 0, 0, 4 }, uv_step_size = 4;
        unsigned char y[2], u, v;       /* YUV components */
        int y_, u_, v_, vb, uvg, ur;
        int r_, g_, b_;                 /* RGB components */
@@ -1028,7 +981,7 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
        int clipmask_even_index, clipmask_odd_index, bytes_per_pixel;
        int clipmask_add, stretch_bytes;
 
-       frame  = usbvision->curFrame;
+       frame  = usbvision->cur_frame;
        f_even = frame->data + (frame->v4l2_linesize * frame->curline);
        f_odd  = f_even + frame->v4l2_linesize * usbvision->stretch_height;
 
@@ -1040,18 +993,17 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
        clipmask_even_index = frame->curline * MAX_FRAME_WIDTH;
        clipmask_odd_index  = clipmask_even_index + MAX_FRAME_WIDTH;
        clipmask_add = usbvision->stretch_width;
-       pixel_per_line = frame->isocHeader.frameWidth;
+       pixel_per_line = frame->isoc_header.frame_width;
 
        if (scratch_len(usbvision) < (int)pixel_per_line * 3) {
-               //printk(KERN_DEBUG "out of data, need %d\n", len);
-               return ParseState_Out;
+               /* printk(KERN_DEBUG "out of data, need %d\n", len); */
+               return parse_state_out;
        }
 
-       if ((frame->curline + 1) >= frame->frmheight) {
-               return ParseState_NextFrame;
-       }
+       if ((frame->curline + 1) >= frame->frmheight)
+               return parse_state_next_frame;
 
-       block_split = (pixel_per_line%y_block_size) ? 1 : 0;    //are some blocks splitted into different lines?
+       block_split = (pixel_per_line%y_block_size) ? 1 : 0;    /* are some blocks splitted into different lines? */
 
        y_odd_offset = (pixel_per_line / y_block_size) * (y_block_size + uv_block_size)
                        + block_split * uv_block_size;
@@ -1061,31 +1013,27 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
        scratch_set_extra_ptr(usbvision, &v_ptr, y_odd_offset
                        + (4 - block_split) * sub_block_size);
 
-       for (block = 0; block < (pixel_per_line / sub_block_size);
-            block++) {
-
-
-               for (pixel = 0; pixel < sub_block_size; pixel +=2) {
+       for (block = 0; block < (pixel_per_line / sub_block_size); block++) {
+               for (pixel = 0; pixel < sub_block_size; pixel += 2) {
                        scratch_get(usbvision, &y[0], 2);
                        scratch_get_extra(usbvision, &u, &u_ptr, 1);
                        scratch_get_extra(usbvision, &v, &v_ptr, 1);
 
-                       //I don't use the YUV_TO_RGB macro for better performance
+                       /* I don't use the YUV_TO_RGB macro for better performance */
                        v_ = v - 128;
                        u_ = u - 128;
-                       vb =              132252 * v_;
-                       uvg= -53281 * u_ - 25625 * v_;
+                       vb = 132252 * v_;
+                       uvg = -53281 * u_ - 25625 * v_;
                        ur = 104595 * u_;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_even++ = y[0];
                                *f_even++ = v;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[0] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1121,15 +1069,14 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
                        clipmask_even_index += clipmask_add;
                        f_even += stretch_bytes;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_even++ = y[1];
                                *f_even++ = u;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[1] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1167,15 +1114,14 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
 
                        scratch_get_extra(usbvision, &y[0], &y_ptr, 2);
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_odd++ = y[0];
                                *f_odd++ = v;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[0] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1211,15 +1157,14 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
                        clipmask_odd_index += clipmask_add;
                        f_odd += stretch_bytes;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_odd++ = y[1];
                                *f_odd++ = u;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[1] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1256,7 +1201,7 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
                        f_odd += stretch_bytes;
                }
 
-               scratch_rm_old(usbvision,y_step[block % y_step_size] * sub_block_size);
+               scratch_rm_old(usbvision, y_step[block % y_step_size] * sub_block_size);
                scratch_inc_extra_ptr(&y_ptr, y_step[(block + 2 * block_split) % y_step_size]
                                * sub_block_size);
                scratch_inc_extra_ptr(&u_ptr, uv_step[block % uv_step_size]
@@ -1272,9 +1217,8 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
        *pcopylen += frame->v4l2_linesize * 2 * usbvision->stretch_height;
 
        if (frame->curline >= frame->frmheight)
-               return ParseState_NextFrame;
-       else
-               return ParseState_Continue;
+               return parse_state_next_frame;
+       return parse_state_continue;
 }
 
 /*
@@ -1288,53 +1232,43 @@ static enum ParseState usbvision_parse_lines_420(struct usb_usbvision *usbvision
 static void usbvision_parse_data(struct usb_usbvision *usbvision)
 {
        struct usbvision_frame *frame;
-       enum ParseState newstate;
+       enum parse_state newstate;
        long copylen = 0;
        unsigned long lock_flags;
 
-       frame = usbvision->curFrame;
+       frame = usbvision->cur_frame;
 
        PDEBUG(DBG_PARSE, "parsing len=%d\n", scratch_len(usbvision));
 
        while (1) {
-
-               newstate = ParseState_Out;
+               newstate = parse_state_out;
                if (scratch_len(usbvision)) {
-                       if (frame->scanstate == ScanState_Scanning) {
+                       if (frame->scanstate == scan_state_scanning) {
                                newstate = usbvision_find_header(usbvision);
-                       }
-                       else if (frame->scanstate == ScanState_Lines) {
-                               if (usbvision->isocMode == ISOC_MODE_YUV420) {
+                       } else if (frame->scanstate == scan_state_lines) {
+                               if (usbvision->isoc_mode == ISOC_MODE_YUV420)
                                        newstate = usbvision_parse_lines_420(usbvision, &copylen);
-                               }
-                               else if (usbvision->isocMode == ISOC_MODE_YUV422) {
+                               else if (usbvision->isoc_mode == ISOC_MODE_YUV422)
                                        newstate = usbvision_parse_lines_422(usbvision, &copylen);
-                               }
-                               else if (usbvision->isocMode == ISOC_MODE_COMPRESS) {
+                               else if (usbvision->isoc_mode == ISOC_MODE_COMPRESS)
                                        newstate = usbvision_parse_compress(usbvision, &copylen);
-                               }
-
                        }
                }
-               if (newstate == ParseState_Continue) {
+               if (newstate == parse_state_continue)
                        continue;
-               }
-               else if ((newstate == ParseState_NextFrame) || (newstate == ParseState_Out)) {
+               if ((newstate == parse_state_next_frame) || (newstate == parse_state_out))
                        break;
-               }
-               else {
-                       return; /* ParseState_EndParse */
-               }
+               return; /* parse_state_end_parse */
        }
 
-       if (newstate == ParseState_NextFrame) {
-               frame->grabstate = FrameState_Done;
+       if (newstate == parse_state_next_frame) {
+               frame->grabstate = frame_state_done;
                do_gettimeofday(&(frame->timestamp));
                frame->sequence = usbvision->frame_num;
 
                spin_lock_irqsave(&usbvision->queue_lock, lock_flags);
                list_move_tail(&(frame->frame), &usbvision->outqueue);
-               usbvision->curFrame = NULL;
+               usbvision->cur_frame = NULL;
                spin_unlock_irqrestore(&usbvision->queue_lock, lock_flags);
 
                usbvision->frame_num++;
@@ -1344,10 +1278,9 @@ static void usbvision_parse_data(struct usb_usbvision *usbvision)
                        PDEBUG(DBG_PARSE, "Wake up !");
                        wake_up_interruptible(&usbvision->wait_frame);
                }
+       } else {
+               frame->grabstate = frame_state_grabbing;
        }
-       else
-               frame->grabstate = FrameState_Grabbing;
-
 
        /* Update the frame's uncompressed length. */
        frame->scanlength += copylen;
@@ -1370,34 +1303,32 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                packet_data = urb->transfer_buffer + urb->iso_frame_desc[i].offset;
 
                /* Detect and ignore errored packets */
-               if (packet_stat) {      // packet_stat != 0 ?????????????
+               if (packet_stat) {      /* packet_stat != 0 ????????????? */
                        PDEBUG(DBG_ISOC, "data error: [%d] len=%d, status=%X", i, packet_len, packet_stat);
-                       usbvision->isocErrCount++;
+                       usbvision->isoc_err_count++;
                        continue;
                }
 
                /* Detect and ignore empty packets */
                if (packet_len < 0) {
                        PDEBUG(DBG_ISOC, "error packet [%d]", i);
-                       usbvision->isocSkipCount++;
+                       usbvision->isoc_skip_count++;
                        continue;
-               }
-               else if (packet_len == 0) {     /* Frame end ????? */
+               } else if (packet_len == 0) {   /* Frame end ????? */
                        PDEBUG(DBG_ISOC, "null packet [%d]", i);
-                       usbvision->isocstate=IsocState_NoFrame;
-                       usbvision->isocSkipCount++;
+                       usbvision->isocstate = isoc_state_no_frame;
+                       usbvision->isoc_skip_count++;
                        continue;
-               }
-               else if (packet_len > usbvision->isocPacketSize) {
-                       PDEBUG(DBG_ISOC, "packet[%d] > isocPacketSize", i);
-                       usbvision->isocSkipCount++;
+               } else if (packet_len > usbvision->isoc_packet_size) {
+                       PDEBUG(DBG_ISOC, "packet[%d] > isoc_packet_size", i);
+                       usbvision->isoc_skip_count++;
                        continue;
                }
 
                PDEBUG(DBG_ISOC, "packet ok [%d] len=%d", i, packet_len);
 
-               if (usbvision->isocstate==IsocState_NoFrame) { //new frame begins
-                       usbvision->isocstate=IsocState_InFrame;
+               if (usbvision->isocstate == isoc_state_no_frame) { /* new frame begins */
+                       usbvision->isocstate = isoc_state_in_frame;
                        scratch_mark_header(usbvision);
                        usbvision_measure_bandwidth(usbvision);
                        PDEBUG(DBG_ISOC, "packet with header");
@@ -1412,7 +1343,6 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                 * your favorite evil here.
                 */
                if (scratch_free(usbvision) < packet_len) {
-
                        usbvision->scratch_ovf_count++;
                        PDEBUG(DBG_ISOC, "scratch buf overflow! scr_len: %d, n: %d",
                               scratch_len(usbvision), packet_len);
@@ -1422,12 +1352,13 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                /* Now we know that there is enough room in scratch buffer */
                scratch_put(usbvision, packet_data, packet_len);
                totlen += packet_len;
-               usbvision->isocDataCount += packet_len;
-               usbvision->isocPacketCount++;
+               usbvision->isoc_data_count += packet_len;
+               usbvision->isoc_packet_count++;
        }
 #if ENABLE_HEXDUMP
        if (totlen > 0) {
                static int foo;
+
                if (foo < 1) {
                        printk(KERN_DEBUG "+%d.\n", usbvision->scratchlen);
                        usbvision_hexdump(data0, (totlen > 64) ? 64 : totlen);
@@ -1435,16 +1366,16 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                }
        }
 #endif
- return totlen;
      return totlen;
 }
 
-static void usbvision_isocIrq(struct urb *urb)
+static void usbvision_isoc_irq(struct urb *urb)
 {
-       int errCode = 0;
+       int err_code = 0;
        int len;
        struct usb_usbvision *usbvision = urb->context;
        int i;
-       unsigned long startTime = jiffies;
+       unsigned long start_time = jiffies;
        struct usbvision_frame **f;
 
        /* We don't want to do anything if we are about to be removed! */
@@ -1452,18 +1383,17 @@ static void usbvision_isocIrq(struct urb *urb)
                return;
 
        /* any urb with wrong status is ignored without acknowledgement */
-       if (urb->status == -ENOENT) {
+       if (urb->status == -ENOENT)
                return;
-       }
 
-       f = &usbvision->curFrame;
+       f = &usbvision->cur_frame;
 
        /* Manage streaming interruption */
-       if (usbvision->streaming == Stream_Interrupt) {
-               usbvision->streaming = Stream_Idle;
+       if (usbvision->streaming == stream_interrupt) {
+               usbvision->streaming = stream_idle;
                if ((*f)) {
-                       (*f)->grabstate = FrameState_Ready;
-                       (*f)->scanstate = ScanState_Scanning;
+                       (*f)->grabstate = frame_state_ready;
+                       (*f)->scanstate = scan_state_scanning;
                }
                PDEBUG(DBG_IRQ, "stream interrupted");
                wake_up_interruptible(&usbvision->wait_stream);
@@ -1472,35 +1402,32 @@ static void usbvision_isocIrq(struct urb *urb)
        /* Copy the data received into our scratch buffer */
        len = usbvision_compress_isochronous(usbvision, urb);
 
-       usbvision->isocUrbCount++;
+       usbvision->isoc_urb_count++;
        usbvision->urb_length = len;
 
-       if (usbvision->streaming == Stream_On) {
-
+       if (usbvision->streaming == stream_on) {
                /* If we collected enough data let's parse! */
-               if ((scratch_len(usbvision) > USBVISION_HEADER_LENGTH) &&
-                   (!list_empty(&(usbvision->inqueue))) ) {
+               if (scratch_len(usbvision) > USBVISION_HEADER_LENGTH &&
+                   !list_empty(&(usbvision->inqueue))) {
                        if (!(*f)) {
                                (*f) = list_entry(usbvision->inqueue.next,
                                                  struct usbvision_frame,
                                                  frame);
                        }
                        usbvision_parse_data(usbvision);
-               }
-               else {
-                       /*If we don't have a frame
+               } else {
+                       /* If we don't have a frame
                          we're current working on, complain */
                        PDEBUG(DBG_IRQ,
                               "received data, but no one needs it");
                        scratch_reset(usbvision);
                }
-       }
-       else {
+       } else {
                PDEBUG(DBG_IRQ, "received data, but no one needs it");
                scratch_reset(usbvision);
        }
 
-       usbvision->timeInIrq += jiffies - startTime;
+       usbvision->time_in_irq += jiffies - start_time;
 
        for (i = 0; i < USBVISION_URB_FRAMES; i++) {
                urb->iso_frame_desc[i].status = 0;
@@ -1509,12 +1436,12 @@ static void usbvision_isocIrq(struct urb *urb)
 
        urb->status = 0;
        urb->dev = usbvision->dev;
-       errCode = usb_submit_urb (urb, GFP_ATOMIC);
+       err_code = usb_submit_urb(urb, GFP_ATOMIC);
 
-       if(errCode) {
+       if (err_code) {
                dev_err(&usbvision->dev->dev,
                        "%s: usb_submit_urb failed: error %d\n",
-                               __func__, errCode);
+                               __func__, err_code);
        }
 
        return;
@@ -1533,21 +1460,21 @@ static void usbvision_isocIrq(struct urb *urb)
 
 int usbvision_read_reg(struct usb_usbvision *usbvision, unsigned char reg)
 {
-       int errCode = 0;
+       int err_code = 0;
        unsigned char buffer[1];
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
                return -1;
 
-       errCode = usb_control_msg(usbvision->dev, usb_rcvctrlpipe(usbvision->dev, 1),
+       err_code = usb_control_msg(usbvision->dev, usb_rcvctrlpipe(usbvision->dev, 1),
                                USBVISION_OP_CODE,
                                USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT,
                                0, (__u16) reg, buffer, 1, HZ);
 
-       if (errCode < 0) {
+       if (err_code < 0) {
                dev_err(&usbvision->dev->dev,
-                       "%s: failed: error %d\n", __func__, errCode);
-               return errCode;
+                       "%s: failed: error %d\n", __func__, err_code);
+               return err_code;
        }
        return buffer[0];
 }
@@ -1563,179 +1490,176 @@ int usbvision_read_reg(struct usb_usbvision *usbvision, unsigned char reg)
 int usbvision_write_reg(struct usb_usbvision *usbvision, unsigned char reg,
                            unsigned char value)
 {
-       int errCode = 0;
+       int err_code = 0;
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
                return 0;
 
-       errCode = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
+       err_code = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
                                USBVISION_OP_CODE,
                                USB_DIR_OUT | USB_TYPE_VENDOR |
                                USB_RECIP_ENDPOINT, 0, (__u16) reg, &value, 1, HZ);
 
-       if (errCode < 0) {
+       if (err_code < 0) {
                dev_err(&usbvision->dev->dev,
-                       "%s: failed: error %d\n", __func__, errCode);
+                       "%s: failed: error %d\n", __func__, err_code);
        }
-       return errCode;
+       return err_code;
 }
 
 
-static void usbvision_ctrlUrb_complete(struct urb *urb)
+static void usbvision_ctrl_urb_complete(struct urb *urb)
 {
        struct usb_usbvision *usbvision = (struct usb_usbvision *)urb->context;
 
        PDEBUG(DBG_IRQ, "");
-       usbvision->ctrlUrbBusy = 0;
-       if (waitqueue_active(&usbvision->ctrlUrb_wq)) {
-               wake_up_interruptible(&usbvision->ctrlUrb_wq);
-       }
+       usbvision->ctrl_urb_busy = 0;
+       if (waitqueue_active(&usbvision->ctrl_urb_wq))
+               wake_up_interruptible(&usbvision->ctrl_urb_wq);
 }
 
 
-static int usbvision_write_reg_irq(struct usb_usbvision *usbvision,int address,
-                                                                       unsigned char *data, int len)
+static int usbvision_write_reg_irq(struct usb_usbvision *usbvision, int address,
+                               unsigned char *data, int len)
 {
-       int errCode = 0;
+       int err_code = 0;
 
        PDEBUG(DBG_IRQ, "");
-       if (len > 8) {
+       if (len > 8)
                return -EFAULT;
-       }
-       if (usbvision->ctrlUrbBusy) {
+       if (usbvision->ctrl_urb_busy)
                return -EBUSY;
-       }
-       usbvision->ctrlUrbBusy = 1;
-
-       usbvision->ctrlUrbSetup.bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT;
-       usbvision->ctrlUrbSetup.bRequest     = USBVISION_OP_CODE;
-       usbvision->ctrlUrbSetup.wValue       = 0;
-       usbvision->ctrlUrbSetup.wIndex       = cpu_to_le16(address);
-       usbvision->ctrlUrbSetup.wLength      = cpu_to_le16(len);
-       usb_fill_control_urb (usbvision->ctrlUrb, usbvision->dev,
+       usbvision->ctrl_urb_busy = 1;
+
+       usbvision->ctrl_urb_setup.bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT;
+       usbvision->ctrl_urb_setup.bRequest     = USBVISION_OP_CODE;
+       usbvision->ctrl_urb_setup.wValue       = 0;
+       usbvision->ctrl_urb_setup.wIndex       = cpu_to_le16(address);
+       usbvision->ctrl_urb_setup.wLength      = cpu_to_le16(len);
+       usb_fill_control_urb(usbvision->ctrl_urb, usbvision->dev,
                                                        usb_sndctrlpipe(usbvision->dev, 1),
-                                                       (unsigned char *)&usbvision->ctrlUrbSetup,
-                                                       (void *)usbvision->ctrlUrbBuffer, len,
-                                                       usbvision_ctrlUrb_complete,
+                                                       (unsigned char *)&usbvision->ctrl_urb_setup,
+                                                       (void *)usbvision->ctrl_urb_buffer, len,
+                                                       usbvision_ctrl_urb_complete,
                                                        (void *)usbvision);
 
-       memcpy(usbvision->ctrlUrbBuffer, data, len);
+       memcpy(usbvision->ctrl_urb_buffer, data, len);
 
-       errCode = usb_submit_urb(usbvision->ctrlUrb, GFP_ATOMIC);
-       if (errCode < 0) {
-               // error in usb_submit_urb()
-               usbvision->ctrlUrbBusy = 0;
+       err_code = usb_submit_urb(usbvision->ctrl_urb, GFP_ATOMIC);
+       if (err_code < 0) {
+               /* error in usb_submit_urb() */
+               usbvision->ctrl_urb_busy = 0;
        }
-       PDEBUG(DBG_IRQ, "submit %d byte: error %d", len, errCode);
-       return errCode;
+       PDEBUG(DBG_IRQ, "submit %d byte: error %d", len, err_code);
+       return err_code;
 }
 
 
 static int usbvision_init_compression(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
-
-       usbvision->lastIsocFrameNum = -1;
-       usbvision->isocDataCount = 0;
-       usbvision->isocPacketCount = 0;
-       usbvision->isocSkipCount = 0;
-       usbvision->comprLevel = 50;
-       usbvision->lastComprLevel = -1;
-       usbvision->isocUrbCount = 0;
-       usbvision->requestIntra = 1;
-       usbvision->isocMeasureBandwidthCount = 0;
-
-       return errCode;
+       int err_code = 0;
+
+       usbvision->last_isoc_frame_num = -1;
+       usbvision->isoc_data_count = 0;
+       usbvision->isoc_packet_count = 0;
+       usbvision->isoc_skip_count = 0;
+       usbvision->compr_level = 50;
+       usbvision->last_compr_level = -1;
+       usbvision->isoc_urb_count = 0;
+       usbvision->request_intra = 1;
+       usbvision->isoc_measure_bandwidth_count = 0;
+
+       return err_code;
 }
 
 /* this function measures the used bandwidth since last call
  * return:    0 : no error
- * sets usedBandwidth to 1-100 : 1-100% of full bandwidth resp. to isocPacketSize
+ * sets used_bandwidth to 1-100 : 1-100% of full bandwidth resp. to isoc_packet_size
  */
-static int usbvision_measure_bandwidth (struct usb_usbvision *usbvision)
+static int usbvision_measure_bandwidth(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
-
-       if (usbvision->isocMeasureBandwidthCount < 2) { // this gives an average bandwidth of 3 frames
-               usbvision->isocMeasureBandwidthCount++;
-               return errCode;
-       }
-       if ((usbvision->isocPacketSize > 0) && (usbvision->isocPacketCount > 0)) {
-               usbvision->usedBandwidth = usbvision->isocDataCount /
-                                       (usbvision->isocPacketCount + usbvision->isocSkipCount) *
-                                       100 / usbvision->isocPacketSize;
-       }
-       usbvision->isocMeasureBandwidthCount = 0;
-       usbvision->isocDataCount = 0;
-       usbvision->isocPacketCount = 0;
-       usbvision->isocSkipCount = 0;
-       return errCode;
+       int err_code = 0;
+
+       if (usbvision->isoc_measure_bandwidth_count < 2) { /* this gives an average bandwidth of 3 frames */
+               usbvision->isoc_measure_bandwidth_count++;
+               return err_code;
+       }
+       if ((usbvision->isoc_packet_size > 0) && (usbvision->isoc_packet_count > 0)) {
+               usbvision->used_bandwidth = usbvision->isoc_data_count /
+                                       (usbvision->isoc_packet_count + usbvision->isoc_skip_count) *
+                                       100 / usbvision->isoc_packet_size;
+       }
+       usbvision->isoc_measure_bandwidth_count = 0;
+       usbvision->isoc_data_count = 0;
+       usbvision->isoc_packet_count = 0;
+       usbvision->isoc_skip_count = 0;
+       return err_code;
 }
 
-static int usbvision_adjust_compression (struct usb_usbvision *usbvision)
+static int usbvision_adjust_compression(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
+       int err_code = 0;
        unsigned char buffer[6];
 
        PDEBUG(DBG_IRQ, "");
-       if ((adjustCompression) && (usbvision->usedBandwidth > 0)) {
-               usbvision->comprLevel += (usbvision->usedBandwidth - 90) / 2;
-               RESTRICT_TO_RANGE(usbvision->comprLevel, 0, 100);
-               if (usbvision->comprLevel != usbvision->lastComprLevel) {
-                       int distorsion;
-                       if (usbvision->bridgeType == BRIDGE_NT1004 || usbvision->bridgeType == BRIDGE_NT1005) {
-                               buffer[0] = (unsigned char)(4 + 16 * usbvision->comprLevel / 100);      // PCM Threshold 1
-                               buffer[1] = (unsigned char)(4 + 8 * usbvision->comprLevel / 100);       // PCM Threshold 2
-                               distorsion = 7 + 248 * usbvision->comprLevel / 100;
-                               buffer[2] = (unsigned char)(distorsion & 0xFF);                         // Average distorsion Threshold (inter)
-                               buffer[3] = (unsigned char)(distorsion & 0xFF);                         // Average distorsion Threshold (intra)
-                               distorsion = 1 + 42 * usbvision->comprLevel / 100;
-                               buffer[4] = (unsigned char)(distorsion & 0xFF);                         // Maximum distorsion Threshold (inter)
-                               buffer[5] = (unsigned char)(distorsion & 0xFF);                         // Maximum distorsion Threshold (intra)
-                       }
-                       else { //BRIDGE_NT1003
-                               buffer[0] = (unsigned char)(4 + 16 * usbvision->comprLevel / 100);      // PCM threshold 1
-                               buffer[1] = (unsigned char)(4 + 8 * usbvision->comprLevel / 100);       // PCM threshold 2
-                               distorsion = 2 + 253 * usbvision->comprLevel / 100;
-                               buffer[2] = (unsigned char)(distorsion & 0xFF);                         // distorsion threshold bit0-7
-                               buffer[3] = 0;  //(unsigned char)((distorsion >> 8) & 0x0F);            // distorsion threshold bit 8-11
-                               distorsion = 0 + 43 * usbvision->comprLevel / 100;
-                               buffer[4] = (unsigned char)(distorsion & 0xFF);                         // maximum distorsion bit0-7
-                               buffer[5] = 0; //(unsigned char)((distorsion >> 8) & 0x01);             // maximum distorsion bit 8
+       if ((adjust_compression) && (usbvision->used_bandwidth > 0)) {
+               usbvision->compr_level += (usbvision->used_bandwidth - 90) / 2;
+               RESTRICT_TO_RANGE(usbvision->compr_level, 0, 100);
+               if (usbvision->compr_level != usbvision->last_compr_level) {
+                       int distortion;
+
+                       if (usbvision->bridge_type == BRIDGE_NT1004 || usbvision->bridge_type == BRIDGE_NT1005) {
+                               buffer[0] = (unsigned char)(4 + 16 * usbvision->compr_level / 100);     /* PCM Threshold 1 */
+                               buffer[1] = (unsigned char)(4 + 8 * usbvision->compr_level / 100);      /* PCM Threshold 2 */
+                               distortion = 7 + 248 * usbvision->compr_level / 100;
+                               buffer[2] = (unsigned char)(distortion & 0xFF);                         /* Average distortion Threshold (inter) */
+                               buffer[3] = (unsigned char)(distortion & 0xFF);                         /* Average distortion Threshold (intra) */
+                               distortion = 1 + 42 * usbvision->compr_level / 100;
+                               buffer[4] = (unsigned char)(distortion & 0xFF);                         /* Maximum distortion Threshold (inter) */
+                               buffer[5] = (unsigned char)(distortion & 0xFF);                         /* Maximum distortion Threshold (intra) */
+                       } else { /* BRIDGE_NT1003 */
+                               buffer[0] = (unsigned char)(4 + 16 * usbvision->compr_level / 100);     /* PCM threshold 1 */
+                               buffer[1] = (unsigned char)(4 + 8 * usbvision->compr_level / 100);      /* PCM threshold 2 */
+                               distortion = 2 + 253 * usbvision->compr_level / 100;
+                               buffer[2] = (unsigned char)(distortion & 0xFF);                         /* distortion threshold bit0-7 */
+                               buffer[3] = 0;  /* (unsigned char)((distortion >> 8) & 0x0F);           distortion threshold bit 8-11 */
+                               distortion = 0 + 43 * usbvision->compr_level / 100;
+                               buffer[4] = (unsigned char)(distortion & 0xFF);                         /* maximum distortion bit0-7 */
+                               buffer[5] = 0; /* (unsigned char)((distortion >> 8) & 0x01);            maximum distortion bit 8 */
                        }
-                       errCode = usbvision_write_reg_irq(usbvision, USBVISION_PCM_THR1, buffer, 6);
-                       if (errCode == 0){
+                       err_code = usbvision_write_reg_irq(usbvision, USBVISION_PCM_THR1, buffer, 6);
+                       if (err_code == 0) {
                                PDEBUG(DBG_IRQ, "new compr params %#02x %#02x %#02x %#02x %#02x %#02x", buffer[0],
                                                                buffer[1], buffer[2], buffer[3], buffer[4], buffer[5]);
-                               usbvision->lastComprLevel = usbvision->comprLevel;
+                               usbvision->last_compr_level = usbvision->compr_level;
                        }
                }
        }
-       return errCode;
+       return err_code;
 }
 
-static int usbvision_request_intra (struct usb_usbvision *usbvision)
+static int usbvision_request_intra(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
+       int err_code = 0;
        unsigned char buffer[1];
 
        PDEBUG(DBG_IRQ, "");
-       usbvision->requestIntra = 1;
+       usbvision->request_intra = 1;
        buffer[0] = 1;
        usbvision_write_reg_irq(usbvision, USBVISION_FORCE_INTRA, buffer, 1);
-       return errCode;
+       return err_code;
 }
 
-static int usbvision_unrequest_intra (struct usb_usbvision *usbvision)
+static int usbvision_unrequest_intra(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
+       int err_code = 0;
        unsigned char buffer[1];
 
        PDEBUG(DBG_IRQ, "");
-       usbvision->requestIntra = 0;
+       usbvision->request_intra = 0;
        buffer[0] = 0;
        usbvision_write_reg_irq(usbvision, USBVISION_FORCE_INTRA, buffer, 1);
-       return errCode;
+       return err_code;
 }
 
 /*******************************
@@ -1744,16 +1668,15 @@ static int usbvision_unrequest_intra (struct usb_usbvision *usbvision)
 
 int usbvision_power_off(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
+       int err_code = 0;
 
        PDEBUG(DBG_FUNC, "");
 
-       errCode = usbvision_write_reg(usbvision, USBVISION_PWR_REG, USBVISION_SSPND_EN);
-       if (errCode == 1) {
+       err_code = usbvision_write_reg(usbvision, USBVISION_PWR_REG, USBVISION_SSPND_EN);
+       if (err_code == 1)
                usbvision->power = 0;
-       }
-       PDEBUG(DBG_FUNC, "%s: errCode %d", (errCode!=1)?"ERROR":"power is off", errCode);
-       return errCode;
+       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code != 1) ? "ERROR" : "power is off", err_code);
+       return err_code;
 }
 
 /*
@@ -1769,7 +1692,7 @@ static int usbvision_set_video_format(struct usb_usbvision *usbvision, int forma
        if (!USBVISION_IS_OPERATIONAL(usbvision))
                return 0;
 
-       PDEBUG(DBG_FUNC, "isocMode %#02x", format);
+       PDEBUG(DBG_FUNC, "isoc_mode %#02x", format);
 
        if ((format != ISOC_MODE_YUV422)
            && (format != ISOC_MODE_YUV420)
@@ -1778,8 +1701,8 @@ static int usbvision_set_video_format(struct usb_usbvision *usbvision, int forma
                       format);
                format = ISOC_MODE_YUV420;
        }
-       value[0] = 0x0A;  //TODO: See the effect of the filter
-       value[1] = format; // Sets the VO_MODE register which follows FILT_CONT
+       value[0] = 0x0A;  /* TODO: See the effect of the filter */
+       value[1] = format; /* Sets the VO_MODE register which follows FILT_CONT */
        rc = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
                             USBVISION_OP_CODE,
                             USB_DIR_OUT | USB_TYPE_VENDOR |
@@ -1790,7 +1713,7 @@ static int usbvision_set_video_format(struct usb_usbvision *usbvision, int forma
                printk(KERN_ERR "%s: ERROR=%d. USBVISION stopped - "
                       "reconnect or reload driver.\n", proc, rc);
        }
-       usbvision->isocMode = format;
+       usbvision->isoc_mode = format;
        return rc;
 }
 
@@ -1802,96 +1725,88 @@ static int usbvision_set_video_format(struct usb_usbvision *usbvision, int forma
 int usbvision_set_output(struct usb_usbvision *usbvision, int width,
                         int height)
 {
-       int errCode = 0;
-       int UsbWidth, UsbHeight;
-       unsigned int frameRate=0, frameDrop=0;
+       int err_code = 0;
+       int usb_width, usb_height;
+       unsigned int frame_rate = 0, frame_drop = 0;
        unsigned char value[4];
 
-       if (!USBVISION_IS_OPERATIONAL(usbvision)) {
+       if (!USBVISION_IS_OPERATIONAL(usbvision))
                return 0;
-       }
 
        if (width > MAX_USB_WIDTH) {
-               UsbWidth = width / 2;
+               usb_width = width / 2;
                usbvision->stretch_width = 2;
-       }
-       else {
-               UsbWidth = width;
+       } else {
+               usb_width = width;
                usbvision->stretch_width = 1;
        }
 
        if (height > MAX_USB_HEIGHT) {
-               UsbHeight = height / 2;
+               usb_height = height / 2;
                usbvision->stretch_height = 2;
-       }
-       else {
-               UsbHeight = height;
+       } else {
+               usb_height = height;
                usbvision->stretch_height = 1;
        }
 
-       RESTRICT_TO_RANGE(UsbWidth, MIN_FRAME_WIDTH, MAX_USB_WIDTH);
-       UsbWidth &= ~(MIN_FRAME_WIDTH-1);
-       RESTRICT_TO_RANGE(UsbHeight, MIN_FRAME_HEIGHT, MAX_USB_HEIGHT);
-       UsbHeight &= ~(1);
+       RESTRICT_TO_RANGE(usb_width, MIN_FRAME_WIDTH, MAX_USB_WIDTH);
+       usb_width &= ~(MIN_FRAME_WIDTH-1);
+       RESTRICT_TO_RANGE(usb_height, MIN_FRAME_HEIGHT, MAX_USB_HEIGHT);
+       usb_height &= ~(1);
 
        PDEBUG(DBG_FUNC, "usb %dx%d; screen %dx%d; stretch %dx%d",
-                                               UsbWidth, UsbHeight, width, height,
+                                               usb_width, usb_height, width, height,
                                                usbvision->stretch_width, usbvision->stretch_height);
 
        /* I'll not rewrite the same values */
-       if ((UsbWidth != usbvision->curwidth) || (UsbHeight != usbvision->curheight)) {
-               value[0] = UsbWidth & 0xff;             //LSB
-               value[1] = (UsbWidth >> 8) & 0x03;      //MSB
-               value[2] = UsbHeight & 0xff;            //LSB
-               value[3] = (UsbHeight >> 8) & 0x03;     //MSB
+       if ((usb_width != usbvision->curwidth) || (usb_height != usbvision->curheight)) {
+               value[0] = usb_width & 0xff;            /* LSB */
+               value[1] = (usb_width >> 8) & 0x03;     /* MSB */
+               value[2] = usb_height & 0xff;           /* LSB */
+               value[3] = (usb_height >> 8) & 0x03;    /* MSB */
 
-               errCode = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
+               err_code = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
                             USBVISION_OP_CODE,
                             USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT,
                                 0, (__u16) USBVISION_LXSIZE_O, value, 4, HZ);
 
-               if (errCode < 0) {
+               if (err_code < 0) {
                        dev_err(&usbvision->dev->dev,
-                               "%s failed: error %d\n", __func__, errCode);
-                       return errCode;
+                               "%s failed: error %d\n", __func__, err_code);
+                       return err_code;
                }
-               usbvision->curwidth = usbvision->stretch_width * UsbWidth;
-               usbvision->curheight = usbvision->stretch_height * UsbHeight;
+               usbvision->curwidth = usbvision->stretch_width * usb_width;
+               usbvision->curheight = usbvision->stretch_height * usb_height;
        }
 
-       if (usbvision->isocMode == ISOC_MODE_YUV422) {
-               frameRate = (usbvision->isocPacketSize * 1000) / (UsbWidth * UsbHeight * 2);
-       }
-       else if (usbvision->isocMode == ISOC_MODE_YUV420) {
-               frameRate = (usbvision->isocPacketSize * 1000) / ((UsbWidth * UsbHeight * 12) / 8);
-       }
-       else {
-               frameRate = FRAMERATE_MAX;
-       }
+       if (usbvision->isoc_mode == ISOC_MODE_YUV422)
+               frame_rate = (usbvision->isoc_packet_size * 1000) / (usb_width * usb_height * 2);
+       else if (usbvision->isoc_mode == ISOC_MODE_YUV420)
+               frame_rate = (usbvision->isoc_packet_size * 1000) / ((usb_width * usb_height * 12) / 8);
+       else
+               frame_rate = FRAMERATE_MAX;
 
-       if (usbvision->tvnormId & V4L2_STD_625_50) {
-               frameDrop = frameRate * 32 / 25 - 1;
-       }
-       else if (usbvision->tvnormId & V4L2_STD_525_60) {
-               frameDrop = frameRate * 32 / 30 - 1;
-       }
+       if (usbvision->tvnorm_id & V4L2_STD_625_50)
+               frame_drop = frame_rate * 32 / 25 - 1;
+       else if (usbvision->tvnorm_id & V4L2_STD_525_60)
+               frame_drop = frame_rate * 32 / 30 - 1;
 
-       RESTRICT_TO_RANGE(frameDrop, FRAMERATE_MIN, FRAMERATE_MAX);
+       RESTRICT_TO_RANGE(frame_drop, FRAMERATE_MIN, FRAMERATE_MAX);
 
-       PDEBUG(DBG_FUNC, "frameRate %d fps, frameDrop %d", frameRate, frameDrop);
+       PDEBUG(DBG_FUNC, "frame_rate %d fps, frame_drop %d", frame_rate, frame_drop);
 
-       frameDrop = FRAMERATE_MAX;      // We can allow the maximum here, because dropping is controlled
+       frame_drop = FRAMERATE_MAX;     /* We can allow the maximum here, because dropping is controlled */
 
-       /* frameDrop = 7; => framePhase = 1, 5, 9, 13, 17, 21, 25, 0, 4, 8, ...
-               => frameSkip = 4;
-               => frameRate = (7 + 1) * 25 / 32 = 200 / 32 = 6.25;
+       /* frame_drop = 7; => frame_phase = 1, 5, 9, 13, 17, 21, 25, 0, 4, 8, ...
+               => frame_skip = 4;
+               => frame_rate = (7 + 1) * 25 / 32 = 200 / 32 = 6.25;
 
-          frameDrop = 9; => framePhase = 1, 5, 8, 11, 14, 17, 21, 24, 27, 1, 4, 8, ...
-           => frameSkip = 4, 3, 3, 3, 3, 4, 3, 3, 3, 3, 4, ...
-               => frameRate = (9 + 1) * 25 / 32 = 250 / 32 = 7.8125;
+          frame_drop = 9; => frame_phase = 1, 5, 8, 11, 14, 17, 21, 24, 27, 1, 4, 8, ...
+           => frame_skip = 4, 3, 3, 3, 3, 4, 3, 3, 3, 3, 4, ...
+               => frame_rate = (9 + 1) * 25 / 32 = 250 / 32 = 7.8125;
        */
-       errCode = usbvision_write_reg(usbvision, USBVISION_FRM_RATE, frameDrop);
-       return errCode;
+       err_code = usbvision_write_reg(usbvision, USBVISION_FRM_RATE, frame_drop);
+       return err_code;
 }
 
 
@@ -1903,8 +1818,8 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
 {
        int i;
 
-       /*needs to be page aligned cause the buffers can be mapped individually! */
-       usbvision->max_frame_size =  PAGE_ALIGN(usbvision->curwidth *
+       /* needs to be page aligned cause the buffers can be mapped individually! */
+       usbvision->max_frame_size = PAGE_ALIGN(usbvision->curwidth *
                                                usbvision->curheight *
                                                usbvision->palette.bytes_per_pixel);
 
@@ -1912,9 +1827,9 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
        usbvision->num_frames = number_of_frames;
        while (usbvision->num_frames > 0) {
                usbvision->fbuf_size = usbvision->num_frames * usbvision->max_frame_size;
-               if((usbvision->fbuf = usbvision_rvmalloc(usbvision->fbuf_size))) {
+               usbvision->fbuf = usbvision_rvmalloc(usbvision->fbuf_size);
+               if (usbvision->fbuf)
                        break;
-               }
                usbvision->num_frames--;
        }
 
@@ -1925,7 +1840,7 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
        /* Allocate all buffers */
        for (i = 0; i < usbvision->num_frames; i++) {
                usbvision->frame[i].index = i;
-               usbvision->frame[i].grabstate = FrameState_Unused;
+               usbvision->frame[i].grabstate = frame_state_unused;
                usbvision->frame[i].data = usbvision->fbuf +
                        i * usbvision->max_frame_size;
                /*
@@ -1937,7 +1852,8 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
                usbvision->frame[i].height = usbvision->curheight;
                usbvision->frame[i].bytes_read = 0;
        }
-       PDEBUG(DBG_FUNC, "allocated %d frames (%d bytes per frame)",usbvision->num_frames,usbvision->max_frame_size);
+       PDEBUG(DBG_FUNC, "allocated %d frames (%d bytes per frame)",
+                       usbvision->num_frames, usbvision->max_frame_size);
        return usbvision->num_frames;
 }
 
@@ -1948,7 +1864,7 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
 void usbvision_frames_free(struct usb_usbvision *usbvision)
 {
        /* Have to free all that memory */
-       PDEBUG(DBG_FUNC, "free %d frames",usbvision->num_frames);
+       PDEBUG(DBG_FUNC, "free %d frames", usbvision->num_frames);
 
        if (usbvision->fbuf != NULL) {
                usbvision_rvfree(usbvision->fbuf, usbvision->fbuf_size);
@@ -1969,7 +1885,7 @@ void usbvision_empty_framequeues(struct usb_usbvision *usbvision)
        INIT_LIST_HEAD(&(usbvision->outqueue));
 
        for (i = 0; i < USBVISION_NUMFRAMES; i++) {
-               usbvision->frame[i].grabstate = FrameState_Unused;
+               usbvision->frame[i].grabstate = frame_state_unused;
                usbvision->frame[i].bytes_read = 0;
        }
 }
@@ -1984,9 +1900,9 @@ int usbvision_stream_interrupt(struct usb_usbvision *usbvision)
 
        /* stop reading from the device */
 
-       usbvision->streaming = Stream_Interrupt;
+       usbvision->streaming = stream_interrupt;
        ret = wait_event_timeout(usbvision->wait_stream,
-                                (usbvision->streaming == Stream_Idle),
+                                (usbvision->streaming == stream_idle),
                                 msecs_to_jiffies(USBVISION_NUMSBUF*USBVISION_URB_FRAMES));
        return ret;
 }
@@ -2002,19 +1918,19 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
        int rc;
        unsigned char value[6];
 
-       value[0] = 0x0F;    // Intra-Compression cycle
-       value[1] = 0x01;    // Reg.45 one line per strip
-       value[2] = 0x00;    // Reg.46 Force intra mode on all new frames
-       value[3] = 0x00;    // Reg.47 FORCE_UP <- 0 normal operation (not force)
-       value[4] = 0xA2;    // Reg.48 BUF_THR I'm not sure if this does something in not compressed mode.
-       value[5] = 0x00;    // Reg.49 DVI_YUV This has nothing to do with compression
-
-       //catched values for NT1004
-       // value[0] = 0xFF; // Never apply intra mode automatically
-       // value[1] = 0xF1; // Use full frame height for virtual strip width; One line per strip
-       // value[2] = 0x01; // Force intra mode on all new frames
-       // value[3] = 0x00; // Strip size 400 Bytes; do not force up
-       // value[4] = 0xA2; //
+       value[0] = 0x0F;    /* Intra-Compression cycle */
+       value[1] = 0x01;    /* Reg.45 one line per strip */
+       value[2] = 0x00;    /* Reg.46 Force intra mode on all new frames */
+       value[3] = 0x00;    /* Reg.47 FORCE_UP <- 0 normal operation (not force) */
+       value[4] = 0xA2;    /* Reg.48 BUF_THR I'm not sure if this does something in not compressed mode. */
+       value[5] = 0x00;    /* Reg.49 DVI_YUV This has nothing to do with compression */
+
+       /* catched values for NT1004 */
+       /* value[0] = 0xFF; Never apply intra mode automatically */
+       /* value[1] = 0xF1; Use full frame height for virtual strip width; One line per strip */
+       /* value[2] = 0x01; Force intra mode on all new frames */
+       /* value[3] = 0x00; Strip size 400 Bytes; do not force up */
+       /* value[4] = 0xA2; */
        if (!USBVISION_IS_OPERATIONAL(usbvision))
                return 0;
 
@@ -2030,21 +1946,20 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
                return rc;
        }
 
-       if (usbvision->bridgeType == BRIDGE_NT1004) {
-               value[0] =  20; // PCM Threshold 1
-               value[1] =  12; // PCM Threshold 2
-               value[2] = 255; // Distorsion Threshold inter
-               value[3] = 255; // Distorsion Threshold intra
-               value[4] =  43; // Max Distorsion inter
-               value[5] =  43; // Max Distorsion intra
-       }
-       else {
-               value[0] =  20; // PCM Threshold 1
-               value[1] =  12; // PCM Threshold 2
-               value[2] = 255; // Distorsion Threshold d7-d0
-               value[3] =   0; // Distorsion Threshold d11-d8
-               value[4] =  43; // Max Distorsion d7-d0
-               value[5] =   0; // Max Distorsion d8
+       if (usbvision->bridge_type == BRIDGE_NT1004) {
+               value[0] =  20; /* PCM Threshold 1 */
+               value[1] =  12; /* PCM Threshold 2 */
+               value[2] = 255; /* Distortion Threshold inter */
+               value[3] = 255; /* Distortion Threshold intra */
+               value[4] =  43; /* Max Distortion inter */
+               value[5] =  43; /* Max Distortion intra */
+       } else {
+               value[0] =  20; /* PCM Threshold 1 */
+               value[1] =  12; /* PCM Threshold 2 */
+               value[2] = 255; /* Distortion Threshold d7-d0 */
+               value[3] =   0; /* Distortion Threshold d11-d8 */
+               value[4] =  43; /* Max Distortion d7-d0 */
+               value[5] =   0; /* Max Distortion d8 */
        }
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
@@ -2059,10 +1974,7 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
        if (rc < 0) {
                printk(KERN_ERR "%sERROR=%d. USBVISION stopped - "
                       "reconnect or reload driver.\n", proc, rc);
-               return rc;
        }
-
-
        return rc;
 }
 
@@ -2085,9 +1997,9 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
                return 0;
 
        /* Set input format expected from decoder*/
-       if (usbvision_device_data[usbvision->DevModel].Vin_Reg1_override) {
-               value[0] = usbvision_device_data[usbvision->DevModel].Vin_Reg1;
-       } else if(usbvision_device_data[usbvision->DevModel].Codec == CODEC_SAA7113) {
+       if (usbvision_device_data[usbvision->dev_model].vin_reg1_override) {
+               value[0] = usbvision_device_data[usbvision->dev_model].vin_reg1;
+       } else if (usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
                /* SAA7113 uses 8 bit output */
                value[0] = USBVISION_8_422_SYNC;
        } else {
@@ -2105,53 +2017,53 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
        }
 
 
-       if (usbvision->tvnormId & V4L2_STD_PAL) {
+       if (usbvision->tvnorm_id & V4L2_STD_PAL) {
                value[0] = 0xC0;
-               value[1] = 0x02;        //0x02C0 -> 704 Input video line length
+               value[1] = 0x02;        /* 0x02C0 -> 704 Input video line length */
                value[2] = 0x20;
-               value[3] = 0x01;        //0x0120 -> 288 Input video n. of lines
+               value[3] = 0x01;        /* 0x0120 -> 288 Input video n. of lines */
                value[4] = 0x60;
-               value[5] = 0x00;        //0x0060 -> 96 Input video h offset
+               value[5] = 0x00;        /* 0x0060 -> 96 Input video h offset */
                value[6] = 0x16;
-               value[7] = 0x00;        //0x0016 -> 22 Input video v offset
-       } else if (usbvision->tvnormId & V4L2_STD_SECAM) {
+               value[7] = 0x00;        /* 0x0016 -> 22 Input video v offset */
+       } else if (usbvision->tvnorm_id & V4L2_STD_SECAM) {
                value[0] = 0xC0;
-               value[1] = 0x02;        //0x02C0 -> 704 Input video line length
+               value[1] = 0x02;        /* 0x02C0 -> 704 Input video line length */
                value[2] = 0x20;
-               value[3] = 0x01;        //0x0120 -> 288 Input video n. of lines
+               value[3] = 0x01;        /* 0x0120 -> 288 Input video n. of lines */
                value[4] = 0x01;
-               value[5] = 0x00;        //0x0001 -> 01 Input video h offset
+               value[5] = 0x00;        /* 0x0001 -> 01 Input video h offset */
                value[6] = 0x01;
-               value[7] = 0x00;        //0x0001 -> 01 Input video v offset
+               value[7] = 0x00;        /* 0x0001 -> 01 Input video v offset */
        } else {        /* V4L2_STD_NTSC */
                value[0] = 0xD0;
-               value[1] = 0x02;        //0x02D0 -> 720 Input video line length
+               value[1] = 0x02;        /* 0x02D0 -> 720 Input video line length */
                value[2] = 0xF0;
-               value[3] = 0x00;        //0x00F0 -> 240 Input video number of lines
+               value[3] = 0x00;        /* 0x00F0 -> 240 Input video number of lines */
                value[4] = 0x50;
-               value[5] = 0x00;        //0x0050 -> 80 Input video h offset
+               value[5] = 0x00;        /* 0x0050 -> 80 Input video h offset */
                value[6] = 0x10;
-               value[7] = 0x00;        //0x0010 -> 16 Input video v offset
+               value[7] = 0x00;        /* 0x0010 -> 16 Input video v offset */
        }
 
-       if (usbvision_device_data[usbvision->DevModel].X_Offset >= 0) {
-               value[4]=usbvision_device_data[usbvision->DevModel].X_Offset & 0xff;
-               value[5]=(usbvision_device_data[usbvision->DevModel].X_Offset & 0x0300) >> 8;
+       if (usbvision_device_data[usbvision->dev_model].x_offset >= 0) {
+               value[4] = usbvision_device_data[usbvision->dev_model].x_offset & 0xff;
+               value[5] = (usbvision_device_data[usbvision->dev_model].x_offset & 0x0300) >> 8;
        }
 
-       if (adjust_X_Offset != -1) {
-               value[4] = adjust_X_Offset & 0xff;
-               value[5] = (adjust_X_Offset & 0x0300) >> 8;
+       if (adjust_x_offset != -1) {
+               value[4] = adjust_x_offset & 0xff;
+               value[5] = (adjust_x_offset & 0x0300) >> 8;
        }
 
-       if (usbvision_device_data[usbvision->DevModel].Y_Offset >= 0) {
-               value[6]=usbvision_device_data[usbvision->DevModel].Y_Offset & 0xff;
-               value[7]=(usbvision_device_data[usbvision->DevModel].Y_Offset & 0x0300) >> 8;
+       if (usbvision_device_data[usbvision->dev_model].y_offset >= 0) {
+               value[6] = usbvision_device_data[usbvision->dev_model].y_offset & 0xff;
+               value[7] = (usbvision_device_data[usbvision->dev_model].y_offset & 0x0300) >> 8;
        }
 
-       if (adjust_Y_Offset != -1) {
-               value[6] = adjust_Y_Offset & 0xff;
-               value[7] = (adjust_Y_Offset & 0x0300) >> 8;
+       if (adjust_y_offset != -1) {
+               value[6] = adjust_y_offset & 0xff;
+               value[7] = (adjust_y_offset & 0x0300) >> 8;
        }
 
        rc = usb_control_msg(usbvision->dev, usb_sndctrlpipe(usbvision->dev, 1),
@@ -2167,15 +2079,14 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
 
        dvi_yuv_value = 0x00;   /* U comes after V, Ya comes after U/V, Yb comes after Yb */
 
-       if(usbvision_device_data[usbvision->DevModel].Dvi_yuv_override){
-               dvi_yuv_value = usbvision_device_data[usbvision->DevModel].Dvi_yuv;
-       }
-       else if(usbvision_device_data[usbvision->DevModel].Codec == CODEC_SAA7113) {
-       /* This changes as the fine sync control changes. Further investigation necessary */
+       if (usbvision_device_data[usbvision->dev_model].dvi_yuv_override) {
+               dvi_yuv_value = usbvision_device_data[usbvision->dev_model].dvi_yuv;
+       } else if (usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
+               /* This changes as the fine sync control changes. Further investigation necessary */
                dvi_yuv_value = 0x06;
        }
 
-       return (usbvision_write_reg(usbvision, USBVISION_DVI_YUV, dvi_yuv_value));
+       return usbvision_write_reg(usbvision, USBVISION_DVI_YUV, dvi_yuv_value);
 }
 
 
@@ -2192,7 +2103,7 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
        int rc;
        unsigned char value[8];
 
-       if (usbvision->isocMode == ISOC_MODE_COMPRESS) {
+       if (usbvision->isoc_mode == ISOC_MODE_COMPRESS) {
                value[0] = 0x42;
                value[1] = 0x71;
                value[2] = 0xff;
@@ -2201,11 +2112,10 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
                value[5] = 0xe0;
                value[6] = 0x71;
                value[7] = 0xff;
-               // UR:  0x0E200-0x3FFFF = 204288 Words (1 Word = 2 Byte)
-               // FDL: 0x00000-0x0E099 =  57498 Words
-               // VDW: 0x0E3FF-0x3FFFF
-       }
-       else {
+               /* UR:  0x0E200-0x3FFFF = 204288 Words (1 Word = 2 Byte) */
+               /* FDL: 0x00000-0x0E099 =  57498 Words */
+               /* VDW: 0x0E3FF-0x3FFFF */
+       } else {
                value[0] = 0x42;
                value[1] = 0x00;
                value[2] = 0xff;
@@ -2218,14 +2128,14 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
        /* These are the values of the address of the video buffer,
         * they have to be loaded into the USBVISION_DRM_PRM1-8
         *
-        * Start address of video output buffer for read:       drm_prm1-2 -> 0x00000
-        * End address of video output buffer for read:         drm_prm1-3 -> 0x1ffff
-        * Start address of video frame delay buffer:           drm_prm1-4 -> 0x20000
+        * Start address of video output buffer for read:       drm_prm1-2 -> 0x00000
+        * End address of video output buffer for read:         drm_prm1-3 -> 0x1ffff
+        * Start address of video frame delay buffer:           drm_prm1-4 -> 0x20000
         *    Only used in compressed mode
-        * End address of video frame delay buffer:             drm_prm1-5-6 -> 0x3ffff
+        * End address of video frame delay buffer:             drm_prm1-5-6 -> 0x3ffff
         *    Only used in compressed mode
-        * Start address of video output buffer for write:      drm_prm1-7 -> 0x00000
-        * End address of video output buffer for write:        drm_prm1-8 -> 0x1ffff
+        * Start address of video output buffer for write:      drm_prm1-7 -> 0x00000
+        * End address of video output buffer for write:        drm_prm1-8 -> 0x1ffff
         */
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
@@ -2243,8 +2153,9 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
        }
 
        /* Restart the video buffer logic */
-       if ((rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, USBVISION_RES_UR |
-                                  USBVISION_RES_FDL | USBVISION_RES_VDW)) < 0)
+       rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, USBVISION_RES_UR |
+                                  USBVISION_RES_FDL | USBVISION_RES_VDW);
+       if (rc < 0)
                return rc;
        rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, 0x00);
 
@@ -2261,23 +2172,22 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
 
 int usbvision_power_on(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
+       int err_code = 0;
 
        PDEBUG(DBG_FUNC, "");
 
        usbvision_write_reg(usbvision, USBVISION_PWR_REG, USBVISION_SSPND_EN);
        usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                        USBVISION_SSPND_EN | USBVISION_RES2);
+                       USBVISION_SSPND_EN | USBVISION_RES2);
 
        usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                        USBVISION_SSPND_EN | USBVISION_PWR_VID);
-       errCode = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                                               USBVISION_SSPND_EN | USBVISION_PWR_VID | USBVISION_RES2);
-       if (errCode == 1) {
+                       USBVISION_SSPND_EN | USBVISION_PWR_VID);
+       err_code = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
+                       USBVISION_SSPND_EN | USBVISION_PWR_VID | USBVISION_RES2);
+       if (err_code == 1)
                usbvision->power = 1;
-       }
-       PDEBUG(DBG_FUNC, "%s: errCode %d", (errCode<0)?"ERROR":"power is on", errCode);
-       return errCode;
+       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code < 0) ? "ERROR" : "power is on", err_code);
+       return err_code;
 }
 
 
@@ -2285,53 +2195,50 @@ int usbvision_power_on(struct usb_usbvision *usbvision)
  * usbvision timer stuff
  */
 
-// to call usbvision_power_off from task queue
+/* to call usbvision_power_off from task queue */
 static void call_usbvision_power_off(struct work_struct *work)
 {
-       struct usb_usbvision *usbvision = container_of(work, struct usb_usbvision, powerOffWork);
+       struct usb_usbvision *usbvision = container_of(work, struct usb_usbvision, power_off_work);
 
        PDEBUG(DBG_FUNC, "");
-       if(mutex_lock_interruptible(&usbvision->lock)) {
+       if (mutex_lock_interruptible(&usbvision->v4l2_lock))
                return;
-       }
 
-
-       if(usbvision->user == 0) {
+       if (usbvision->user == 0) {
                usbvision_i2c_unregister(usbvision);
 
                usbvision_power_off(usbvision);
                usbvision->initialized = 0;
        }
-       mutex_unlock(&usbvision->lock);
+       mutex_unlock(&usbvision->v4l2_lock);
 }
 
-static void usbvision_powerOffTimer(unsigned long data)
+static void usbvision_power_off_timer(unsigned long data)
 {
-       struct usb_usbvision *usbvision = (void *) data;
+       struct usb_usbvision *usbvision = (void *)data;
 
        PDEBUG(DBG_FUNC, "");
-       del_timer(&usbvision->powerOffTimer);
-       INIT_WORK(&usbvision->powerOffWork, call_usbvision_power_off);
-       (void) schedule_work(&usbvision->powerOffWork);
+       del_timer(&usbvision->power_off_timer);
+       INIT_WORK(&usbvision->power_off_work, call_usbvision_power_off);
+       (void) schedule_work(&usbvision->power_off_work);
 }
 
-void usbvision_init_powerOffTimer(struct usb_usbvision *usbvision)
+void usbvision_init_power_off_timer(struct usb_usbvision *usbvision)
 {
-       init_timer(&usbvision->powerOffTimer);
-       usbvision->powerOffTimer.data = (long) usbvision;
-       usbvision->powerOffTimer.function = usbvision_powerOffTimer;
+       init_timer(&usbvision->power_off_timer);
+       usbvision->power_off_timer.data = (long)usbvision;
+       usbvision->power_off_timer.function = usbvision_power_off_timer;
 }
 
-void usbvision_set_powerOffTimer(struct usb_usbvision *usbvision)
+void usbvision_set_power_off_timer(struct usb_usbvision *usbvision)
 {
-       mod_timer(&usbvision->powerOffTimer, jiffies + USBVISION_POWEROFF_TIME);
+       mod_timer(&usbvision->power_off_timer, jiffies + USBVISION_POWEROFF_TIME);
 }
 
-void usbvision_reset_powerOffTimer(struct usb_usbvision *usbvision)
+void usbvision_reset_power_off_timer(struct usb_usbvision *usbvision)
 {
-       if (timer_pending(&usbvision->powerOffTimer)) {
-               del_timer(&usbvision->powerOffTimer);
-       }
+       if (timer_pending(&usbvision->power_off_timer))
+               del_timer(&usbvision->power_off_timer);
 }
 
 /*
@@ -2341,14 +2248,10 @@ void usbvision_reset_powerOffTimer(struct usb_usbvision *usbvision)
  */
 int usbvision_begin_streaming(struct usb_usbvision *usbvision)
 {
-       int errCode = 0;
-
-       if (usbvision->isocMode == ISOC_MODE_COMPRESS) {
+       if (usbvision->isoc_mode == ISOC_MODE_COMPRESS)
                usbvision_init_compression(usbvision);
-       }
-       errCode = usbvision_write_reg(usbvision, USBVISION_VIN_REG2, USBVISION_NOHVALID |
-                                                                               usbvision->Vin_Reg2_Preset);
-       return errCode;
+       return usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
+               USBVISION_NOHVALID | usbvision->vin_reg2_preset);
 }
 
 /*
@@ -2360,25 +2263,24 @@ int usbvision_restart_isoc(struct usb_usbvision *usbvision)
 {
        int ret;
 
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                             USBVISION_SSPND_EN | USBVISION_PWR_VID)) < 0)
+       ret = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
+                             USBVISION_SSPND_EN | USBVISION_PWR_VID);
+       if (ret < 0)
                return ret;
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_PWR_REG,
+       ret = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
                              USBVISION_SSPND_EN | USBVISION_PWR_VID |
-                             USBVISION_RES2)) < 0)
+                             USBVISION_RES2);
+       if (ret < 0)
                return ret;
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
+       ret = usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
                              USBVISION_KEEP_BLANK | USBVISION_NOHVALID |
-                                 usbvision->Vin_Reg2_Preset)) < 0) return ret;
+                                 usbvision->vin_reg2_preset);
+       if (ret < 0)
+               return ret;
 
        /* TODO: schedule timeout */
-       while ((usbvision_read_reg(usbvision, USBVISION_STATUS_REG) & 0x01) != 1);
+       while ((usbvision_read_reg(usbvision, USBVISION_STATUS_REG) & 0x01) != 1)
+               ;
 
        return 0;
 }
@@ -2386,27 +2288,27 @@ int usbvision_restart_isoc(struct usb_usbvision *usbvision)
 int usbvision_audio_off(struct usb_usbvision *usbvision)
 {
        if (usbvision_write_reg(usbvision, USBVISION_IOPIN_REG, USBVISION_AUDIO_MUTE) < 0) {
-               printk(KERN_ERR "usbvision_audio_off: can't wirte reg\n");
+               printk(KERN_ERR "usbvision_audio_off: can't write reg\n");
                return -1;
        }
-       usbvision->AudioMute = 0;
-       usbvision->AudioChannel = USBVISION_AUDIO_MUTE;
+       usbvision->audio_mute = 0;
+       usbvision->audio_channel = USBVISION_AUDIO_MUTE;
        return 0;
 }
 
-int usbvision_set_audio(struct usb_usbvision *usbvision, int AudioChannel)
+int usbvision_set_audio(struct usb_usbvision *usbvision, int audio_channel)
 {
-       if (!usbvision->AudioMute) {
-               if (usbvision_write_reg(usbvision, USBVISION_IOPIN_REG, AudioChannel) < 0) {
+       if (!usbvision->audio_mute) {
+               if (usbvision_write_reg(usbvision, USBVISION_IOPIN_REG, audio_channel) < 0) {
                        printk(KERN_ERR "usbvision_set_audio: can't write iopin register for audio switching\n");
                        return -1;
                }
        }
-       usbvision->AudioChannel = AudioChannel;
+       usbvision->audio_channel = audio_channel;
        return 0;
 }
 
-int usbvision_setup(struct usb_usbvision *usbvision,int format)
+int usbvision_setup(struct usb_usbvision *usbvision, int format)
 {
        usbvision_set_video_format(usbvision, format);
        usbvision_set_dram_settings(usbvision);
@@ -2421,27 +2323,28 @@ int usbvision_setup(struct usb_usbvision *usbvision,int format)
 
 int usbvision_set_alternate(struct usb_usbvision *dev)
 {
-       int errCode, prev_alt = dev->ifaceAlt;
+       int err_code, prev_alt = dev->iface_alt;
        int i;
 
-       dev->ifaceAlt=0;
-       for(i=0;i< dev->num_alt; i++)
-               if(dev->alt_max_pkt_size[i]>dev->alt_max_pkt_size[dev->ifaceAlt])
-                       dev->ifaceAlt=i;
-
-       if (dev->ifaceAlt != prev_alt) {
-               dev->isocPacketSize = dev->alt_max_pkt_size[dev->ifaceAlt];
-               PDEBUG(DBG_FUNC,"setting alternate %d with wMaxPacketSize=%u", dev->ifaceAlt,dev->isocPacketSize);
-               errCode = usb_set_interface(dev->dev, dev->iface, dev->ifaceAlt);
-               if (errCode < 0) {
+       dev->iface_alt = 0;
+       for (i = 0; i < dev->num_alt; i++)
+               if (dev->alt_max_pkt_size[i] > dev->alt_max_pkt_size[dev->iface_alt])
+                       dev->iface_alt = i;
+
+       if (dev->iface_alt != prev_alt) {
+               dev->isoc_packet_size = dev->alt_max_pkt_size[dev->iface_alt];
+               PDEBUG(DBG_FUNC, "setting alternate %d with max_packet_size=%u",
+                               dev->iface_alt, dev->isoc_packet_size);
+               err_code = usb_set_interface(dev->dev, dev->iface, dev->iface_alt);
+               if (err_code < 0) {
                        dev_err(&dev->dev->dev,
                                "cannot change alternate number to %d (error=%i)\n",
-                                       dev->ifaceAlt, errCode);
-                       return errCode;
+                                       dev->iface_alt, err_code);
+                       return err_code;
                }
        }
 
-       PDEBUG(DBG_ISOC, "ISO Packet Length:%d", dev->isocPacketSize);
+       PDEBUG(DBG_ISOC, "ISO Packet Length:%d", dev->isoc_packet_size);
 
        return 0;
 }
@@ -2453,27 +2356,27 @@ int usbvision_set_alternate(struct usb_usbvision *dev)
 int usbvision_init_isoc(struct usb_usbvision *usbvision)
 {
        struct usb_device *dev = usbvision->dev;
-       int bufIdx, errCode, regValue;
+       int buf_idx, err_code, reg_value;
        int sb_size;
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
                return -EFAULT;
 
-       usbvision->curFrame = NULL;
+       usbvision->cur_frame = NULL;
        scratch_reset(usbvision);
 
        /* Alternate interface 1 is is the biggest frame size */
-       errCode = usbvision_set_alternate(usbvision);
-       if (errCode < 0) {
-               usbvision->last_error = errCode;
+       err_code = usbvision_set_alternate(usbvision);
+       if (err_code < 0) {
+               usbvision->last_error = err_code;
                return -EBUSY;
        }
-       sb_size = USBVISION_URB_FRAMES * usbvision->isocPacketSize;
+       sb_size = USBVISION_URB_FRAMES * usbvision->isoc_packet_size;
 
-       regValue = (16 - usbvision_read_reg(usbvision,
+       reg_value = (16 - usbvision_read_reg(usbvision,
                                            USBVISION_ALTER_REG)) & 0x0F;
 
-       usbvision->usb_bandwidth = regValue >> 1;
+       usbvision->usb_bandwidth = reg_value >> 1;
        PDEBUG(DBG_ISOC, "USB Bandwidth Usage: %dMbit/Sec",
               usbvision->usb_bandwidth);
 
@@ -2481,7 +2384,7 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
 
        /* We double buffer the Iso lists */
 
-       for (bufIdx = 0; bufIdx < USBVISION_NUMSBUF; bufIdx++) {
+       for (buf_idx = 0; buf_idx < USBVISION_NUMSBUF; buf_idx++) {
                int j, k;
                struct urb *urb;
 
@@ -2491,8 +2394,8 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
                                "%s: usb_alloc_urb() failed\n", __func__);
                        return -ENOMEM;
                }
-               usbvision->sbuf[bufIdx].urb = urb;
-               usbvision->sbuf[bufIdx].data =
+               usbvision->sbuf[buf_idx].urb = urb;
+               usbvision->sbuf[buf_idx].data =
                        usb_alloc_coherent(usbvision->dev,
                                           sb_size,
                                           GFP_KERNEL,
@@ -2502,31 +2405,31 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
                urb->pipe = usb_rcvisocpipe(dev, usbvision->video_endp);
                urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP;
                urb->interval = 1;
-               urb->transfer_buffer = usbvision->sbuf[bufIdx].data;
-               urb->complete = usbvision_isocIrq;
+               urb->transfer_buffer = usbvision->sbuf[buf_idx].data;
+               urb->complete = usbvision_isoc_irq;
                urb->number_of_packets = USBVISION_URB_FRAMES;
                urb->transfer_buffer_length =
-                   usbvision->isocPacketSize * USBVISION_URB_FRAMES;
+                   usbvision->isoc_packet_size * USBVISION_URB_FRAMES;
                for (j = k = 0; j < USBVISION_URB_FRAMES; j++,
-                    k += usbvision->isocPacketSize) {
+                    k += usbvision->isoc_packet_size) {
                        urb->iso_frame_desc[j].offset = k;
                        urb->iso_frame_desc[j].length =
-                               usbvision->isocPacketSize;
+                               usbvision->isoc_packet_size;
                }
        }
 
        /* Submit all URBs */
-       for (bufIdx = 0; bufIdx < USBVISION_NUMSBUF; bufIdx++) {
-                       errCode = usb_submit_urb(usbvision->sbuf[bufIdx].urb,
+       for (buf_idx = 0; buf_idx < USBVISION_NUMSBUF; buf_idx++) {
+                       err_code = usb_submit_urb(usbvision->sbuf[buf_idx].urb,
                                                 GFP_KERNEL);
-               if (errCode) {
+               if (err_code) {
                        dev_err(&usbvision->dev->dev,
                                "%s: usb_submit_urb(%d) failed: error %d\n",
-                                       __func__, bufIdx, errCode);
+                                       __func__, buf_idx, err_code);
                }
        }
 
-       usbvision->streaming = Stream_Idle;
+       usbvision->streaming = stream_idle;
        PDEBUG(DBG_ISOC, "%s: streaming=1 usbvision->video_endp=$%02x",
               __func__,
               usbvision->video_endp);
@@ -2542,47 +2445,46 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
  */
 void usbvision_stop_isoc(struct usb_usbvision *usbvision)
 {
-       int bufIdx, errCode, regValue;
-       int sb_size = USBVISION_URB_FRAMES * usbvision->isocPacketSize;
+       int buf_idx, err_code, reg_value;
+       int sb_size = USBVISION_URB_FRAMES * usbvision->isoc_packet_size;
 
-       if ((usbvision->streaming == Stream_Off) || (usbvision->dev == NULL))
+       if ((usbvision->streaming == stream_off) || (usbvision->dev == NULL))
                return;
 
        /* Unschedule all of the iso td's */
-       for (bufIdx = 0; bufIdx < USBVISION_NUMSBUF; bufIdx++) {
-               usb_kill_urb(usbvision->sbuf[bufIdx].urb);
-               if (usbvision->sbuf[bufIdx].data){
+       for (buf_idx = 0; buf_idx < USBVISION_NUMSBUF; buf_idx++) {
+               usb_kill_urb(usbvision->sbuf[buf_idx].urb);
+               if (usbvision->sbuf[buf_idx].data) {
                        usb_free_coherent(usbvision->dev,
                                          sb_size,
-                                         usbvision->sbuf[bufIdx].data,
-                                         usbvision->sbuf[bufIdx].urb->transfer_dma);
+                                         usbvision->sbuf[buf_idx].data,
+                                         usbvision->sbuf[buf_idx].urb->transfer_dma);
                }
-               usb_free_urb(usbvision->sbuf[bufIdx].urb);
-               usbvision->sbuf[bufIdx].urb = NULL;
+               usb_free_urb(usbvision->sbuf[buf_idx].urb);
+               usbvision->sbuf[buf_idx].urb = NULL;
        }
 
-       PDEBUG(DBG_ISOC, "%s: streaming=Stream_Off\n", __func__);
-       usbvision->streaming = Stream_Off;
+       PDEBUG(DBG_ISOC, "%s: streaming=stream_off\n", __func__);
+       usbvision->streaming = stream_off;
 
        if (!usbvision->remove_pending) {
-
                /* Set packet size to 0 */
-               usbvision->ifaceAlt=0;
-               errCode = usb_set_interface(usbvision->dev, usbvision->iface,
-                                           usbvision->ifaceAlt);
-               if (errCode < 0) {
+               usbvision->iface_alt = 0;
+               err_code = usb_set_interface(usbvision->dev, usbvision->iface,
+                                           usbvision->iface_alt);
+               if (err_code < 0) {
                        dev_err(&usbvision->dev->dev,
                                "%s: usb_set_interface() failed: error %d\n",
-                                       __func__, errCode);
-                       usbvision->last_error = errCode;
+                                       __func__, err_code);
+                       usbvision->last_error = err_code;
                }
-               regValue = (16-usbvision_read_reg(usbvision, USBVISION_ALTER_REG)) & 0x0F;
-               usbvision->isocPacketSize =
-                       (regValue == 0) ? 0 : (regValue * 64) - 1;
+               reg_value = (16-usbvision_read_reg(usbvision, USBVISION_ALTER_REG)) & 0x0F;
+               usbvision->isoc_packet_size =
+                       (reg_value == 0) ? 0 : (reg_value * 64) - 1;
                PDEBUG(DBG_ISOC, "ISO Packet Length:%d",
-                      usbvision->isocPacketSize);
+                      usbvision->isoc_packet_size);
 
-               usbvision->usb_bandwidth = regValue >> 1;
+               usbvision->usb_bandwidth = reg_value >> 1;
                PDEBUG(DBG_ISOC, "USB Bandwidth Usage: %dMbit/Sec",
                       usbvision->usb_bandwidth);
        }
@@ -2592,39 +2494,38 @@ int usbvision_muxsel(struct usb_usbvision *usbvision, int channel)
 {
        /* inputs #0 and #3 are constant for every SAA711x. */
        /* inputs #1 and #2 are variable for SAA7111 and SAA7113 */
-       int mode[4]= {SAA7115_COMPOSITE0, 0, 0, SAA7115_COMPOSITE3};
-       int audio[]= {1, 0, 0, 0};
-       //channel 0 is TV with audiochannel 1 (tuner mono)
-       //channel 1 is Composite with audio channel 0 (line in)
-       //channel 2 is S-Video with audio channel 0 (line in)
-       //channel 3 is additional video inputs to the device with audio channel 0 (line in)
+       int mode[4] = { SAA7115_COMPOSITE0, 0, 0, SAA7115_COMPOSITE3 };
+       int audio[] = { 1, 0, 0, 0 };
+       /* channel 0 is TV with audiochannel 1 (tuner mono) */
+       /* channel 1 is Composite with audio channel 0 (line in) */
+       /* channel 2 is S-Video with audio channel 0 (line in) */
+       /* channel 3 is additional video inputs to the device with audio channel 0 (line in) */
 
        RESTRICT_TO_RANGE(channel, 0, usbvision->video_inputs);
        usbvision->ctl_input = channel;
 
-       // set the new channel
-       // Regular USB TV Tuners -> channel: 0 = Television, 1 = Composite, 2 = S-Video
-       // Four video input devices -> channel: 0 = Chan White, 1 = Chan Green, 2 = Chan Yellow, 3 = Chan Red
-
-       switch (usbvision_device_data[usbvision->DevModel].Codec) {
-               case CODEC_SAA7113:
-                       mode[1] = SAA7115_COMPOSITE2;
-                       if (SwitchSVideoInput) {
-                               /* To handle problems with S-Video Input for
-                                * some devices.  Use SwitchSVideoInput
-                                * parameter when loading the module.*/
-                               mode[2] = SAA7115_COMPOSITE1;
-                       }
-                       else {
-                               mode[2] = SAA7115_SVIDEO1;
-                       }
-                       break;
-               case CODEC_SAA7111:
-               default:
-                       /* modes for saa7111 */
-                       mode[1] = SAA7115_COMPOSITE1;
+       /* set the new channel */
+       /* Regular USB TV Tuners -> channel: 0 = Television, 1 = Composite, 2 = S-Video */
+       /* Four video input devices -> channel: 0 = Chan White, 1 = Chan Green, 2 = Chan Yellow, 3 = Chan Red */
+
+       switch (usbvision_device_data[usbvision->dev_model].codec) {
+       case CODEC_SAA7113:
+               mode[1] = SAA7115_COMPOSITE2;
+               if (switch_svideo_input) {
+                       /* To handle problems with S-Video Input for
+                        * some devices.  Use switch_svideo_input
+                        * parameter when loading the module.*/
+                       mode[2] = SAA7115_COMPOSITE1;
+               } else {
                        mode[2] = SAA7115_SVIDEO1;
-                       break;
+               }
+               break;
+       case CODEC_SAA7111:
+       default:
+               /* modes for saa7111 */
+               mode[1] = SAA7115_COMPOSITE1;
+               mode[2] = SAA7115_SVIDEO1;
+               break;
        }
        call_all(usbvision, video, s_routing, mode[channel], 0, 0);
        usbvision_set_audio(usbvision, audio[channel]);