]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/staging/hv/ring_buffer.c
Merge tag 'v2.6.38' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6
[mv-sheeva.git] / drivers / staging / hv / ring_buffer.c
index d78c569ac94a2aa7ae4ba6b2325dbf6d2b93c45c..4d53392f1e605ad97701588e4abc45886a926215 100644 (file)
@@ -38,7 +38,7 @@
 /*++
 
 Name:
-       GetRingBufferAvailBytes()
+       get_ringbuffer_availbytes()
 
 Description:
        Get number of bytes available to read and to write to
@@ -46,33 +46,34 @@ Description:
 
 --*/
 static inline void
-GetRingBufferAvailBytes(struct hv_ring_buffer_info *rbi, u32 *read, u32 *write)
+get_ringbuffer_availbytes(struct hv_ring_buffer_info *rbi,
+                         u32 *read, u32 *write)
 {
        u32 read_loc, write_loc;
 
        /* Capture the read/write indices before they changed */
-       read_loc = rbi->RingBuffer->ReadIndex;
-       write_loc = rbi->RingBuffer->WriteIndex;
+       read_loc = rbi->ring_buffer->read_index;
+       write_loc = rbi->ring_buffer->write_index;
 
-       *write = BYTES_AVAIL_TO_WRITE(read_loc, write_loc, rbi->RingDataSize);
-       *read = rbi->RingDataSize - *write;
+       *write = BYTES_AVAIL_TO_WRITE(read_loc, write_loc, rbi->ring_datasize);
+       *read = rbi->ring_datasize - *write;
 }
 
 /*++
 
 Name:
-       GetNextWriteLocation()
+       get_next_write_location()
 
 Description:
        Get the next write location for the specified ring buffer
 
 --*/
 static inline u32
-GetNextWriteLocation(struct hv_ring_buffer_info *RingInfo)
+get_next_write_location(struct hv_ring_buffer_info *ring_info)
 {
-       u32 next = RingInfo->RingBuffer->WriteIndex;
+       u32 next = ring_info->ring_buffer->write_index;
 
-       /* ASSERT(next < RingInfo->RingDataSize); */
+       /* ASSERT(next < ring_info->RingDataSize); */
 
        return next;
 }
@@ -80,34 +81,34 @@ GetNextWriteLocation(struct hv_ring_buffer_info *RingInfo)
 /*++
 
 Name:
-       SetNextWriteLocation()
+       set_next_write_location()
 
 Description:
        Set the next write location for the specified ring buffer
 
 --*/
 static inline void
-SetNextWriteLocation(struct hv_ring_buffer_info *RingInfo,
-                    u32 NextWriteLocation)
+set_next_write_location(struct hv_ring_buffer_info *ring_info,
+                    u32 next_write_location)
 {
-       RingInfo->RingBuffer->WriteIndex = NextWriteLocation;
+       ring_info->ring_buffer->write_index = next_write_location;
 }
 
 /*++
 
 Name:
-       GetNextReadLocation()
+       get_next_read_location()
 
 Description:
        Get the next read location for the specified ring buffer
 
 --*/
 static inline u32
-GetNextReadLocation(struct hv_ring_buffer_info *RingInfo)
+get_next_read_location(struct hv_ring_buffer_info *ring_info)
 {
-       u32 next = RingInfo->RingBuffer->ReadIndex;
+       u32 next = ring_info->ring_buffer->read_index;
 
-       /* ASSERT(next < RingInfo->RingDataSize); */
+       /* ASSERT(next < ring_info->RingDataSize); */
 
        return next;
 }
@@ -115,7 +116,7 @@ GetNextReadLocation(struct hv_ring_buffer_info *RingInfo)
 /*++
 
 Name:
-       GetNextReadLocationWithOffset()
+       get_next_readlocation_withoffset()
 
 Description:
        Get the next read location + offset for the specified ring buffer.
@@ -123,13 +124,14 @@ Description:
 
 --*/
 static inline u32
-GetNextReadLocationWithOffset(struct hv_ring_buffer_info *RingInfo, u32 Offset)
+get_next_readlocation_withoffset(struct hv_ring_buffer_info *ring_info,
+                                u32 offset)
 {
-       u32 next = RingInfo->RingBuffer->ReadIndex;
+       u32 next = ring_info->ring_buffer->read_index;
 
-       /* ASSERT(next < RingInfo->RingDataSize); */
-       next += Offset;
-       next %= RingInfo->RingDataSize;
+       /* ASSERT(next < ring_info->RingDataSize); */
+       next += offset;
+       next %= ring_info->ring_datasize;
 
        return next;
 }
@@ -137,141 +139,145 @@ GetNextReadLocationWithOffset(struct hv_ring_buffer_info *RingInfo, u32 Offset)
 /*++
 
 Name:
-       SetNextReadLocation()
+       set_next_read_location()
 
 Description:
        Set the next read location for the specified ring buffer
 
 --*/
 static inline void
-SetNextReadLocation(struct hv_ring_buffer_info *RingInfo, u32 NextReadLocation)
+set_next_read_location(struct hv_ring_buffer_info *ring_info,
+                   u32 next_read_location)
 {
-       RingInfo->RingBuffer->ReadIndex = NextReadLocation;
+       ring_info->ring_buffer->read_index = next_read_location;
 }
 
 
 /*++
 
 Name:
-       GetRingBuffer()
+       get_ring_buffer()
 
 Description:
        Get the start of the ring buffer
 
 --*/
 static inline void *
-GetRingBuffer(struct hv_ring_buffer_info *RingInfo)
+get_ring_buffer(struct hv_ring_buffer_info *ring_info)
 {
-       return (void *)RingInfo->RingBuffer->Buffer;
+       return (void *)ring_info->ring_buffer->buffer;
 }
 
 
 /*++
 
 Name:
-       GetRingBufferSize()
+       get_ring_buffersize()
 
 Description:
        Get the size of the ring buffer
 
 --*/
 static inline u32
-GetRingBufferSize(struct hv_ring_buffer_info *RingInfo)
+get_ring_buffersize(struct hv_ring_buffer_info *ring_info)
 {
-       return RingInfo->RingDataSize;
+       return ring_info->ring_datasize;
 }
 
 /*++
 
 Name:
-       GetRingBufferIndices()
+       get_ring_bufferindices()
 
 Description:
        Get the read and write indices as u64 of the specified ring buffer
 
 --*/
 static inline u64
-GetRingBufferIndices(struct hv_ring_buffer_info *RingInfo)
+get_ring_bufferindices(struct hv_ring_buffer_info *ring_info)
 {
-       return (u64)RingInfo->RingBuffer->WriteIndex << 32;
+       return (u64)ring_info->ring_buffer->write_index << 32;
 }
 
 
 /*++
 
 Name:
-       DumpRingInfo()
+       dump_ring_info()
 
 Description:
        Dump out to console the ring buffer info
 
 --*/
-void DumpRingInfo(struct hv_ring_buffer_info *RingInfo, char *Prefix)
+void dump_ring_info(struct hv_ring_buffer_info *ring_info, char *prefix)
 {
-       u32 bytesAvailToWrite;
-       u32 bytesAvailToRead;
+       u32 bytes_avail_towrite;
+       u32 bytes_avail_toread;
 
-       GetRingBufferAvailBytes(RingInfo,
-       &bytesAvailToRead,
-       &bytesAvailToWrite);
+       get_ringbuffer_availbytes(ring_info,
+       &bytes_avail_toread,
+       &bytes_avail_towrite);
 
        DPRINT(VMBUS,
                DEBUG_RING_LVL,
                "%s <<ringinfo %p buffer %p avail write %u "
                "avail read %u read idx %u write idx %u>>",
-               Prefix,
-               RingInfo,
-               RingInfo->RingBuffer->Buffer,
-               bytesAvailToWrite,
-               bytesAvailToRead,
-               RingInfo->RingBuffer->ReadIndex,
-               RingInfo->RingBuffer->WriteIndex);
+               prefix,
+               ring_info,
+               ring_info->ring_buffer->buffer,
+               bytes_avail_towrite,
+               bytes_avail_toread,
+               ring_info->ring_buffer->read_index,
+               ring_info->ring_buffer->write_index);
 }
 
 
 /* Internal routines */
 
 static u32
-CopyToRingBuffer(
-       struct hv_ring_buffer_info      *RingInfo,
-       u32                             StartWriteOffset,
-       void                            *Src,
-       u32                             SrcLen);
+copyto_ringbuffer(
+       struct hv_ring_buffer_info      *ring_info,
+       u32                             start_write_offset,
+       void                            *src,
+       u32                             srclen);
 
 static u32
-CopyFromRingBuffer(
-       struct hv_ring_buffer_info      *RingInfo,
-       void                            *Dest,
-       u32                             DestLen,
-       u32                             StartReadOffset);
+copyfrom_ringbuffer(
+       struct hv_ring_buffer_info      *ring_info,
+       void                            *dest,
+       u32                             destlen,
+       u32                             start_read_offset);
 
 
 
 /*++
 
 Name:
-       RingBufferGetDebugInfo()
+       ringbuffer_get_debuginfo()
 
 Description:
        Get various debug metrics for the specified ring buffer
 
 --*/
-void RingBufferGetDebugInfo(struct hv_ring_buffer_info *RingInfo,
+void ringbuffer_get_debuginfo(struct hv_ring_buffer_info *ring_info,
                            struct hv_ring_buffer_debug_info *debug_info)
 {
-       u32 bytesAvailToWrite;
-       u32 bytesAvailToRead;
-
-       if (RingInfo->RingBuffer) {
-               GetRingBufferAvailBytes(RingInfo,
-                                       &bytesAvailToRead,
-                                       &bytesAvailToWrite);
-
-               debug_info->BytesAvailToRead = bytesAvailToRead;
-               debug_info->BytesAvailToWrite = bytesAvailToWrite;
-               debug_info->CurrentReadIndex = RingInfo->RingBuffer->ReadIndex;
-               debug_info->CurrentWriteIndex = RingInfo->RingBuffer->WriteIndex;
-               debug_info->CurrentInterruptMask = RingInfo->RingBuffer->InterruptMask;
+       u32 bytes_avail_towrite;
+       u32 bytes_avail_toread;
+
+       if (ring_info->ring_buffer) {
+               get_ringbuffer_availbytes(ring_info,
+                                       &bytes_avail_toread,
+                                       &bytes_avail_towrite);
+
+               debug_info->bytes_avail_toread = bytes_avail_toread;
+               debug_info->bytes_avail_towrite = bytes_avail_towrite;
+               debug_info->current_read_index =
+                       ring_info->ring_buffer->read_index;
+               debug_info->current_write_index =
+                       ring_info->ring_buffer->write_index;
+               debug_info->current_interrupt_mask =
+                       ring_info->ring_buffer->interrupt_mask;
        }
 }
 
@@ -279,40 +285,42 @@ void RingBufferGetDebugInfo(struct hv_ring_buffer_info *RingInfo,
 /*++
 
 Name:
-       GetRingBufferInterruptMask()
+       get_ringbuffer_interrupt_mask()
 
 Description:
        Get the interrupt mask for the specified ring buffer
 
 --*/
-u32 GetRingBufferInterruptMask(struct hv_ring_buffer_info *rbi)
+u32 get_ringbuffer_interrupt_mask(struct hv_ring_buffer_info *rbi)
 {
-       return rbi->RingBuffer->InterruptMask;
+       return rbi->ring_buffer->interrupt_mask;
 }
 
 /*++
 
 Name:
-       RingBufferInit()
+       ringbuffer_init()
 
 Description:
        Initialize the ring buffer
 
 --*/
-int RingBufferInit(struct hv_ring_buffer_info *RingInfo, void *Buffer, u32 BufferLen)
+int ringbuffer_init(struct hv_ring_buffer_info *ring_info,
+                  void *buffer, u32 buflen)
 {
        if (sizeof(struct hv_ring_buffer) != PAGE_SIZE)
                return -EINVAL;
 
-       memset(RingInfo, 0, sizeof(struct hv_ring_buffer_info));
+       memset(ring_info, 0, sizeof(struct hv_ring_buffer_info));
 
-       RingInfo->RingBuffer = (struct hv_ring_buffer *)Buffer;
-       RingInfo->RingBuffer->ReadIndex = RingInfo->RingBuffer->WriteIndex = 0;
+       ring_info->ring_buffer = (struct hv_ring_buffer *)buffer;
+       ring_info->ring_buffer->read_index =
+               ring_info->ring_buffer->write_index = 0;
 
-       RingInfo->RingSize = BufferLen;
-       RingInfo->RingDataSize = BufferLen - sizeof(struct hv_ring_buffer);
+       ring_info->ring_size = buflen;
+       ring_info->ring_datasize = buflen - sizeof(struct hv_ring_buffer);
 
-       spin_lock_init(&RingInfo->ring_lock);
+       spin_lock_init(&ring_info->ring_lock);
 
        return 0;
 }
@@ -320,97 +328,97 @@ int RingBufferInit(struct hv_ring_buffer_info *RingInfo, void *Buffer, u32 Buffe
 /*++
 
 Name:
-       RingBufferCleanup()
+       ringbuffer_cleanup()
 
 Description:
        Cleanup the ring buffer
 
 --*/
-void RingBufferCleanup(struct hv_ring_buffer_info *RingInfo)
+void ringbuffer_cleanup(struct hv_ring_buffer_info *ring_info)
 {
 }
 
 /*++
 
 Name:
-       RingBufferWrite()
+       ringbuffer_write()
 
 Description:
        Write to the ring buffer
 
 --*/
-int RingBufferWrite(struct hv_ring_buffer_info *OutRingInfo,
+int ringbuffer_write(struct hv_ring_buffer_info *outring_info,
                    struct scatterlist *sglist, u32 sgcount)
 {
        int i = 0;
-       u32 byteAvailToWrite;
-       u32 byteAvailToRead;
-       u32 totalBytesToWrite = 0;
+       u32 bytes_avail_towrite;
+       u32 bytes_avail_toread;
+       u32 totalbytes_towrite = 0;
 
        struct scatterlist *sg;
-       volatile u32 nextWriteLocation;
-       u64 prevIndices = 0;
+       volatile u32 next_write_location;
+       u64 prev_indices = 0;
        unsigned long flags;
 
        for_each_sg(sglist, sg, sgcount, i)
        {
-               totalBytesToWrite += sg->length;
+               totalbytes_towrite += sg->length;
        }
 
-       totalBytesToWrite += sizeof(u64);
+       totalbytes_towrite += sizeof(u64);
 
-       spin_lock_irqsave(&OutRingInfo->ring_lock, flags);
+       spin_lock_irqsave(&outring_info->ring_lock, flags);
 
-       GetRingBufferAvailBytes(OutRingInfo,
-                               &byteAvailToRead,
-                               &byteAvailToWrite);
+       get_ringbuffer_availbytes(outring_info,
+                               &bytes_avail_toread,
+                               &bytes_avail_towrite);
 
-       DPRINT_DBG(VMBUS, "Writing %u bytes...", totalBytesToWrite);
+       DPRINT_DBG(VMBUS, "Writing %u bytes...", totalbytes_towrite);
 
-       /* DumpRingInfo(OutRingInfo, "BEFORE "); */
+       /* Dumpring_info(Outring_info, "BEFORE "); */
 
        /* If there is only room for the packet, assume it is full. */
        /* Otherwise, the next time around, we think the ring buffer */
        /* is empty since the read index == write index */
-       if (byteAvailToWrite <= totalBytesToWrite) {
+       if (bytes_avail_towrite <= totalbytes_towrite) {
                DPRINT_DBG(VMBUS,
                        "No more space left on outbound ring buffer "
                        "(needed %u, avail %u)",
-                       totalBytesToWrite,
-                       byteAvailToWrite);
+                       totalbytes_towrite,
+                       bytes_avail_towrite);
 
-               spin_unlock_irqrestore(&OutRingInfo->ring_lock, flags);
+               spin_unlock_irqrestore(&outring_info->ring_lock, flags);
                return -1;
        }
 
        /* Write to the ring buffer */
-       nextWriteLocation = GetNextWriteLocation(OutRingInfo);
+       next_write_location = get_next_write_location(outring_info);
 
        for_each_sg(sglist, sg, sgcount, i)
        {
-               nextWriteLocation = CopyToRingBuffer(OutRingInfo,
-                                                    nextWriteLocation,
+               next_write_location = copyto_ringbuffer(outring_info,
+                                                    next_write_location,
                                                     sg_virt(sg),
                                                     sg->length);
        }
 
        /* Set previous packet start */
-       prevIndices = GetRingBufferIndices(OutRingInfo);
+       prev_indices = get_ring_bufferindices(outring_info);
 
-       nextWriteLocation = CopyToRingBuffer(OutRingInfo,
-                                            nextWriteLocation,
-                                            &prevIndices,
+       next_write_location = copyto_ringbuffer(outring_info,
+                                            next_write_location,
+                                            &prev_indices,
                                             sizeof(u64));
 
        /* Make sure we flush all writes before updating the writeIndex */
        mb();
 
        /* Now, update the write location */
-       SetNextWriteLocation(OutRingInfo, nextWriteLocation);
+       set_next_write_location(outring_info, next_write_location);
 
-       /* DumpRingInfo(OutRingInfo, "AFTER "); */
+       /* Dumpring_info(Outring_info, "AFTER "); */
 
-       spin_unlock_irqrestore(&OutRingInfo->ring_lock, flags);
+       spin_unlock_irqrestore(&outring_info->ring_lock, flags);
        return 0;
 }
 
@@ -418,47 +426,48 @@ int RingBufferWrite(struct hv_ring_buffer_info *OutRingInfo,
 /*++
 
 Name:
-       RingBufferPeek()
+       ringbuffer_peek()
 
 Description:
        Read without advancing the read index
 
 --*/
-int RingBufferPeek(struct hv_ring_buffer_info *InRingInfo, void *Buffer, u32 BufferLen)
+int ringbuffer_peek(struct hv_ring_buffer_info *Inring_info,
+                  void *Buffer, u32 buflen)
 {
-       u32 bytesAvailToWrite;
-       u32 bytesAvailToRead;
-       u32 nextReadLocation = 0;
+       u32 bytes_avail_towrite;
+       u32 bytes_avail_toread;
+       u32 next_read_location = 0;
        unsigned long flags;
 
-       spin_lock_irqsave(&InRingInfo->ring_lock, flags);
+       spin_lock_irqsave(&Inring_info->ring_lock, flags);
 
-       GetRingBufferAvailBytes(InRingInfo,
-                               &bytesAvailToRead,
-                               &bytesAvailToWrite);
+       get_ringbuffer_availbytes(Inring_info,
+                               &bytes_avail_toread,
+                               &bytes_avail_towrite);
 
        /* Make sure there is something to read */
-       if (bytesAvailToRead < BufferLen) {
+       if (bytes_avail_toread < buflen) {
                /* DPRINT_DBG(VMBUS,
                        "got callback but not enough to read "
                        "<avail to read %d read size %d>!!",
-                       bytesAvailToRead,
+                       bytes_avail_toread,
                        BufferLen); */
 
-               spin_unlock_irqrestore(&InRingInfo->ring_lock, flags);
+               spin_unlock_irqrestore(&Inring_info->ring_lock, flags);
 
                return -1;
        }
 
        /* Convert to byte offset */
-       nextReadLocation = GetNextReadLocation(InRingInfo);
+       next_read_location = get_next_read_location(Inring_info);
 
-       nextReadLocation = CopyFromRingBuffer(InRingInfo,
+       next_read_location = copyfrom_ringbuffer(Inring_info,
                                                Buffer,
-                                               BufferLen,
-                                               nextReadLocation);
+                                               buflen,
+                                               next_read_location);
 
-       spin_unlock_irqrestore(&InRingInfo->ring_lock, flags);
+       spin_unlock_irqrestore(&Inring_info->ring_lock, flags);
 
        return 0;
 }
@@ -467,58 +476,59 @@ int RingBufferPeek(struct hv_ring_buffer_info *InRingInfo, void *Buffer, u32 Buf
 /*++
 
 Name:
-       RingBufferRead()
+       ringbuffer_read()
 
 Description:
        Read and advance the read index
 
 --*/
-int RingBufferRead(struct hv_ring_buffer_info *InRingInfo, void *Buffer,
-                  u32 BufferLen, u32 Offset)
+int ringbuffer_read(struct hv_ring_buffer_info *inring_info, void *buffer,
+                  u32 buflen, u32 offset)
 {
-       u32 bytesAvailToWrite;
-       u32 bytesAvailToRead;
-       u32 nextReadLocation = 0;
-       u64 prevIndices = 0;
+       u32 bytes_avail_towrite;
+       u32 bytes_avail_toread;
+       u32 next_read_location = 0;
+       u64 prev_indices = 0;
        unsigned long flags;
 
-       if (BufferLen <= 0)
+       if (buflen <= 0)
                return -EINVAL;
 
-       spin_lock_irqsave(&InRingInfo->ring_lock, flags);
+       spin_lock_irqsave(&inring_info->ring_lock, flags);
 
-       GetRingBufferAvailBytes(InRingInfo,
-                               &bytesAvailToRead,
-                               &bytesAvailToWrite);
+       get_ringbuffer_availbytes(inring_info,
+                               &bytes_avail_toread,
+                               &bytes_avail_towrite);
 
-       DPRINT_DBG(VMBUS, "Reading %u bytes...", BufferLen);
+       DPRINT_DBG(VMBUS, "Reading %u bytes...", buflen);
 
-       /* DumpRingInfo(InRingInfo, "BEFORE "); */
+       /* Dumpring_info(Inring_info, "BEFORE "); */
 
        /* Make sure there is something to read */
-       if (bytesAvailToRead < BufferLen) {
+       if (bytes_avail_toread < buflen) {
                DPRINT_DBG(VMBUS,
                        "got callback but not enough to read "
                        "<avail to read %d read size %d>!!",
-                       bytesAvailToRead,
-                       BufferLen);
+                       bytes_avail_toread,
+                       buflen);
 
-               spin_unlock_irqrestore(&InRingInfo->ring_lock, flags);
+               spin_unlock_irqrestore(&inring_info->ring_lock, flags);
 
                return -1;
        }
 
-       nextReadLocation = GetNextReadLocationWithOffset(InRingInfo, Offset);
+       next_read_location =
+               get_next_readlocation_withoffset(inring_info, offset);
 
-       nextReadLocation = CopyFromRingBuffer(InRingInfo,
-                                               Buffer,
-                                               BufferLen,
-                                               nextReadLocation);
+       next_read_location = copyfrom_ringbuffer(inring_info,
+                                               buffer,
+                                               buflen,
+                                               next_read_location);
 
-       nextReadLocation = CopyFromRingBuffer(InRingInfo,
-                                               &prevIndices,
+       next_read_location = copyfrom_ringbuffer(inring_info,
+                                               &prev_indices,
                                                sizeof(u64),
-                                               nextReadLocation);
+                                               next_read_location);
 
        /* Make sure all reads are done before we update the read index since */
        /* the writer may start writing to the read area once the read index */
@@ -526,11 +536,11 @@ int RingBufferRead(struct hv_ring_buffer_info *InRingInfo, void *Buffer,
        mb();
 
        /* Update the read index */
-       SetNextReadLocation(InRingInfo, nextReadLocation);
+       set_next_read_location(inring_info, next_read_location);
 
-       /* DumpRingInfo(InRingInfo, "AFTER "); */
+       /* Dumpring_info(Inring_info, "AFTER "); */
 
-       spin_unlock_irqrestore(&InRingInfo->ring_lock, flags);
+       spin_unlock_irqrestore(&inring_info->ring_lock, flags);
 
        return 0;
 }
@@ -539,7 +549,7 @@ int RingBufferRead(struct hv_ring_buffer_info *InRingInfo, void *Buffer,
 /*++
 
 Name:
-       CopyToRingBuffer()
+       copyto_ringbuffer()
 
 Description:
        Helper routine to copy from source to ring buffer.
@@ -547,37 +557,37 @@ Description:
 
 --*/
 static u32
-CopyToRingBuffer(
-       struct hv_ring_buffer_info      *RingInfo,
-       u32                             StartWriteOffset,
-       void                            *Src,
-       u32                             SrcLen)
+copyto_ringbuffer(
+       struct hv_ring_buffer_info      *ring_info,
+       u32                             start_write_offset,
+       void                            *src,
+       u32                             srclen)
 {
-       void *ringBuffer = GetRingBuffer(RingInfo);
-       u32 ringBufferSize = GetRingBufferSize(RingInfo);
-       u32 fragLen;
+       void *ring_buffer = get_ring_buffer(ring_info);
+       u32 ring_buffer_size = get_ring_buffersize(ring_info);
+       u32 frag_len;
 
        /* wrap-around detected! */
-       if (SrcLen > ringBufferSize - StartWriteOffset) {
+       if (srclen > ring_buffer_size - start_write_offset) {
                DPRINT_DBG(VMBUS, "wrap-around detected!");
 
-               fragLen = ringBufferSize - StartWriteOffset;
-               memcpy(ringBuffer + StartWriteOffset, Src, fragLen);
-               memcpy(ringBuffer, Src + fragLen, SrcLen - fragLen);
+               frag_len = ring_buffer_size - start_write_offset;
+               memcpy(ring_buffer + start_write_offset, src, frag_len);
+               memcpy(ring_buffer, src + frag_len, srclen - frag_len);
        } else
-               memcpy(ringBuffer + StartWriteOffset, Src, SrcLen);
+               memcpy(ring_buffer + start_write_offset, src, srclen);
 
-       StartWriteOffset += SrcLen;
-       StartWriteOffset %= ringBufferSize;
+       start_write_offset += srclen;
+       start_write_offset %= ring_buffer_size;
 
-       return StartWriteOffset;
+       return start_write_offset;
 }
 
 
 /*++
 
 Name:
-       CopyFromRingBuffer()
+       copyfrom_ringbuffer()
 
 Description:
        Helper routine to copy to source from ring buffer.
@@ -585,34 +595,34 @@ Description:
 
 --*/
 static u32
-CopyFromRingBuffer(
-       struct hv_ring_buffer_info      *RingInfo,
-       void                            *Dest,
-       u32                             DestLen,
-       u32                             StartReadOffset)
+copyfrom_ringbuffer(
+       struct hv_ring_buffer_info      *ring_info,
+       void                            *dest,
+       u32                             destlen,
+       u32                             start_read_offset)
 {
-       void *ringBuffer = GetRingBuffer(RingInfo);
-       u32 ringBufferSize = GetRingBufferSize(RingInfo);
+       void *ring_buffer = get_ring_buffer(ring_info);
+       u32 ring_buffer_size = get_ring_buffersize(ring_info);
 
-       u32 fragLen;
+       u32 frag_len;
 
        /* wrap-around detected at the src */
-       if (DestLen > ringBufferSize - StartReadOffset) {
+       if (destlen > ring_buffer_size - start_read_offset) {
                DPRINT_DBG(VMBUS, "src wrap-around detected!");
 
-               fragLen = ringBufferSize - StartReadOffset;
+               frag_len = ring_buffer_size - start_read_offset;
 
-               memcpy(Dest, ringBuffer + StartReadOffset, fragLen);
-               memcpy(Dest + fragLen, ringBuffer, DestLen - fragLen);
+               memcpy(dest, ring_buffer + start_read_offset, frag_len);
+               memcpy(dest + frag_len, ring_buffer, destlen - frag_len);
        } else
 
-               memcpy(Dest, ringBuffer + StartReadOffset, DestLen);
+               memcpy(dest, ring_buffer + start_read_offset, destlen);
 
 
-       StartReadOffset += DestLen;
-       StartReadOffset %= ringBufferSize;
+       start_read_offset += destlen;
+       start_read_offset %= ring_buffer_size;
 
-       return StartReadOffset;
+       return start_read_offset;
 }