]> git.karo-electronics.de Git - mv-sheeva.git/commit
[media] gspca_main: Locking fixes 2
authorHans de Goede <hdegoede@redhat.com>
Thu, 30 Dec 2010 22:54:33 +0000 (19:54 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 Jan 2011 13:44:54 +0000 (11:44 -0200)
commit27074efa2ee8c1ef07dc5f644104e35d39e43322
tree2ba18e26633ad557b37cc3b42c1cd1381c069d61
parent4e770f7602fb2285f3106f98109d0685618ddc22
[media] gspca_main: Locking fixes 2

Before this patch vidioc_dqbuf is using its own read_lock, where as
other queue related functions use queue_lock. This means that dqbuf is
accessing several variables in a racy manor. The most important one
being fr_o, which may be changed from underneath dqbuf by vidioc_reqbufs
or vidioc_streamoff. Other variables which it accesses unprotected
are gspca_dev->memory, gspca_dev->streaming and gspca_dev->capt_file.

This patch fixes this by changing vidioc_dqbuf to also use the queue_lock.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/gspca/gspca.c
drivers/media/video/gspca/gspca.h