]> git.karo-electronics.de Git - mv-sheeva.git/commit
Staging: sst: dereferencing user pointers
authorDan Carpenter <error27@gmail.com>
Tue, 19 Oct 2010 05:56:24 +0000 (07:56 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 9 Nov 2010 21:30:48 +0000 (13:30 -0800)
commit3b97eed201376db6c4487fc846022eb4ffa7e1f9
treeaaa0ad36af41e9a25562a8e08793265a9c304390
parentea07a9f2557b8ea99a0cdd778a5d94a7495bb049
Staging: sst: dereferencing user pointers

This code dereferences user supplied pointers directly instead of doing
a copy_from_user().  Some kernel configs put user and kernel memory in
different address spaces so this code isn't portable.  Also the user
memory could be swapped out or in this case the pointer could just be
NULL leading to an oops.

Another thing is that it makes permission tests like this sort of
meaningless.
if (minor == STREAM_MODULE && rec_mute->stream_id == 0) {
retval = -EPERM;
break;
}
The user could set stream_id to 1 for the test and then change it later.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/intel_sst/intel_sst_app_interface.c