]> git.karo-electronics.de Git - mv-sheeva.git/commit
projects / mv-sheeva.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0add79e) | patch
qlge: pull NULL check ahead of dereference
authorDan Carpenter <error27@gmail.com>
Thu, 19 Aug 2010 08:52:44 +0000 (08:52 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Aug 2010 03:48:07 +0000 (20:48 -0700)
commit4da79504b2b41410dd56e9268c9ad403aa65e89c
tree6a4df07feabd971a80ea17cbd3d10d66eafcf919tree | snapshot
parent0add79e3134a618c10acabe58834ac647075111acommit | diff
qlge: pull NULL check ahead of dereference

There was a dereference before NULL check issue introduced in 1e213303d
"qlge: Add tx multiqueue support."  I've pulled the NULL check of
"net_rsp" forward a couple lines to avoid that.

Also Ron Mercer says that the early exit should be above the index
write.  ql_write_cq_idx(rx_ring);

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/qlge/qlge_main.c diff | blob | history
Linux for Marvell Sheeva based platforms