]> git.karo-electronics.de Git - mv-sheeva.git/commit
cifs: make cifs_ioctl handle NULL filp->private_data correctly
authorJeff Layton <jlayton@redhat.com>
Mon, 8 Nov 2010 12:28:32 +0000 (07:28 -0500)
committerSteve French <sfrench@us.ibm.com>
Mon, 8 Nov 2010 18:56:36 +0000 (18:56 +0000)
commit618763958b2291a09057dbfa553da6ded93dcfad
tree985c2e8eba7e0b63f0c9ac314fa1bf6c311aee73
parent151f52f09c5728ecfdd0c289da1a4b30bb416f2c
cifs: make cifs_ioctl handle NULL filp->private_data correctly

Commit 13cfb7334e made cifs_ioctl use the tlink attached to the
cifsFileInfo for a filp. This ignores the case of an open directory
however, which in CIFS can have a NULL private_data until a readdir
is done on it.

This patch re-adds the NULL pointer checks that were removed in commit
50ae28f01 and moves the setting of tcon and "caps" variables lower.

Long term, a better fix would be to establish a f_op->open routine for
directories that populates that field at open time, but that requires
some other changes to how readdir calls are handled.

Reported-by: Kjell Rune Skaaraas <kjella79@yahoo.no>
Reviewed-and-Tested-by: Suresh Jayaraman <sjayaraman@suse.de>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/ioctl.c