]> git.karo-electronics.de Git - mv-sheeva.git/commit
rapidio: use resource_size()
authorDan Carpenter <error27@gmail.com>
Thu, 11 Nov 2010 22:05:07 +0000 (14:05 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Nov 2010 15:55:30 +0000 (07:55 -0800)
commit88cf81fc8944a6892db104caaa490885d48b959c
tree47d5577fce949c58f2d69fdde549ba76e69ce770
parent38b7a2ae0ad3e29e1881b82c0f421ba5db148e3d
rapidio: use resource_size()

The size calculation is done incorrectly here because it should include
both the start and end (end - start + 1).  It's easiest to just use
resource_size() which does the right thing.

I was worried there was something non-standard going on because the
printk() subtracts "end - 1", but the rest of the file uses the normal
resource size calculations.  This function is only called from
fsl_rio_setup() in arch/powerpc/sysdev/fsl_rio.c and the calculation
there is also:

port->iores.start = law_start;
port->iores.end = law_start + law_size - 1;

So I think this is the correct fix.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Alexandre Bounine <alexandre.bounine@idt.com>
Acked-by: Li Yang <leoli@freescale.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rapidio/rio.c