]> git.karo-electronics.de Git - mv-sheeva.git/commit
projects / mv-sheeva.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 35f2516) | patch
pch_gbe: fix if condition in set_settings()
authorDan Carpenter <error27@gmail.com>
Tue, 12 Oct 2010 23:36:19 +0000 (23:36 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Oct 2010 18:13:20 +0000 (11:13 -0700)
commit89980827c7a1e3c2b36895c22c6ef0e92aea6b0c
tree84a248d335452737f66912fe61f8ad5e9ac3a7e7tree | snapshot
parent35f2516f0a1f9dddb339849c7a07e089322c18c3commit | diff
pch_gbe: fix if condition in set_settings()

There were no curly braces in this if condition so it always enabled full
duplex.

And ecmd->speed is an unsigned short so it is never equal to -1.  The
effect is that mii_ethtool_sset() fails with -EINVAL and an error is
printed to dmesg.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pch_gbe/pch_gbe_ethtool.c diff | blob | history
Linux for Marvell Sheeva based platforms