]> git.karo-electronics.de Git - mv-sheeva.git/commit
Freezer: Fix a race during freezing of TASK_STOPPED tasks
authorTejun Heo <tj@kernel.org>
Fri, 26 Nov 2010 22:07:27 +0000 (23:07 +0100)
committerRafael J. Wysocki <rjw@sisk.pl>
Fri, 24 Dec 2010 14:02:40 +0000 (15:02 +0100)
commit8cfe400ca54fd1ed96f962bea5f7e20b09b6d69f
tree393f1eb68d2497b04778c2e062fc4e1450df33eb
parent133f1128b2bf178a1976b17c54bd14ce6feb90bf
Freezer: Fix a race during freezing of TASK_STOPPED tasks

After calling freeze_task(), try_to_freeze_tasks() see whether the
task is stopped or traced and if so, considers it to be frozen;
however, nothing guarantees that either the task being frozen sees
TIF_FREEZE or the freezer sees TASK_STOPPED -> TASK_RUNNING
transition.  The task being frozen may wake up and not see TIF_FREEZE
while the freezer fails to notice the transition and believes the task
is still stopped.

This patch fixes the race by making freeze_task() always go through
fake_signal_wake_up() for applicable tasks.  The function goes through
the target task's scheduler lock and thus guarantees that either the
target sees TIF_FREEZE or try_to_freeze_task() sees TASK_RUNNING.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
kernel/freezer.c
kernel/power/process.c