]> git.karo-electronics.de Git - mv-sheeva.git/commit
KEYS: Fix RCU no-lock warning in keyctl_session_to_parent()
authorDavid Howells <dhowells@redhat.com>
Fri, 10 Sep 2010 08:59:46 +0000 (09:59 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Sep 2010 14:30:00 +0000 (07:30 -0700)
commit9d1ac65a9698513d00e5608d93fca0c53f536c14
tree859809638bdf52f56b6b3890bedefcc1bae89b32
parentff3cb3fec3c5bbb5110e652bbdd410bc99a47e9f
KEYS: Fix RCU no-lock warning in keyctl_session_to_parent()

There's an protected access to the parent process's credentials in the middle
of keyctl_session_to_parent().  This results in the following RCU warning:

  ===================================================
  [ INFO: suspicious rcu_dereference_check() usage. ]
  ---------------------------------------------------
  security/keys/keyctl.c:1291 invoked rcu_dereference_check() without protection!

  other info that might help us debug this:

  rcu_scheduler_active = 1, debug_locks = 0
  1 lock held by keyctl-session-/2137:
   #0:  (tasklist_lock){.+.+..}, at: [<ffffffff811ae2ec>] keyctl_session_to_parent+0x60/0x236

  stack backtrace:
  Pid: 2137, comm: keyctl-session- Not tainted 2.6.36-rc2-cachefs+ #1
  Call Trace:
   [<ffffffff8105606a>] lockdep_rcu_dereference+0xaa/0xb3
   [<ffffffff811ae379>] keyctl_session_to_parent+0xed/0x236
   [<ffffffff811af77e>] sys_keyctl+0xb4/0xb6
   [<ffffffff81001eab>] system_call_fastpath+0x16/0x1b

The code should take the RCU read lock to make sure the parents credentials
don't go away, even though it's holding a spinlock and has IRQ disabled.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
security/keys/keyctl.c