]> git.karo-electronics.de Git - mv-sheeva.git/commit
PM / Sleep: Fix race conditions related to wakeup source timer function
authorRafael J. Wysocki <rjw@sisk.pl>
Fri, 17 Feb 2012 22:39:33 +0000 (23:39 +0100)
committerRafael J. Wysocki <rjw@sisk.pl>
Sun, 4 Mar 2012 22:08:14 +0000 (23:08 +0100)
commitda863cddd831b0f4bf2d067f8b75254f1be94590
treef217486238bec611a0c08b88ae64249ba60a544e
parentd94aff87826ee6aa43032f4c0263482913f4e2c8
PM / Sleep: Fix race conditions related to wakeup source timer function

If __pm_wakeup_event() has been used (with a nonzero timeout) to
report a wakeup event and then __pm_relax() immediately followed by
__pm_stay_awake() is called or __pm_wakeup_event() is called once
again for the same wakeup source object before its timer expires, the
timer function pm_wakeup_timer_fn() may still be run as a result of
the previous __pm_wakeup_event() call.  In either of those cases it
may mistakenly deactivate the wakeup source that has just been
activated.

To prevent that from happening, make wakeup_source_deactivate()
clear the wakeup source's timer_expires field and make
pm_wakeup_timer_fn() check if timer_expires is different from zero
and if it's not in future before calling wakeup_source_deactivate()
(if timer_expires is 0, it means that the timer has just been
deleted and if timer_expires is in future, it means that the timer
has just been rescheduled to a different time).

Reported-by: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
drivers/base/power/wakeup.c