]> git.karo-electronics.de Git - mv-sheeva.git/commit
ALSA: asihpi - Unsafe memory management when allocating control cache
authorJesper Juhl <jj@chaosbits.net>
Fri, 29 Oct 2010 19:35:25 +0000 (21:35 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 2 Nov 2010 06:38:21 +0000 (07:38 +0100)
commitfd0977d0f42d3e73121b88f57c7d48ca9b861a58
tree6a851561a7a67d660f5ce5260f6e6429fed0eccc
parentf7467452291f7c9e5e1271e8c8e45b77f34b1257
ALSA: asihpi - Unsafe memory management when allocating control cache

I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does
not check the return value from kmalloc(), which may fail.
If kmalloc() fails we'll dereference a null pointer and things will go bad
fast.
There are two memory allocations in that function and there's also the
problem that the first may succeed and the second may fail and nothing is
done about that either which will also go wrong down the line.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eliot Blennerhassett <linux@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/asihpi/hpi6000.c
sound/pci/asihpi/hpi6205.c
sound/pci/asihpi/hpicmn.c