From: Dan Carpenter <error27@gmail.com>
Date: Mon, 6 Dec 2010 07:02:55 +0000 (+0300)
Subject: Staging: Beceem: use after free in bcm_exit()
X-Git-Url: https://git.karo-electronics.de/?p=mv-sheeva.git;a=commitdiff_plain;h=6b74705e15d5c87181008f1ac984df7faaad55c9

Staging: Beceem: use after free in bcm_exit()

We can't call class_destroy() until after the driver has been deregistered.
It leads to a NULL deref on module unload.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c
index dd829409a8c..b4d22562d06 100644
--- a/drivers/staging/bcm/InterfaceInit.c
+++ b/drivers/staging/bcm/InterfaceInit.c
@@ -658,9 +658,8 @@ static __init int bcm_init(void)
 
 static __exit void bcm_exit(void)
 {
-	class_destroy(bcm_class);
-
 	usb_deregister(&usbbcm_driver);
+	class_destroy(bcm_class);
 }
 
 module_init(bcm_init);