]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
drm: add support for pixel clock and DE polarity control via DT
[karo-tx-linux.git] / drivers / gpu / drm / atmel-hlcdc / atmel_hlcdc_crtc.c
index b3e3068c6ec07f8caa8bac6a4edc68e75741190d..291ddbd9a9980935338a39385ae265687eb81e0f 100644 (file)
@@ -21,6 +21,7 @@
 #include <linux/clk.h>
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <drm/drm_crtc.h>
 #include <drm/drm_crtc_helper.h>
  * @hlcdc: pointer to the atmel_hlcdc structure provided by the MFD device
  * @event: pointer to the current page flip event
  * @id: CRTC id (returned by drm_crtc_index)
- * @dpms: DPMS mode
+ * @enabled: CRTC state
  */
 struct atmel_hlcdc_crtc {
        struct drm_crtc base;
        struct atmel_hlcdc_dc *dc;
        struct drm_pending_vblank_event *event;
        int id;
-       int dpms;
+       bool enabled;
 };
 
 static inline struct atmel_hlcdc_crtc *
@@ -53,86 +54,17 @@ drm_crtc_to_atmel_hlcdc_crtc(struct drm_crtc *crtc)
        return container_of(crtc, struct atmel_hlcdc_crtc, base);
 }
 
-static void atmel_hlcdc_crtc_dpms(struct drm_crtc *c, int mode)
+static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 {
-       struct drm_device *dev = c->dev;
        struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
        struct regmap *regmap = crtc->dc->hlcdc->regmap;
-       unsigned int status;
-
-       if (mode != DRM_MODE_DPMS_ON)
-               mode = DRM_MODE_DPMS_OFF;
-
-       if (crtc->dpms == mode)
-               return;
-
-       pm_runtime_get_sync(dev->dev);
-
-       if (mode != DRM_MODE_DPMS_ON) {
-               regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      (status & ATMEL_HLCDC_DISP))
-                       cpu_relax();
-
-               regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_SYNC);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      (status & ATMEL_HLCDC_SYNC))
-                       cpu_relax();
-
-               regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_PIXEL_CLK);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      (status & ATMEL_HLCDC_PIXEL_CLK))
-                       cpu_relax();
-
-               clk_disable_unprepare(crtc->dc->hlcdc->sys_clk);
-
-               pm_runtime_allow(dev->dev);
-       } else {
-               pm_runtime_forbid(dev->dev);
-
-               clk_prepare_enable(crtc->dc->hlcdc->sys_clk);
-
-               regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_PIXEL_CLK);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      !(status & ATMEL_HLCDC_PIXEL_CLK))
-                       cpu_relax();
-
-
-               regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_SYNC);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      !(status & ATMEL_HLCDC_SYNC))
-                       cpu_relax();
-
-               regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_DISP);
-               while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
-                      !(status & ATMEL_HLCDC_DISP))
-                       cpu_relax();
-       }
-
-       pm_runtime_put_sync(dev->dev);
-
-       crtc->dpms = mode;
-}
-
-static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c,
-                                    struct drm_display_mode *mode,
-                                    struct drm_display_mode *adj,
-                                    int x, int y,
-                                    struct drm_framebuffer *old_fb)
-{
-       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
-       struct regmap *regmap = crtc->dc->hlcdc->regmap;
-       struct drm_plane *plane = c->primary;
-       struct drm_framebuffer *fb;
+       struct drm_display_mode *adj = &c->state->adjusted_mode;
        unsigned long mode_rate;
        struct videomode vm;
        unsigned long prate;
        unsigned int cfg;
        int div;
 
-       if (atmel_hlcdc_dc_mode_valid(crtc->dc, adj) != MODE_OK)
-               return -EINVAL;
-
        vm.vfront_porch = adj->crtc_vsync_start - adj->crtc_vdisplay;
        vm.vback_porch = adj->crtc_vtotal - adj->crtc_vsync_end;
        vm.vsync_len = adj->crtc_vsync_end - adj->crtc_vsync_start;
@@ -156,7 +88,7 @@ static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c,
        cfg = 0;
 
        prate = clk_get_rate(crtc->dc->hlcdc->sys_clk);
-       mode_rate = mode->crtc_clock * 1000;
+       mode_rate = adj->crtc_clock * 1000;
        if ((prate / 2) < mode_rate) {
                prate *= 2;
                cfg |= ATMEL_HLCDC_CLKSEL;
@@ -168,18 +100,24 @@ static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c,
 
        cfg |= ATMEL_HLCDC_CLKDIV(div);
 
+       if (adj->flags & DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE)
+               cfg |= ATMEL_HLCDC_CLKPOL;
+
        regmap_update_bits(regmap, ATMEL_HLCDC_CFG(0),
                           ATMEL_HLCDC_CLKSEL | ATMEL_HLCDC_CLKDIV_MASK |
                           ATMEL_HLCDC_CLKPOL, cfg);
 
        cfg = 0;
 
-       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+       if (adj->flags & DRM_MODE_FLAG_NVSYNC)
                cfg |= ATMEL_HLCDC_VSPOL;
 
-       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+       if (adj->flags & DRM_MODE_FLAG_NHSYNC)
                cfg |= ATMEL_HLCDC_HSPOL;
 
+       if (adj->flags & DRM_MODE_FLAG_POL_DE_LOW)
+               cfg |= ATMEL_HLCDC_DISPPOL;
+
        regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),
                           ATMEL_HLCDC_HSPOL | ATMEL_HLCDC_VSPOL |
                           ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE |
@@ -187,77 +125,155 @@ static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c,
                           ATMEL_HLCDC_VSPSU | ATMEL_HLCDC_VSPHO |
                           ATMEL_HLCDC_GUARDTIME_MASK,
                           cfg);
+}
+
+static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *crtc,
+                                       const struct drm_display_mode *mode,
+                                       struct drm_display_mode *adjusted_mode)
+{
+       return true;
+}
+
+static void atmel_hlcdc_crtc_disable(struct drm_crtc *c)
+{
+       struct drm_device *dev = c->dev;
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
+       struct regmap *regmap = crtc->dc->hlcdc->regmap;
+       unsigned int status;
+
+       if (!crtc->enabled)
+               return;
+
+       drm_crtc_vblank_off(c);
+
+       pm_runtime_get_sync(dev->dev);
+
+       regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              (status & ATMEL_HLCDC_DISP))
+               cpu_relax();
+
+       regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_SYNC);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              (status & ATMEL_HLCDC_SYNC))
+               cpu_relax();
+
+       regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_PIXEL_CLK);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              (status & ATMEL_HLCDC_PIXEL_CLK))
+               cpu_relax();
+
+       clk_disable_unprepare(crtc->dc->hlcdc->sys_clk);
+       pinctrl_pm_select_sleep_state(dev->dev);
 
-       fb = plane->fb;
-       plane->fb = old_fb;
+       pm_runtime_allow(dev->dev);
 
-       return atmel_hlcdc_plane_update_with_mode(plane, c, fb, 0, 0,
-                                                 adj->hdisplay, adj->vdisplay,
-                                                 x << 16, y << 16,
-                                                 adj->hdisplay << 16,
-                                                 adj->vdisplay << 16,
-                                                 adj);
+       pm_runtime_put_sync(dev->dev);
+
+       crtc->enabled = false;
 }
 
-int atmel_hlcdc_crtc_mode_set_base(struct drm_crtc *c, int x, int y,
-                                  struct drm_framebuffer *old_fb)
+static void atmel_hlcdc_crtc_enable(struct drm_crtc *c)
 {
-       struct drm_plane *plane = c->primary;
-       struct drm_framebuffer *fb = plane->fb;
-       struct drm_display_mode *mode = &c->hwmode;
-
-       plane->fb = old_fb;
-
-       return plane->funcs->update_plane(plane, c, fb,
-                                         0, 0,
-                                         mode->hdisplay,
-                                         mode->vdisplay,
-                                         x << 16, y << 16,
-                                         mode->hdisplay << 16,
-                                         mode->vdisplay << 16);
+       struct drm_device *dev = c->dev;
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
+       struct regmap *regmap = crtc->dc->hlcdc->regmap;
+       unsigned int status;
+
+       if (crtc->enabled)
+               return;
+
+       pm_runtime_get_sync(dev->dev);
+
+       pm_runtime_forbid(dev->dev);
+
+       pinctrl_pm_select_default_state(dev->dev);
+       clk_prepare_enable(crtc->dc->hlcdc->sys_clk);
+
+       regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_PIXEL_CLK);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              !(status & ATMEL_HLCDC_PIXEL_CLK))
+               cpu_relax();
+
+
+       regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_SYNC);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              !(status & ATMEL_HLCDC_SYNC))
+               cpu_relax();
+
+       regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_DISP);
+       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
+              !(status & ATMEL_HLCDC_DISP))
+               cpu_relax();
+
+       pm_runtime_put_sync(dev->dev);
+
+       drm_crtc_vblank_on(c);
+
+       crtc->enabled = true;
 }
 
-static void atmel_hlcdc_crtc_prepare(struct drm_crtc *crtc)
+void atmel_hlcdc_crtc_suspend(struct drm_crtc *c)
 {
-       atmel_hlcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
+
+       if (crtc->enabled) {
+               atmel_hlcdc_crtc_disable(c);
+               /* save enable state for resume */
+               crtc->enabled = true;
+       }
 }
 
-static void atmel_hlcdc_crtc_commit(struct drm_crtc *crtc)
+void atmel_hlcdc_crtc_resume(struct drm_crtc *c)
 {
-       atmel_hlcdc_crtc_dpms(crtc, DRM_MODE_DPMS_ON);
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
+
+       if (crtc->enabled) {
+               crtc->enabled = false;
+               atmel_hlcdc_crtc_enable(c);
+       }
 }
 
-static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *crtc,
-                                       const struct drm_display_mode *mode,
-                                       struct drm_display_mode *adjusted_mode)
+static int atmel_hlcdc_crtc_atomic_check(struct drm_crtc *c,
+                                        struct drm_crtc_state *s)
 {
-       return true;
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
+
+       if (atmel_hlcdc_dc_mode_valid(crtc->dc, &s->adjusted_mode) != MODE_OK)
+               return -EINVAL;
+
+       return atmel_hlcdc_plane_prepare_disc_area(s);
 }
 
-static void atmel_hlcdc_crtc_disable(struct drm_crtc *crtc)
+static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c)
 {
-       struct drm_plane *plane;
+       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
 
-       atmel_hlcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
-       crtc->primary->funcs->disable_plane(crtc->primary);
+       if (c->state->event) {
+               c->state->event->pipe = drm_crtc_index(c);
 
-       drm_for_each_legacy_plane(plane, &crtc->dev->mode_config.plane_list) {
-               if (plane->crtc != crtc)
-                       continue;
+               WARN_ON(drm_crtc_vblank_get(c) != 0);
 
-               plane->funcs->disable_plane(crtc->primary);
-               plane->crtc = NULL;
+               crtc->event = c->state->event;
+               c->state->event = NULL;
        }
 }
 
+static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc)
+{
+       /* TODO: write common plane control register if available */
+}
+
 static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = {
        .mode_fixup = atmel_hlcdc_crtc_mode_fixup,
-       .dpms = atmel_hlcdc_crtc_dpms,
-       .mode_set = atmel_hlcdc_crtc_mode_set,
-       .mode_set_base = atmel_hlcdc_crtc_mode_set_base,
-       .prepare = atmel_hlcdc_crtc_prepare,
-       .commit = atmel_hlcdc_crtc_commit,
+       .mode_set = drm_helper_crtc_mode_set,
+       .mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb,
+       .mode_set_base = drm_helper_crtc_mode_set_base,
        .disable = atmel_hlcdc_crtc_disable,
+       .enable = atmel_hlcdc_crtc_enable,
+       .atomic_check = atmel_hlcdc_crtc_atomic_check,
+       .atomic_begin = atmel_hlcdc_crtc_atomic_begin,
+       .atomic_flush = atmel_hlcdc_crtc_atomic_flush,
 };
 
 static void atmel_hlcdc_crtc_destroy(struct drm_crtc *c)
@@ -306,61 +322,13 @@ void atmel_hlcdc_crtc_irq(struct drm_crtc *c)
        atmel_hlcdc_crtc_finish_page_flip(drm_crtc_to_atmel_hlcdc_crtc(c));
 }
 
-static int atmel_hlcdc_crtc_page_flip(struct drm_crtc *c,
-                                     struct drm_framebuffer *fb,
-                                     struct drm_pending_vblank_event *event,
-                                     uint32_t page_flip_flags)
-{
-       struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c);
-       struct atmel_hlcdc_plane_update_req req;
-       struct drm_plane *plane = c->primary;
-       struct drm_device *dev = c->dev;
-       unsigned long flags;
-       int ret = 0;
-
-       spin_lock_irqsave(&dev->event_lock, flags);
-       if (crtc->event)
-               ret = -EBUSY;
-       spin_unlock_irqrestore(&dev->event_lock, flags);
-
-       if (ret)
-               return ret;
-
-       memset(&req, 0, sizeof(req));
-       req.crtc_x = 0;
-       req.crtc_y = 0;
-       req.crtc_h = c->mode.crtc_vdisplay;
-       req.crtc_w = c->mode.crtc_hdisplay;
-       req.src_x = c->x << 16;
-       req.src_y = c->y << 16;
-       req.src_w = req.crtc_w << 16;
-       req.src_h = req.crtc_h << 16;
-       req.fb = fb;
-
-       ret = atmel_hlcdc_plane_prepare_update_req(plane, &req, &c->hwmode);
-       if (ret)
-               return ret;
-
-       if (event) {
-               drm_vblank_get(c->dev, crtc->id);
-               spin_lock_irqsave(&dev->event_lock, flags);
-               crtc->event = event;
-               spin_unlock_irqrestore(&dev->event_lock, flags);
-       }
-
-       ret = atmel_hlcdc_plane_apply_update_req(plane, &req);
-       if (ret)
-               crtc->event = NULL;
-       else
-               plane->fb = fb;
-
-       return ret;
-}
-
 static const struct drm_crtc_funcs atmel_hlcdc_crtc_funcs = {
-       .page_flip = atmel_hlcdc_crtc_page_flip,
-       .set_config = drm_crtc_helper_set_config,
+       .page_flip = drm_atomic_helper_page_flip,
+       .set_config = drm_atomic_helper_set_config,
        .destroy = atmel_hlcdc_crtc_destroy,
+       .reset = drm_atomic_helper_crtc_reset,
+       .atomic_duplicate_state =  drm_atomic_helper_crtc_duplicate_state,
+       .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
 };
 
 int atmel_hlcdc_crtc_create(struct drm_device *dev)
@@ -375,7 +343,6 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev)
        if (!crtc)
                return -ENOMEM;
 
-       crtc->dpms = DRM_MODE_DPMS_OFF;
        crtc->dc = dc;
 
        ret = drm_crtc_init_with_planes(dev, &crtc->base,