gpiolib: Forbid irqchip default trigger for ACPI enumerated devices

Follow DT and forbid default trigger if the GPIO irqchip device is
enumerated from ACPI. Triggering for these devices will be configured
automatically from ACPI interrupt resources provided by the BIOS.

Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e183ee2f5f659ff553cba0ab01a71f046c2be537..043128d3e831daf391e544b67c2f3db23f8c2146 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1614,13 +1614,18 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,
                of_node = gpiochip->of_node;
 #endif
        /*
-        * Specifying a default trigger is a terrible idea if DT is
+        * Specifying a default trigger is a terrible idea if DT or ACPI is
         * used to configure the interrupts, as you may end-up with
         * conflicting triggers. Tell the user, and reset to NONE.
         */
        if (WARN(of_node && type != IRQ_TYPE_NONE,
                 "%s: Ignoring %d default trigger\n", of_node->full_name, type))
                type = IRQ_TYPE_NONE;
+       if (has_acpi_companion(gpiochip->parent) && type != IRQ_TYPE_NONE) {
+               acpi_handle_warn(ACPI_HANDLE(gpiochip->parent),
+                                "Ignoring %d default trigger\n", type);
+               type = IRQ_TYPE_NONE;
+       }
 
        gpiochip->irqchip = irqchip;
        gpiochip->irq_handler = handler;