]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ALSA: x86: Don't enable runtime PM as default
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Feb 2017 21:18:57 +0000 (22:18 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 21 Feb 2017 21:23:14 +0000 (22:23 +0100)
Unlike HSW and newer, BYT/CHT devices have no fine control of audio
power domain in i915 side.  Since there is little gain by runtime PM
on BYT/CHT, so far, this commit removes the pm_runtime_enable() call
as default.

User who still wants the runtime PM may adjust the corresponding
sysfs files (power/control and power/autosuspend_delay_ms)
appropriately, of course.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/x86/intel_hdmi_audio.c

index d1504303adfb6442dcc53128d29d11fe2097f975..c505b019e09ce0795cc8ddd79cf1f8c6a18d32ff 100644 (file)
@@ -1809,11 +1809,13 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
        pdata->notify_pending = false;
        spin_unlock_irq(&pdata->lpe_audio_slock);
 
+       /* runtime PM isn't enabled as default, since it won't save much on
+        * BYT/CHT devices; user who want the runtime PM should adjust the
+        * power/ontrol and power/autosuspend_delay_ms sysfs entries instead
+        */
        pm_runtime_use_autosuspend(&pdev->dev);
        pm_runtime_mark_last_busy(&pdev->dev);
-
        pm_runtime_set_active(&pdev->dev);
-       pm_runtime_enable(&pdev->dev);
 
        dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
        schedule_work(&ctx->hdmi_audio_wq);