]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
dmaengine: cppi41: Fix list not empty warning on module removal
authorTony Lindgren <tony@atomide.com>
Wed, 9 Nov 2016 16:47:58 +0000 (09:47 -0700)
committerVinod Koul <vinod.koul@intel.com>
Mon, 14 Nov 2016 05:27:21 +0000 (10:57 +0530)
If musb controller is configured with USB peripherals and we have
enumerated with a USB host, we can get warnings on removal of the
modules:

WARNING: CPU: 0 PID: 1269 at drivers/dma/cppi41.c:391
cppi41_dma_free_chan_resources

Fix the issue by adding the missing pm_runtime_get to
cppi41_dma_free_chan_resources to make sure the pending work
list is cleared on removal.

Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/cppi41.c

index bac5f023013b23c92519f052f8523b6008524271..6ed99d9263583282e34881110d3fe2fa7b77f637 100644 (file)
@@ -1072,7 +1072,12 @@ err_get_sync:
 static int cppi41_dma_remove(struct platform_device *pdev)
 {
        struct cppi41_dd *cdd = platform_get_drvdata(pdev);
+       int error;
 
+       error = pm_runtime_get_sync(&pdev->dev);
+       if (error < 0)
+               dev_err(&pdev->dev, "%s could not pm_runtime_get: %i\n",
+                       __func__, error);
        of_dma_controller_free(pdev->dev.of_node);
        dma_async_device_unregister(&cdd->ddev);