]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: gadget: amd5536udc: NULL comparison
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 22 Sep 2015 13:24:37 +0000 (18:54 +0530)
committerFelipe Balbi <balbi@ti.com>
Thu, 1 Oct 2015 17:40:22 +0000 (12:40 -0500)
A NULL comparison can be written as if (var) or if (!var).

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/amd5536udc.c

index 157bff1ffa64dabb5ab4d30d88b76b98b5af49de..cd8764150861cf1c677bb25a52f4a1b00294b52e 100644 (file)
@@ -2185,7 +2185,7 @@ static irqreturn_t udc_data_out_isr(struct udc *dev, int ep_ix)
                }
 
        /* DMA */
-       } else if (!ep->cancel_transfer && req != NULL) {
+       } else if (!ep->cancel_transfer && req) {
                ret_val = IRQ_HANDLED;
 
                /* check for DMA done */
@@ -3189,7 +3189,7 @@ static int init_dma_pools(struct udc *dev)
        /* setup */
        td_stp = dma_pool_alloc(dev->stp_requests, GFP_KERNEL,
                                &dev->ep[UDC_EP0OUT_IX].td_stp_dma);
-       if (td_stp == NULL) {
+       if (!td_stp) {
                retval = -ENOMEM;
                goto err_alloc_dma;
        }
@@ -3198,7 +3198,7 @@ static int init_dma_pools(struct udc *dev)
        /* data: 0 packets !? */
        td_data = dma_pool_alloc(dev->stp_requests, GFP_KERNEL,
                                &dev->ep[UDC_EP0OUT_IX].td_phys);
-       if (td_data == NULL) {
+       if (!td_data) {
                retval = -ENOMEM;
                goto err_alloc_phys;
        }
@@ -3322,7 +3322,7 @@ static int udc_pci_probe(
        }
 
        dev->virt_addr = ioremap_nocache(resource, len);
-       if (dev->virt_addr == NULL) {
+       if (!dev->virt_addr) {
                dev_dbg(&pdev->dev, "start address cannot be mapped\n");
                retval = -EFAULT;
                goto err_ioremap;