]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
power: supply: max17047_battery: The temp alert values are 8-bit 2's complement
authorHans de Goede <hdegoede@redhat.com>
Fri, 14 Apr 2017 18:32:48 +0000 (20:32 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 1 May 2017 10:37:21 +0000 (12:37 +0200)
The temp alert values are 8-bit 2's complement, so sign-extend them
before reporting them back to the caller.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/max17042_battery.c

index 790dfa9d0a2eea4ab1a400a3ccf593df0e1ffdc9..a51b2965cd5c8a26d9adfb1174bc984120a770ae 100644 (file)
@@ -270,14 +270,14 @@ static int max17042_get_property(struct power_supply *psy,
                if (ret < 0)
                        return ret;
                /* LSB is Alert Minimum. In deci-centigrade */
-               val->intval = (data & 0xff) * 10;
+               val->intval = sign_extend32(data & 0xff, 7) * 10;
                break;
        case POWER_SUPPLY_PROP_TEMP_ALERT_MAX:
                ret = regmap_read(map, MAX17042_TALRT_Th, &data);
                if (ret < 0)
                        return ret;
                /* MSB is Alert Maximum. In deci-centigrade */
-               val->intval = (data >> 8) * 10;
+               val->intval = sign_extend32(data >> 8, 7) * 10;
                break;
        case POWER_SUPPLY_PROP_TEMP_MIN:
                val->intval = chip->pdata->temp_min;