]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
crypto: sahara - checking the wrong variable
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:51:41 +0000 (11:51 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 21 Aug 2013 11:28:06 +0000 (21:28 +1000)
There is a typo here.  "dev->hw_link[]" is an array, not a pointer, so
the check is nonsense.  We should be checking recently allocated
"dev->hw_link[0]" instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/sahara.c

index b076d8110785fa3d8deeb521a3841b6f15b4da69..d7bb8bac36e973944334409760dc56c37eb02be1 100644 (file)
@@ -955,7 +955,7 @@ static int sahara_probe(struct platform_device *pdev)
        dev->hw_link[0] = dma_alloc_coherent(&pdev->dev,
                        SAHARA_MAX_HW_LINK * sizeof(struct sahara_hw_link),
                        &dev->hw_phys_link[0], GFP_KERNEL);
-       if (!dev->hw_link) {
+       if (!dev->hw_link[0]) {
                dev_err(&pdev->dev, "Could not allocate hw links\n");
                err = -ENOMEM;
                goto err_link;