]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mfd: twl6040: Remove obsolete cleanup for i2c clientdata
authorWolfram Sang <wsa@the-dreams.de>
Sun, 13 Oct 2013 16:06:12 +0000 (18:06 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 13 Oct 2013 23:14:00 +0000 (01:14 +0200)
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/twl6040.c

index daf66942071c9084779497f6b40ac7bc2c8c916d..9d948af420db71ab7a8eb0406d807b40df2ae2f7 100644 (file)
@@ -565,13 +565,13 @@ static int twl6040_probe(struct i2c_client *client,
                                      twl6040->supplies);
        if (ret != 0) {
                dev_err(&client->dev, "Failed to get supplies: %d\n", ret);
-               goto regulator_get_err;
+               return ret;
        }
 
        ret = regulator_bulk_enable(TWL6040_NUM_SUPPLIES, twl6040->supplies);
        if (ret != 0) {
                dev_err(&client->dev, "Failed to enable supplies: %d\n", ret);
-               goto regulator_get_err;
+               return ret;
        }
 
        twl6040->dev = &client->dev;
@@ -671,9 +671,6 @@ readyirq_err:
        regmap_del_irq_chip(twl6040->irq, twl6040->irq_data);
 gpio_err:
        regulator_bulk_disable(TWL6040_NUM_SUPPLIES, twl6040->supplies);
-regulator_get_err:
-       i2c_set_clientdata(client, NULL);
-
        return ret;
 }
 
@@ -689,7 +686,6 @@ static int twl6040_remove(struct i2c_client *client)
        regmap_del_irq_chip(twl6040->irq, twl6040->irq_data);
 
        mfd_remove_devices(&client->dev);
-       i2c_set_clientdata(client, NULL);
 
        regulator_bulk_disable(TWL6040_NUM_SUPPLIES, twl6040->supplies);