]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net: rocker: Use ether_addr_equal
authorSimon Horman <simon.horman@netronome.com>
Thu, 30 Apr 2015 06:21:29 +0000 (15:21 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 May 2015 01:48:30 +0000 (21:48 -0400)
A small cleanup to make use of the ether_addr_equal helper.

Signed-off-by: Simon Horman <simon.horman@netronome.com>
Acked-by: Scott Feldman <sfeldma@gmail.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker.c

index a570a60533be5531c5881ace3683e69e9d80ece5..062ba168d8934616c7567e314525ca444e64592f 100644 (file)
@@ -2500,7 +2500,7 @@ static int rocker_flow_tbl_bridge(struct rocker_port *rocker_port,
        if (eth_dst_mask) {
                entry->key.bridge.has_eth_dst_mask = 1;
                ether_addr_copy(entry->key.bridge.eth_dst_mask, eth_dst_mask);
-               if (memcmp(eth_dst_mask, ff_mac, ETH_ALEN))
+               if (!ether_addr_equal(eth_dst_mask, ff_mac))
                        wild = true;
        }
 
@@ -2573,7 +2573,7 @@ static int rocker_flow_tbl_acl(struct rocker_port *rocker_port,
 
        priority = ROCKER_PRIORITY_ACL_NORMAL;
        if (eth_dst && eth_dst_mask) {
-               if (memcmp(eth_dst_mask, mcast_mac, ETH_ALEN) == 0)
+               if (ether_addr_equal(eth_dst_mask, mcast_mac))
                        priority = ROCKER_PRIORITY_ACL_DFLT;
                else if (is_link_local_ether_addr(eth_dst))
                        priority = ROCKER_PRIORITY_ACL_CTRL;