]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 19 Apr 2017 09:59:15 +0000 (12:59 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Apr 2017 20:26:10 +0000 (16:26 -0400)
The labels were out of order, so it either could result in an Oops or a
leak.

Fixes: 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/ipoib.c

index 001d2953cb6d2ea3a7ccc1056c84a3dbd54928b0..ec78e637840fd31fb40095b608bdc83e0156f6a5 100644 (file)
@@ -471,10 +471,11 @@ struct net_device *mlx5_rdma_netdev_alloc(struct mlx5_core_dev *mdev,
         */
        return netdev;
 
-free_mdev_resources:
-       mlx5e_destroy_mdev_resources(mdev);
 err_free_netdev:
        free_netdev(netdev);
+free_mdev_resources:
+       mlx5e_destroy_mdev_resources(mdev);
+
        return NULL;
 }
 EXPORT_SYMBOL(mlx5_rdma_netdev_alloc);