]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: chipidea: msm: Fix return value check in ci_hdrc_msm_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 25 Jan 2017 14:02:48 +0000 (14:02 +0000)
committerPeter Chen <peter.chen@nxp.com>
Fri, 3 Feb 2017 08:48:47 +0000 (16:48 +0800)
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 2fc305be364e ("usb: chipidea: msm: Mux over secondary phy at the
right time")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
drivers/usb/chipidea/ci_hdrc_msm.c

index f1ede7909f54397ea624036165787d58408b2b8c..0bdfcdcbf7a5a4265ecb2be8570015c0e9d08e38 100644 (file)
@@ -218,8 +218,8 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
        ci->base = devm_ioremap_resource(&pdev->dev, res);
-       if (!ci->base)
-               return -ENOMEM;
+       if (IS_ERR(ci->base))
+               return PTR_ERR(ci->base);
 
        ci->rcdev.owner = THIS_MODULE;
        ci->rcdev.ops = &ci_hdrc_msm_reset_ops;