]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
platform/x86: intel_telemetry_debugfs: fix some error codes in init
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 30 Jun 2017 07:52:18 +0000 (10:52 +0300)
committerDarren Hart (VMware) <dvhart@infradead.org>
Wed, 5 Jul 2017 18:24:41 +0000 (11:24 -0700)
There are bunch of "goto out;" paths where we don't set the error code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_telemetry_debugfs.c

index 4cc2f4ea0a25043abbfd205465cd3cedeefffa2b..b8be058a875459300ea6f75c1648de9c4ae63d59 100644 (file)
@@ -938,7 +938,7 @@ static struct notifier_block pm_notifier = {
 static int __init telemetry_debugfs_init(void)
 {
        const struct x86_cpu_id *id;
-       int err = -ENOMEM;
+       int err;
        struct dentry *f;
 
        /* Only APL supported for now */
@@ -958,11 +958,10 @@ static int __init telemetry_debugfs_init(void)
 
        register_pm_notifier(&pm_notifier);
 
+       err = -ENOMEM;
        debugfs_conf->telemetry_dbg_dir = debugfs_create_dir("telemetry", NULL);
-       if (!debugfs_conf->telemetry_dbg_dir) {
-               err = -ENOMEM;
+       if (!debugfs_conf->telemetry_dbg_dir)
                goto out_pm;
-       }
 
        f = debugfs_create_file("pss_info", S_IFREG | S_IRUGO,
                                debugfs_conf->telemetry_dbg_dir, NULL,