]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
md/raid5: add thread_group worker async_tx_issue_pending_all
authorOfer Heifetz <oferh@marvell.com>
Mon, 24 Jul 2017 06:17:40 +0000 (09:17 +0300)
committerShaohua Li <shli@fb.com>
Mon, 24 Jul 2017 14:49:15 +0000 (07:49 -0700)
Since thread_group worker and raid5d kthread are not in sync, if
worker writes stripe before raid5d then requests will be waiting
for issue_pendig.

Issue observed when building raid5 with ext4, in some build runs
jbd2 would get hung and requests were waiting in the HW engine
waiting to be issued.

Fix this by adding a call to async_tx_issue_pending_all in the
raid5_do_work.

Signed-off-by: Ofer Heifetz <oferh@marvell.com>
Cc: stable@vger.kernel.org
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/raid5.c

index 4904dffec915e7cf5f3d486f3d902e659ac78c7e..0fc2748aaf95a48a4b1fb227d3b80bffe9cea8d5 100644 (file)
@@ -6234,6 +6234,8 @@ static void raid5_do_work(struct work_struct *work)
        pr_debug("%d stripes handled\n", handled);
 
        spin_unlock_irq(&conf->device_lock);
+
+       async_tx_issue_pending_all();
        blk_finish_plug(&plug);
 
        pr_debug("--- raid5worker inactive\n");