]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mfd: wm831x-i2c: Add NULL check before pointer dereference
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 24 May 2017 09:26:23 +0000 (04:26 -0500)
committerLee Jones <lee.jones@linaro.org>
Thu, 6 Jul 2017 07:29:11 +0000 (08:29 +0100)
Add NULL check before dereferencing pointer of_id in order to avoid
a potential NULL pointer dereference.

Addresses-Coverity-ID: 1408829
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/wm831x-i2c.c

index 781af060f32d45312500139efab006ca391ac83c..22f7054d1b28633da6618d6ec7ab4158953876a8 100644 (file)
@@ -37,6 +37,10 @@ static int wm831x_i2c_probe(struct i2c_client *i2c,
 
        if (i2c->dev.of_node) {
                of_id = of_match_device(wm831x_of_match, &i2c->dev);
+               if (!of_id) {
+                       dev_err(&i2c->dev, "Failed to match device\n");
+                       return -ENODEV;
+               }
                type = (enum wm831x_parent)of_id->data;
        } else {
                type = (enum wm831x_parent)id->driver_data;