IB/core: Fix dereference before check

Sparse complains about dereference before check. Fixing this by
moving the check before the dereference.

Fixes: 200298326b27 ('IB/core: Validate route when we init ah')
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 0b5f24533ac17cfca6cd17a2e0e5b71ed3a598cb..791cc98475bb67d7cce9c9840cc043c604d146c1 100644 (file)
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -497,13 +497,14 @@ int rdma_resolve_ip_route(struct sockaddr *src_addr,
        struct sockaddr_storage ssrc_addr = {};
        struct sockaddr *src_in = (struct sockaddr *)&ssrc_addr;
 
-       if (src_addr->sa_family != dst_addr->sa_family)
-               return -EINVAL;
+       if (src_addr) {
+               if (src_addr->sa_family != dst_addr->sa_family)
+                       return -EINVAL;
 
-       if (src_addr)
                memcpy(src_in, src_addr, rdma_addr_size(src_addr));
-       else
+       } else {
                src_in->sa_family = dst_addr->sa_family;
+       }
 
        return addr_resolve(src_in, dst_addr, addr, false);
 }