]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi/xilinx: signedness issue checking platform_get_irq()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Jul 2013 15:34:48 +0000 (18:34 +0300)
committerMark Brown <broonie@linaro.org>
Wed, 17 Jul 2013 17:19:44 +0000 (18:19 +0100)
In xilinx_spi_probe() we use xspi->irq to store negative error codes so
it has to be signed.  We weren't going to use the upper bit any way so
this is fine.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-xilinx.c

index e5d3716da21a0cfe5a8c830fcdc53e3cb0bbe4e0..dec7e71a833ce70a23a8b9af7363b492ad676312 100644 (file)
@@ -82,7 +82,7 @@ struct xilinx_spi {
        struct completion done;
        void __iomem    *regs;  /* virt. address of the control registers */
 
-       u32             irq;
+       int             irq;
 
        u8 *rx_ptr;             /* pointer in the Tx buffer */
        const u8 *tx_ptr;       /* pointer in the Rx buffer */