]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
vfs: fix dup_mnt_ns
authorSasha Levin <levinsasha928@gmail.com>
Tue, 20 Mar 2012 23:48:19 +0000 (10:48 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 2 Apr 2012 03:18:26 +0000 (13:18 +1000)
Commit f8b88187 ("brlocks/lglocks: cleanups") has accidently dropped the
assignment of the new root into the mnt_fs.

This leads to NULL dereferences since ->root is assumed to be always non-NULL.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/namespace.c

index 5a6208b2daa941249272a75ae3e8bf3be5a5af8e..224aff1c0dfda0d964e8d5248b658c8c8c334af1 100644 (file)
@@ -2250,6 +2250,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,
                kfree(new_ns);
                return ERR_PTR(-ENOMEM);
        }
+       new_ns->root = new;
        br_write_lock(&vfsmount_lock);
        list_add_tail(&new_ns->list, &new->mnt_list);
        br_write_unlock(&vfsmount_lock);