]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mmc: cavium-octeon: Fix interrupt enable code
authorDavid Daney <david.daney@cavium.com>
Tue, 16 May 2017 09:36:51 +0000 (11:36 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 19 May 2017 07:17:44 +0000 (09:17 +0200)
OCTEON SoCs with CIU3 do not have interrupt masking local to the MMC
bus interface.  Unfortunately, some even have a diagnostic register at
the same address of the enable register, which causes the interrupts
to fire immediately if stored to, thus breaking the driver.  The proper
action on these SoCs is not to touch this register.

Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
Signed-off-by: David Daney <david.daney@cavium.com>
[jglauber@cavium.com: removed point after subject line]
Signed-off-by: Jan Glauber <jglauber@cavium.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/cavium-octeon.c

index 772d0900026d0efbd6e59911f93ef9cc8930b38a..d698d66e3327fd469b0fc2a58e8a995fbe056ace 100644 (file)
@@ -108,7 +108,7 @@ static void octeon_mmc_release_bus(struct cvm_mmc_host *host)
 static void octeon_mmc_int_enable(struct cvm_mmc_host *host, u64 val)
 {
        writeq(val, host->base + MIO_EMM_INT(host));
-       if (!host->dma_active || (host->dma_active && !host->has_ciu3))
+       if (!host->has_ciu3)
                writeq(val, host->base + MIO_EMM_INT_EN(host));
 }