]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
RDMA/cxgb4: Fix stack info leak in c4iw_create_qp()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Jul 2013 16:48:32 +0000 (19:48 +0300)
committerRoland Dreier <roland@purestorage.com>
Tue, 30 Jul 2013 17:07:56 +0000 (10:07 -0700)
"uresp.ma_sync_key" doesn't get set on this path so we leak 8 bytes of data.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/cxgb4/qp.c

index 232040447e8a23803cc73e64c203734d36492c2e..a4975e1654a639960b214114648593564fcb0b27 100644 (file)
@@ -1657,6 +1657,8 @@ struct ib_qp *c4iw_create_qp(struct ib_pd *pd, struct ib_qp_init_attr *attrs,
                if (mm5) {
                        uresp.ma_sync_key = ucontext->key;
                        ucontext->key += PAGE_SIZE;
+               } else {
+                       uresp.ma_sync_key =  0;
                }
                uresp.sq_key = ucontext->key;
                ucontext->key += PAGE_SIZE;