]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
powerpc/eeh: Delay probing EEH device during hotplug
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Thu, 30 Apr 2015 23:22:15 +0000 (09:22 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 1 May 2015 03:52:32 +0000 (13:52 +1000)
Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
devices in early stage, which is reasonable to pSeries platform.
However, it's wrong for PowerNV platform because the PE# isn't
determined until the resources (IO and MMIO) are assigned to
PE in hotplug case. So we have to delay probing EEH devices
for PowerNV platform until the PE# is assigned.

Fixes: ff57b454ddb9 ("powerpc/eeh: Do probe on pci_dn")
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/eeh.c

index fa046ca6d0fa6a71514714ea8c3d2b42255a8ed3..9ee61d15653d6ec46546b93ea72601072176e4b7 100644 (file)
@@ -1061,6 +1061,9 @@ void eeh_add_device_early(struct pci_dn *pdn)
        if (!edev || !eeh_enabled())
                return;
 
+       if (!eeh_has_flag(EEH_PROBE_MODE_DEVTREE))
+               return;
+
        /* USB Bus children of PCI devices will not have BUID's */
        phb = edev->phb;
        if (NULL == phb ||
@@ -1115,6 +1118,9 @@ void eeh_add_device_late(struct pci_dev *dev)
                return;
        }
 
+       if (eeh_has_flag(EEH_PROBE_MODE_DEV))
+               eeh_ops->probe(pdn, NULL);
+
        /*
         * The EEH cache might not be removed correctly because of
         * unbalanced kref to the device during unplug time, which