]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Input: gamecon - clear unused function pointers
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 17 Nov 2015 17:33:29 +0000 (09:33 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 17 Nov 2015 18:00:13 +0000 (10:00 -0800)
gc_parport_cb is a local uninitialized structure and the member
function pointers will be pointing to arbitrary locations unless they
are cleared.

Fixes: a517e87c3dfc ("Input: gamecon - use parallel port device model")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/gamecon.c

index 5a672dcac0d8174a151254ac31b591f0189f9d91..eae14d512353aae4902f3ce482c1cf87cba736b6 100644 (file)
@@ -951,6 +951,7 @@ static void gc_attach(struct parport *pp)
        pads = gc_cfg[port_idx].args + 1;
        n_pads = gc_cfg[port_idx].nargs - 1;
 
+       memset(&gc_parport_cb, 0, sizeof(gc_parport_cb));
        gc_parport_cb.flags = PARPORT_FLAG_EXCL;
 
        pd = parport_register_dev_model(pp, "gamecon", &gc_parport_cb,