]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ab8500-charger: We print an unintended error message
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 27 Aug 2013 01:19:42 +0000 (04:19 +0300)
committerAnton Vorontsov <anton@enomsg.org>
Wed, 28 Aug 2013 01:12:40 +0000 (18:12 -0700)
There is a missing break statement here, so we print an error message that
the USB type is invalid.  The original code still works fine though except
for the error message.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
drivers/power/ab8500_charger.c

index f098fdafee9fdfc6cfa09e7316a86beec2c70f66..a4c4a10b3a41cd2e2e05d67773097cbfed686f8f 100644 (file)
@@ -774,6 +774,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di,
                di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P5;
                dev_dbg(di->dev, "USB Type - 0x%02x MaxCurr: %d", link_status,
                                di->max_usb_in_curr.usb_type_max);
+               break;
        case USB_STAT_NOT_VALID_LINK:
                dev_err(di->dev, "USB Type invalid - try charging anyway\n");
                di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P5;