]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ath5k: fix buffer overrun in rate debug code
authorBob Copeland <me@bobcopeland.com>
Tue, 28 Apr 2009 02:12:43 +0000 (22:12 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 May 2009 22:45:09 +0000 (15:45 -0700)
commit b7fcb5c4a4c27da2f6d86cb03d18687e537442cf upstream.

char bname[5] is too small for the string "X GHz" when the null
terminator is taken into account.  Thus, turning on rate debugging
can crash unless we have lucky stack alignment.

Cc: stable@kernel.org
Reported-by: Paride Legovini <legovini@spiro.fisica.unipd.it>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/ath5k/debug.c

index ccaeb5c219d2ddda8ea8e7f160a8f9a472c8c89a..9347a3cee8e63d141d1b9a61fe51ef1575ef7fdb 100644 (file)
@@ -465,7 +465,7 @@ ath5k_debug_dump_bands(struct ath5k_softc *sc)
 
        for (b = 0; b < IEEE80211_NUM_BANDS; b++) {
                struct ieee80211_supported_band *band = &sc->sbands[b];
-               char bname[5];
+               char bname[6];
                switch (band->band) {
                case IEEE80211_BAND_2GHZ:
                        strcpy(bname, "2 GHz");