The "goto out" statements were wrong. We aren't holding any locks at
that point so we should return directly.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
static int atmel_usba_start(struct usb_gadget *gadget,
struct usb_gadget_driver *driver)
{
static int atmel_usba_start(struct usb_gadget *gadget,
struct usb_gadget_driver *driver)
{
struct usba_udc *udc = container_of(gadget, struct usba_udc, gadget);
unsigned long flags;
struct usba_udc *udc = container_of(gadget, struct usba_udc, gadget);
unsigned long flags;
ret = clk_prepare_enable(udc->pclk);
if (ret)
ret = clk_prepare_enable(udc->pclk);
if (ret)
ret = clk_prepare_enable(udc->hclk);
if (ret) {
clk_disable_unprepare(udc->pclk);
ret = clk_prepare_enable(udc->hclk);
if (ret) {
clk_disable_unprepare(udc->pclk);
}
DBG(DBG_GADGET, "registered driver `%s'\n", driver->driver.name);
}
DBG(DBG_GADGET, "registered driver `%s'\n", driver->driver.name);
usba_writel(udc, CTRL, USBA_ENABLE_MASK);
usba_writel(udc, INT_ENB, USBA_END_OF_RESET);
}
usba_writel(udc, CTRL, USBA_ENABLE_MASK);
usba_writel(udc, INT_ENB, USBA_END_OF_RESET);
}
spin_unlock_irqrestore(&udc->lock, flags);
spin_unlock_irqrestore(&udc->lock, flags);
}
static int atmel_usba_stop(struct usb_gadget *gadget,
}
static int atmel_usba_stop(struct usb_gadget *gadget,