]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
mmc: fix mmc_set_bus_width_ddr() call without bus-width-test cap
authorTakashi Iwai <tiwai@suse.de>
Wed, 22 Dec 2010 08:59:44 +0000 (09:59 +0100)
committerChris Ball <cjb@laptop.org>
Sun, 9 Jan 2011 04:52:24 +0000 (23:52 -0500)
With the bus-width test patch, mmc_set_bus_width*() isn't called properly
when the driver doesn't set MMC_CAP_BUS_WIDTH and no DDR mode.
This patch fixes the regression by moving the call up before the cap test.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Chris Ball <cjb@laptop.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/core/mmc.c

index 1d8409fcf1558cbad6b5fc72103f2e684e67bf48..c86dd7384d7dd3355898d6347a6506fa1a7dc12b 100644 (file)
@@ -558,6 +558,8 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
                                         EXT_CSD_BUS_WIDTH,
                                         ext_csd_bits[idx][0]);
                        if (!err) {
+                               mmc_set_bus_width_ddr(card->host,
+                                                     bus_width, MMC_SDR_MODE);
                                /*
                                 * If controller can't handle bus width test,
                                 * use the highest bus width to maintain
@@ -565,8 +567,6 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
                                 */
                                if (!(host->caps & MMC_CAP_BUS_WIDTH_TEST))
                                        break;
-                               mmc_set_bus_width_ddr(card->host,
-                                                     bus_width, MMC_SDR_MODE);
                                err = mmc_bus_test(card, bus_width);
                                if (!err)
                                        break;