]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
V4L/DVB: drivers/media/video: Use available error codes
authorJulia Lawall <julia@diku.dk>
Mon, 16 Aug 2010 16:27:47 +0000 (13:27 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Oct 2010 03:04:48 +0000 (01:04 -0200)
Error codes are stored in rc, but the return value is always 0.  Return rc
instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/zr364xx.c

index a82b5bd18d26c65994f9231b5ceba003c7e88daa..616c61fb3493bd6ae7cfe761a50f1b5ed915ff40 100644 (file)
@@ -572,7 +572,7 @@ static int zr364xx_got_frame(struct zr364xx_camera *cam, int jpgsize)
        DBG("wakeup [buf/i] [%p/%d]\n", buf, buf->vb.i);
 unlock:
        spin_unlock_irqrestore(&cam->slock, flags);
-       return 0;
+       return rc;
 }
 
 /* this function moves the usb stream read pipe data